From: Vivek Unune <npcomplete13@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: devicetree@vger.kernel.org, "Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl
Date: Thu, 8 Oct 2020 08:41:13 -0400 [thread overview]
Message-ID: <20201008124113.GA5106@ubuntu> (raw)
In-Reply-To: <20201008002621.GF112961@lunn.ch>
On Thu, Oct 08, 2020 at 02:26:21AM +0200, Andrew Lunn wrote:
> On Wed, Oct 07, 2020 at 05:46:33PM -0400, Vivek Unune wrote:
> > On Wed, Oct 07, 2020 at 11:01:34PM +0200, Andrew Lunn wrote:
> > > On Wed, Oct 07, 2020 at 03:01:50PM -0400, Vivek Unune wrote:
> > > > Forgo the use of mmioreg mdio mux infavor of the pinctrl
> > >
> > > Hi Vivek
> > >
> > > Could you add some more details please. I don't know this
> > > hardware. I'm assuming there are two MDIO busses, external as talked
> > > about in the comments, and an internal one? And for this hardware you
> > > only need one of them? But i don't see what pinmux has to do with
> > > this?
> > Hi Andrew,
> >
> > There are indeed two mdio busses. To access the external bus, 9th bit
> > of the mdio register has to be set. And to enable mii function,
> > one has to set the registers 6 & 7 which is part of the pin controller.
> > Earlier the pin controller was not defined and I resorted to use a
> > combination of memory mapped io mux to change desired bits.
> >
> > Now that we have a pin controller - which is resposnsible for other
> > functionality such as pwm, i2c, uart2, it makes sense to have a consistent
> > device tree
>
> What makes it confusing is that you make multiple changes at once. It
> would be easier to follow if you added the pinmux and removed the
> mmioreg mux, and move the switch into the mdio-bus-mux node. Then in a
> second patch rearrange the mdio-bus-mux. Small simple steps, with good
> commit messages are much easier to follow and say, Yes, this is
> correct.
>
Sure, le me declutter this.
Thanks,
Vivek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Unune <npcomplete13@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: devicetree@vger.kernel.org, "Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl
Date: Thu, 8 Oct 2020 08:41:13 -0400 [thread overview]
Message-ID: <20201008124113.GA5106@ubuntu> (raw)
In-Reply-To: <20201008002621.GF112961@lunn.ch>
On Thu, Oct 08, 2020 at 02:26:21AM +0200, Andrew Lunn wrote:
> On Wed, Oct 07, 2020 at 05:46:33PM -0400, Vivek Unune wrote:
> > On Wed, Oct 07, 2020 at 11:01:34PM +0200, Andrew Lunn wrote:
> > > On Wed, Oct 07, 2020 at 03:01:50PM -0400, Vivek Unune wrote:
> > > > Forgo the use of mmioreg mdio mux infavor of the pinctrl
> > >
> > > Hi Vivek
> > >
> > > Could you add some more details please. I don't know this
> > > hardware. I'm assuming there are two MDIO busses, external as talked
> > > about in the comments, and an internal one? And for this hardware you
> > > only need one of them? But i don't see what pinmux has to do with
> > > this?
> > Hi Andrew,
> >
> > There are indeed two mdio busses. To access the external bus, 9th bit
> > of the mdio register has to be set. And to enable mii function,
> > one has to set the registers 6 & 7 which is part of the pin controller.
> > Earlier the pin controller was not defined and I resorted to use a
> > combination of memory mapped io mux to change desired bits.
> >
> > Now that we have a pin controller - which is resposnsible for other
> > functionality such as pwm, i2c, uart2, it makes sense to have a consistent
> > device tree
>
> What makes it confusing is that you make multiple changes at once. It
> would be easier to follow if you added the pinmux and removed the
> mmioreg mux, and move the switch into the mdio-bus-mux node. Then in a
> second patch rearrange the mdio-bus-mux. Small simple steps, with good
> commit messages are much easier to follow and say, Yes, this is
> correct.
>
Sure, le me declutter this.
Thanks,
Vivek
next prev parent reply other threads:[~2020-10-08 12:42 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 19:01 [PATCH 0/3] ARM: dts: BCM5301X: Linksys EA9500 device tree changes Vivek Unune
2020-10-07 19:01 ` Vivek Unune
2020-10-07 19:01 ` [PATCH 1/3] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl Vivek Unune
2020-10-07 19:01 ` Vivek Unune
2020-10-07 21:01 ` Andrew Lunn
2020-10-07 21:01 ` Andrew Lunn
2020-10-07 21:46 ` Vivek Unune
2020-10-07 21:46 ` Vivek Unune
2020-10-08 0:26 ` Andrew Lunn
2020-10-08 0:26 ` Andrew Lunn
2020-10-08 12:41 ` Vivek Unune [this message]
2020-10-08 12:41 ` Vivek Unune
2020-11-04 20:29 ` [PATCH v2 0/2] " Vivek Unune
2020-11-04 20:29 ` Vivek Unune
2020-11-04 20:29 ` [PATCH v2 1/2] ARM: dts: BCM5301X: pinctrl - use correct driver and define mdio pins Vivek Unune
2020-11-04 20:29 ` Vivek Unune
2020-11-09 17:21 ` Rafał Miłecki
2020-11-09 17:21 ` Rafał Miłecki
2020-11-09 17:25 ` Florian Fainelli
2020-11-09 17:25 ` Florian Fainelli
2020-11-04 20:29 ` [PATCH v2 2/2] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl Vivek Unune
2020-11-04 20:29 ` Vivek Unune
2020-11-04 20:37 ` Florian Fainelli
2020-11-04 20:37 ` Florian Fainelli
2020-11-04 20:58 ` Vivek Unune
2020-11-04 20:58 ` Vivek Unune
2020-11-09 13:24 ` Vivek Unune
2020-11-09 13:24 ` Vivek Unune
2020-11-09 15:54 ` Florian Fainelli
2020-11-09 15:54 ` Florian Fainelli
2020-11-09 17:24 ` Florian Fainelli
2020-11-09 17:24 ` Florian Fainelli
2020-11-10 13:17 ` Vivek Unune
2020-11-10 13:17 ` Vivek Unune
2020-10-07 19:01 ` [PATCH 2/3] ARM: dts: BCM5301X: Linksys EA9500 add port 5 and port 7 Vivek Unune
2020-10-07 19:01 ` Vivek Unune
2020-10-07 21:03 ` Andrew Lunn
2020-10-07 21:03 ` Andrew Lunn
2020-10-07 22:07 ` Vivek Unune
2020-10-07 22:07 ` Vivek Unune
2020-10-08 0:32 ` Andrew Lunn
2020-10-08 0:32 ` Andrew Lunn
2020-10-08 14:58 ` Florian Fainelli
2020-10-08 14:58 ` Florian Fainelli
2020-10-08 20:20 ` Vivek Unune
2020-10-08 20:20 ` Vivek Unune
2020-10-07 19:01 ` [PATCH 3/3] ARM: dts: BCM5301X: Linksys EA9500 add fixed partitions Vivek Unune
2020-10-07 19:01 ` Vivek Unune
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008124113.GA5106@ubuntu \
--to=npcomplete13@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.