All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Unune <npcomplete13@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: devicetree@vger.kernel.org, hauke@hauke-m.de, zajec5@gmail.com,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl
Date: Wed, 4 Nov 2020 15:58:36 -0500	[thread overview]
Message-ID: <20201104205836.GA783888@ubuntu> (raw)
In-Reply-To: <c0d62a2e-59e2-c811-f5bd-e7299f540ca3@gmail.com>

On Wed, Nov 04, 2020 at 12:37:45PM -0800, Florian Fainelli wrote:
> 
> 
> On 11/4/2020 12:29 PM, Vivek Unune wrote:
> > Now that we have a pin controller, use that instead of manuplating the
> > mdio/mdc pins directly. i.e. we no longer require the mdio-mii-mux
> 
> I am a bit confused here as I thought the mux was intended to
> dynamically switch the pins in order to support both internal and
> external MDIO devices but given the register ranges that were used,
> these were actually the pinmux configuration for the MDC and MDIO pins.
> 
> This does not break USB and/or PCIe PHY communication does it?

Hi Florian,

The external and internal MDIO logic is controlled by mdio-bus-mux.
Which controls the BIT(9) of the mdio register. This stays.

The removal of mdio-mii-mux and it's replacement with usage of
pinctrl doesn't affect USB3 or PCIe. See below USB3 detection.

[ 4295.450118] usb 1-1: new high-speed USB device number 2 using ehci-platform
[ 4295.690183] usb 4-1: new SuperSpeed Gen 1 USB device number 2 using xhci-hcd
[ 4295.721888] usb-storage 4-1:1.0: USB Mass Storage device detected
[ 4295.728349] scsi host0: usb-storage 4-1:1.0
[ 4296.811047] scsi 0:0:0:0: Direct-Access     SanDisk  Ultra Fit        1.00 PQ: 0 ANSI: 6
[ 4296.821159] sd 0:0:0:0: [sda] 60063744 512-byte logical blocks: (30.8 GB/28.6 GiB)
[ 4296.829667] sd 0:0:0:0: [sda] Write Protect is off
[ 4296.834502] sd 0:0:0:0: [sda] Mode Sense: 43 00 00 00
[ 4296.834864] sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
[ 4296.852604] GPT:Primary header thinks Alt. header is not at the end of the disk.
[ 4296.860079] GPT:1540387 != 60063743
[ 4296.863586] GPT:Alternate GPT header not at the end of the disk.
[ 4296.869600] GPT:1540387 != 60063743
[ 4296.873090] GPT: Use GNU Parted to correct GPT errors.
[ 4296.878266]  sda: sda1 sda2
[ 4296.884416] sd 0:0:0:0: [sda] Attached SCSI removable disk


Thanks,

Vivek

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Unune <npcomplete13@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: hauke@hauke-m.de, zajec5@gmail.com,
	bcm-kernel-feedback-list@broadcom.com, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl
Date: Wed, 4 Nov 2020 15:58:36 -0500	[thread overview]
Message-ID: <20201104205836.GA783888@ubuntu> (raw)
In-Reply-To: <c0d62a2e-59e2-c811-f5bd-e7299f540ca3@gmail.com>

On Wed, Nov 04, 2020 at 12:37:45PM -0800, Florian Fainelli wrote:
> 
> 
> On 11/4/2020 12:29 PM, Vivek Unune wrote:
> > Now that we have a pin controller, use that instead of manuplating the
> > mdio/mdc pins directly. i.e. we no longer require the mdio-mii-mux
> 
> I am a bit confused here as I thought the mux was intended to
> dynamically switch the pins in order to support both internal and
> external MDIO devices but given the register ranges that were used,
> these were actually the pinmux configuration for the MDC and MDIO pins.
> 
> This does not break USB and/or PCIe PHY communication does it?

Hi Florian,

The external and internal MDIO logic is controlled by mdio-bus-mux.
Which controls the BIT(9) of the mdio register. This stays.

The removal of mdio-mii-mux and it's replacement with usage of
pinctrl doesn't affect USB3 or PCIe. See below USB3 detection.

[ 4295.450118] usb 1-1: new high-speed USB device number 2 using ehci-platform
[ 4295.690183] usb 4-1: new SuperSpeed Gen 1 USB device number 2 using xhci-hcd
[ 4295.721888] usb-storage 4-1:1.0: USB Mass Storage device detected
[ 4295.728349] scsi host0: usb-storage 4-1:1.0
[ 4296.811047] scsi 0:0:0:0: Direct-Access     SanDisk  Ultra Fit        1.00 PQ: 0 ANSI: 6
[ 4296.821159] sd 0:0:0:0: [sda] 60063744 512-byte logical blocks: (30.8 GB/28.6 GiB)
[ 4296.829667] sd 0:0:0:0: [sda] Write Protect is off
[ 4296.834502] sd 0:0:0:0: [sda] Mode Sense: 43 00 00 00
[ 4296.834864] sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
[ 4296.852604] GPT:Primary header thinks Alt. header is not at the end of the disk.
[ 4296.860079] GPT:1540387 != 60063743
[ 4296.863586] GPT:Alternate GPT header not at the end of the disk.
[ 4296.869600] GPT:1540387 != 60063743
[ 4296.873090] GPT: Use GNU Parted to correct GPT errors.
[ 4296.878266]  sda: sda1 sda2
[ 4296.884416] sd 0:0:0:0: [sda] Attached SCSI removable disk


Thanks,

Vivek

  reply	other threads:[~2020-11-05  3:42 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 19:01 [PATCH 0/3] ARM: dts: BCM5301X: Linksys EA9500 device tree changes Vivek Unune
2020-10-07 19:01 ` Vivek Unune
2020-10-07 19:01 ` [PATCH 1/3] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl Vivek Unune
2020-10-07 19:01   ` Vivek Unune
2020-10-07 21:01   ` Andrew Lunn
2020-10-07 21:01     ` Andrew Lunn
2020-10-07 21:46     ` Vivek Unune
2020-10-07 21:46       ` Vivek Unune
2020-10-08  0:26       ` Andrew Lunn
2020-10-08  0:26         ` Andrew Lunn
2020-10-08 12:41         ` Vivek Unune
2020-10-08 12:41           ` Vivek Unune
2020-11-04 20:29   ` [PATCH v2 0/2] " Vivek Unune
2020-11-04 20:29     ` Vivek Unune
2020-11-04 20:29     ` [PATCH v2 1/2] ARM: dts: BCM5301X: pinctrl - use correct driver and define mdio pins Vivek Unune
2020-11-04 20:29       ` Vivek Unune
2020-11-09 17:21       ` Rafał Miłecki
2020-11-09 17:21         ` Rafał Miłecki
2020-11-09 17:25         ` Florian Fainelli
2020-11-09 17:25           ` Florian Fainelli
2020-11-04 20:29     ` [PATCH v2 2/2] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl Vivek Unune
2020-11-04 20:29       ` Vivek Unune
2020-11-04 20:37       ` Florian Fainelli
2020-11-04 20:37         ` Florian Fainelli
2020-11-04 20:58         ` Vivek Unune [this message]
2020-11-04 20:58           ` Vivek Unune
2020-11-09 13:24           ` Vivek Unune
2020-11-09 13:24             ` Vivek Unune
2020-11-09 15:54             ` Florian Fainelli
2020-11-09 15:54               ` Florian Fainelli
2020-11-09 17:24       ` Florian Fainelli
2020-11-09 17:24         ` Florian Fainelli
2020-11-10 13:17         ` Vivek Unune
2020-11-10 13:17           ` Vivek Unune
2020-10-07 19:01 ` [PATCH 2/3] ARM: dts: BCM5301X: Linksys EA9500 add port 5 and port 7 Vivek Unune
2020-10-07 19:01   ` Vivek Unune
2020-10-07 21:03   ` Andrew Lunn
2020-10-07 21:03     ` Andrew Lunn
2020-10-07 22:07     ` Vivek Unune
2020-10-07 22:07       ` Vivek Unune
2020-10-08  0:32       ` Andrew Lunn
2020-10-08  0:32         ` Andrew Lunn
2020-10-08 14:58         ` Florian Fainelli
2020-10-08 14:58           ` Florian Fainelli
2020-10-08 20:20           ` Vivek Unune
2020-10-08 20:20             ` Vivek Unune
2020-10-07 19:01 ` [PATCH 3/3] ARM: dts: BCM5301X: Linksys EA9500 add fixed partitions Vivek Unune
2020-10-07 19:01   ` Vivek Unune

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104205836.GA783888@ubuntu \
    --to=npcomplete13@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=hauke@hauke-m.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.