From: Satya Tangirala <satyat@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>,
Eric Biggers <ebiggers@google.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
dm-devel@redhat.com, Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH v2 2/4] block: add private field to struct keyslot_manager
Date: Fri, 16 Oct 2020 08:39:23 +0000 [thread overview]
Message-ID: <20201016083923.GA134672@google.com> (raw)
In-Reply-To: <20201016071941.GA14885@infradead.org>
On Fri, Oct 16, 2020 at 08:19:41AM +0100, Christoph Hellwig wrote:
> On Thu, Oct 15, 2020 at 09:46:30PM +0000, Satya Tangirala wrote:
> > Add a (void *) pointer to struct keyslot_manager that the owner of the
> > struct can use for any purpose it wants.
> >
> > Right now, the struct keyslot_manager is expected to be embedded directly
> > into other structs (and the owner of the keyslot_manager would use
> > container_of() to access any other data the owner needs). However, this
> > might take up more space than is acceptable, and it would be better to be
> > able to add only a pointer to a struct keyslot_manager into other structs
> > rather than embed the entire struct directly. But container_of() can't be
> > used when only the pointer to the keyslot_manager is embded. The primary
> > motivation of this patch is to get around that issue.
>
> No, please don't bloat the structure. If some weird caller doesn't
> like the embedding it can create a container structure with the
> blk_keyslot_manager structure and a backpointer.
Ah, ok. Thanks!
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Satya Tangirala <satyat@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, Jens Axboe <axboe@kernel.dk>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2 2/4] block: add private field to struct keyslot_manager
Date: Fri, 16 Oct 2020 08:39:23 +0000 [thread overview]
Message-ID: <20201016083923.GA134672@google.com> (raw)
In-Reply-To: <20201016071941.GA14885@infradead.org>
On Fri, Oct 16, 2020 at 08:19:41AM +0100, Christoph Hellwig wrote:
> On Thu, Oct 15, 2020 at 09:46:30PM +0000, Satya Tangirala wrote:
> > Add a (void *) pointer to struct keyslot_manager that the owner of the
> > struct can use for any purpose it wants.
> >
> > Right now, the struct keyslot_manager is expected to be embedded directly
> > into other structs (and the owner of the keyslot_manager would use
> > container_of() to access any other data the owner needs). However, this
> > might take up more space than is acceptable, and it would be better to be
> > able to add only a pointer to a struct keyslot_manager into other structs
> > rather than embed the entire struct directly. But container_of() can't be
> > used when only the pointer to the keyslot_manager is embded. The primary
> > motivation of this patch is to get around that issue.
>
> No, please don't bloat the structure. If some weird caller doesn't
> like the embedding it can create a container structure with the
> blk_keyslot_manager structure and a backpointer.
Ah, ok. Thanks!
next prev parent reply other threads:[~2020-10-16 10:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 21:46 [dm-devel] [PATCH v2 0/4] add support for inline encryption to device mapper Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-15 21:46 ` [dm-devel] [PATCH v2 1/4] block: keyslot-manager: Introduce passthrough keyslot manager Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-16 7:20 ` [dm-devel] " Christoph Hellwig
2020-10-16 7:20 ` Christoph Hellwig
2020-10-21 4:44 ` [dm-devel] " Eric Biggers
2020-10-21 4:44 ` Eric Biggers
2020-10-21 5:27 ` [dm-devel] " Satya Tangirala
2020-10-21 5:27 ` Satya Tangirala
2020-10-27 20:04 ` [dm-devel] " Eric Biggers
2020-10-27 20:04 ` Eric Biggers
2020-10-15 21:46 ` [dm-devel] [PATCH v2 2/4] block: add private field to struct keyslot_manager Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-16 7:19 ` [dm-devel] " Christoph Hellwig
2020-10-16 7:19 ` Christoph Hellwig
2020-10-16 8:39 ` Satya Tangirala [this message]
2020-10-16 8:39 ` Satya Tangirala
2020-10-15 21:46 ` [dm-devel] [PATCH v2 3/4] dm: add support for passing through inline crypto support Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-25 21:02 ` [dm-devel] " kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-25 21:02 ` [dm-devel] [PATCH] dm: fix err_cast.cocci warnings kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-27 21:31 ` [dm-devel] [PATCH v2 3/4] dm: add support for passing through inline crypto support Eric Biggers
2020-10-27 21:31 ` Eric Biggers
2020-10-27 23:58 ` [dm-devel] " Satya Tangirala
2020-10-27 23:58 ` Satya Tangirala
2020-10-28 0:17 ` [dm-devel] " Eric Biggers
2020-10-28 0:17 ` Eric Biggers
2020-10-29 4:44 ` [dm-devel] " Satya Tangirala
2020-10-29 4:44 ` Satya Tangirala
2020-10-15 21:46 ` [dm-devel] [PATCH v2 4/4] dm: enable may_passthrough_inline_crypto on some targets Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-27 21:10 ` [dm-devel] " Eric Biggers
2020-10-27 21:10 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016083923.GA134672@google.com \
--to=satyat@google.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=ebiggers@google.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.