From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
dm-devel@redhat.com, Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH v2 4/4] dm: enable may_passthrough_inline_crypto on some targets
Date: Tue, 27 Oct 2020 14:10:22 -0700 [thread overview]
Message-ID: <20201027211022.GB2416412@gmail.com> (raw)
In-Reply-To: <20201015214632.41951-5-satyat@google.com>
On Thu, Oct 15, 2020 at 09:46:32PM +0000, Satya Tangirala wrote:
> dm-linear and dm-flakey obviously can pass through inline crypto support.
>
> Co-developed-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Satya Tangirala <satyat@google.com>
> ---
> drivers/md/dm-flakey.c | 1 +
> drivers/md/dm-linear.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/md/dm-flakey.c b/drivers/md/dm-flakey.c
> index a2cc9e45cbba..655286dacc35 100644
> --- a/drivers/md/dm-flakey.c
> +++ b/drivers/md/dm-flakey.c
> @@ -253,6 +253,7 @@ static int flakey_ctr(struct dm_target *ti, unsigned int argc, char **argv)
> ti->num_discard_bios = 1;
> ti->per_io_data_size = sizeof(struct per_bio_data);
> ti->private = fc;
> + ti->may_passthrough_inline_crypto = true;
> return 0;
>
> bad:
> diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c
> index 00774b5d7668..345e22b9be5d 100644
> --- a/drivers/md/dm-linear.c
> +++ b/drivers/md/dm-linear.c
> @@ -62,6 +62,7 @@ static int linear_ctr(struct dm_target *ti, unsigned int argc, char **argv)
> ti->num_secure_erase_bios = 1;
> ti->num_write_same_bios = 1;
> ti->num_write_zeroes_bios = 1;
> + ti->may_passthrough_inline_crypto = true;
> ti->private = lc;
> return 0;
How about instead using a flag DM_TARGET_PASSES_CRYPTO in target_type::features,
analogous to DM_TARGET_PASSES_INTEGRITY?
- Eric
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, Jens Axboe <axboe@kernel.dk>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH v2 4/4] dm: enable may_passthrough_inline_crypto on some targets
Date: Tue, 27 Oct 2020 14:10:22 -0700 [thread overview]
Message-ID: <20201027211022.GB2416412@gmail.com> (raw)
In-Reply-To: <20201015214632.41951-5-satyat@google.com>
On Thu, Oct 15, 2020 at 09:46:32PM +0000, Satya Tangirala wrote:
> dm-linear and dm-flakey obviously can pass through inline crypto support.
>
> Co-developed-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Satya Tangirala <satyat@google.com>
> ---
> drivers/md/dm-flakey.c | 1 +
> drivers/md/dm-linear.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/md/dm-flakey.c b/drivers/md/dm-flakey.c
> index a2cc9e45cbba..655286dacc35 100644
> --- a/drivers/md/dm-flakey.c
> +++ b/drivers/md/dm-flakey.c
> @@ -253,6 +253,7 @@ static int flakey_ctr(struct dm_target *ti, unsigned int argc, char **argv)
> ti->num_discard_bios = 1;
> ti->per_io_data_size = sizeof(struct per_bio_data);
> ti->private = fc;
> + ti->may_passthrough_inline_crypto = true;
> return 0;
>
> bad:
> diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c
> index 00774b5d7668..345e22b9be5d 100644
> --- a/drivers/md/dm-linear.c
> +++ b/drivers/md/dm-linear.c
> @@ -62,6 +62,7 @@ static int linear_ctr(struct dm_target *ti, unsigned int argc, char **argv)
> ti->num_secure_erase_bios = 1;
> ti->num_write_same_bios = 1;
> ti->num_write_zeroes_bios = 1;
> + ti->may_passthrough_inline_crypto = true;
> ti->private = lc;
> return 0;
How about instead using a flag DM_TARGET_PASSES_CRYPTO in target_type::features,
analogous to DM_TARGET_PASSES_INTEGRITY?
- Eric
next prev parent reply other threads:[~2020-10-27 21:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 21:46 [dm-devel] [PATCH v2 0/4] add support for inline encryption to device mapper Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-15 21:46 ` [dm-devel] [PATCH v2 1/4] block: keyslot-manager: Introduce passthrough keyslot manager Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-16 7:20 ` [dm-devel] " Christoph Hellwig
2020-10-16 7:20 ` Christoph Hellwig
2020-10-21 4:44 ` [dm-devel] " Eric Biggers
2020-10-21 4:44 ` Eric Biggers
2020-10-21 5:27 ` [dm-devel] " Satya Tangirala
2020-10-21 5:27 ` Satya Tangirala
2020-10-27 20:04 ` [dm-devel] " Eric Biggers
2020-10-27 20:04 ` Eric Biggers
2020-10-15 21:46 ` [dm-devel] [PATCH v2 2/4] block: add private field to struct keyslot_manager Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-16 7:19 ` [dm-devel] " Christoph Hellwig
2020-10-16 7:19 ` Christoph Hellwig
2020-10-16 8:39 ` [dm-devel] " Satya Tangirala
2020-10-16 8:39 ` Satya Tangirala
2020-10-15 21:46 ` [dm-devel] [PATCH v2 3/4] dm: add support for passing through inline crypto support Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-25 21:02 ` [dm-devel] " kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-25 21:02 ` [dm-devel] [PATCH] dm: fix err_cast.cocci warnings kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-27 21:31 ` [dm-devel] [PATCH v2 3/4] dm: add support for passing through inline crypto support Eric Biggers
2020-10-27 21:31 ` Eric Biggers
2020-10-27 23:58 ` [dm-devel] " Satya Tangirala
2020-10-27 23:58 ` Satya Tangirala
2020-10-28 0:17 ` [dm-devel] " Eric Biggers
2020-10-28 0:17 ` Eric Biggers
2020-10-29 4:44 ` [dm-devel] " Satya Tangirala
2020-10-29 4:44 ` Satya Tangirala
2020-10-15 21:46 ` [dm-devel] [PATCH v2 4/4] dm: enable may_passthrough_inline_crypto on some targets Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-27 21:10 ` Eric Biggers [this message]
2020-10-27 21:10 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027211022.GB2416412@gmail.com \
--to=ebiggers@kernel.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=satyat@google.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.