From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
dm-devel@redhat.com, Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH v2 1/4] block: keyslot-manager: Introduce passthrough keyslot manager
Date: Tue, 27 Oct 2020 13:04:41 -0700 [thread overview]
Message-ID: <20201027200441.GA2416412@gmail.com> (raw)
In-Reply-To: <20201015214632.41951-2-satyat@google.com>
On Thu, Oct 15, 2020 at 09:46:29PM +0000, Satya Tangirala wrote:
> +/**
> + * blk_ksm_init_passthrough() - Init a passthrough keyslot manager
> + * @ksm: The keyslot manager to init
> + *
> + * Initialize a passthrough keyslot manager.
> + * Called by e.g. storage drivers to set up a keyslot manager in their
> + * request_queue, when the storage driver wants to manage its keys by itself.
> + * This is useful for inline encryption hardware that doesn't have the concept
> + * of keyslots, and for layered devices.
> + *
> + * See blk_ksm_init() for more details about the parameters.
> + */
> +void blk_ksm_init_passthrough(struct blk_keyslot_manager *ksm)
> +{
> + memset(ksm, 0, sizeof(*ksm));
> + init_rwsem(&ksm->lock);
> +}
> +EXPORT_SYMBOL_GPL(blk_ksm_init_passthrough);
The last paragraph of the comment ("See blk_ksm_init() for more details about
the parameters.") isn't useful and should be removed.
Otherwise this patch looks fine. You can add:
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, Jens Axboe <axboe@kernel.dk>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH v2 1/4] block: keyslot-manager: Introduce passthrough keyslot manager
Date: Tue, 27 Oct 2020 13:04:41 -0700 [thread overview]
Message-ID: <20201027200441.GA2416412@gmail.com> (raw)
In-Reply-To: <20201015214632.41951-2-satyat@google.com>
On Thu, Oct 15, 2020 at 09:46:29PM +0000, Satya Tangirala wrote:
> +/**
> + * blk_ksm_init_passthrough() - Init a passthrough keyslot manager
> + * @ksm: The keyslot manager to init
> + *
> + * Initialize a passthrough keyslot manager.
> + * Called by e.g. storage drivers to set up a keyslot manager in their
> + * request_queue, when the storage driver wants to manage its keys by itself.
> + * This is useful for inline encryption hardware that doesn't have the concept
> + * of keyslots, and for layered devices.
> + *
> + * See blk_ksm_init() for more details about the parameters.
> + */
> +void blk_ksm_init_passthrough(struct blk_keyslot_manager *ksm)
> +{
> + memset(ksm, 0, sizeof(*ksm));
> + init_rwsem(&ksm->lock);
> +}
> +EXPORT_SYMBOL_GPL(blk_ksm_init_passthrough);
The last paragraph of the comment ("See blk_ksm_init() for more details about
the parameters.") isn't useful and should be removed.
Otherwise this patch looks fine. You can add:
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
next prev parent reply other threads:[~2020-10-27 20:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 21:46 [dm-devel] [PATCH v2 0/4] add support for inline encryption to device mapper Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-15 21:46 ` [dm-devel] [PATCH v2 1/4] block: keyslot-manager: Introduce passthrough keyslot manager Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-16 7:20 ` [dm-devel] " Christoph Hellwig
2020-10-16 7:20 ` Christoph Hellwig
2020-10-21 4:44 ` [dm-devel] " Eric Biggers
2020-10-21 4:44 ` Eric Biggers
2020-10-21 5:27 ` [dm-devel] " Satya Tangirala
2020-10-21 5:27 ` Satya Tangirala
2020-10-27 20:04 ` Eric Biggers [this message]
2020-10-27 20:04 ` Eric Biggers
2020-10-15 21:46 ` [dm-devel] [PATCH v2 2/4] block: add private field to struct keyslot_manager Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-16 7:19 ` [dm-devel] " Christoph Hellwig
2020-10-16 7:19 ` Christoph Hellwig
2020-10-16 8:39 ` [dm-devel] " Satya Tangirala
2020-10-16 8:39 ` Satya Tangirala
2020-10-15 21:46 ` [dm-devel] [PATCH v2 3/4] dm: add support for passing through inline crypto support Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-25 21:02 ` [dm-devel] " kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-25 21:02 ` [dm-devel] [PATCH] dm: fix err_cast.cocci warnings kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-25 21:02 ` kernel test robot
2020-10-27 21:31 ` [dm-devel] [PATCH v2 3/4] dm: add support for passing through inline crypto support Eric Biggers
2020-10-27 21:31 ` Eric Biggers
2020-10-27 23:58 ` [dm-devel] " Satya Tangirala
2020-10-27 23:58 ` Satya Tangirala
2020-10-28 0:17 ` [dm-devel] " Eric Biggers
2020-10-28 0:17 ` Eric Biggers
2020-10-29 4:44 ` [dm-devel] " Satya Tangirala
2020-10-29 4:44 ` Satya Tangirala
2020-10-15 21:46 ` [dm-devel] [PATCH v2 4/4] dm: enable may_passthrough_inline_crypto on some targets Satya Tangirala
2020-10-15 21:46 ` Satya Tangirala
2020-10-27 21:10 ` [dm-devel] " Eric Biggers
2020-10-27 21:10 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027200441.GA2416412@gmail.com \
--to=ebiggers@kernel.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=satyat@google.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.