Re: [PATCH 13/18] mtd: nand: mxic-ecc: Support SPI pipelined mode

From: kernel test robot <lkp@intel.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Julien Su <juliensu@mxic.com.tw>
Subject: Re: [PATCH 13/18] mtd: nand: mxic-ecc: Support SPI pipelined mode
Date: Thu, 21 Oct 2021 13:22:05 +0800	[thread overview]
Message-ID: <202110211322.GeQkngml-lkp@intel.com> (raw)
In-Reply-To: <20211020142809.349347-14-miquel.raynal@bootlin.com>

[-- Attachment #1: Type: text/plain, Size: 3238 bytes --]

Hi Miquel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on broonie-spi/for-next]
[also build test WARNING on mtd/nand/next mtd/mtd/next mtd/mtd/fixes v5.15-rc6 next-20211020]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Miquel-Raynal/External-ECC-engines-Macronix-support/20211020-223036
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: hexagon-randconfig-r014-20211021 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 3cea2505fd8d99a9ba0cb625aecfe28a47c4e3f8)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ccf53b4df2cab6209b1c56f22e1a1955f59b8ea0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Miquel-Raynal/External-ECC-engines-Macronix-support/20211020-223036
        git checkout ccf53b4df2cab6209b1c56f22e1a1955f59b8ea0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=hexagon 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/mtd/nand/ecc-mxic.c:480:5: warning: no previous prototype for function 'mxic_ecc_process_data' [-Wmissing-prototypes]
   int mxic_ecc_process_data(struct mxic_ecc_engine *eng, dma_addr_t dirmap)
       ^
   drivers/mtd/nand/ecc-mxic.c:480:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int mxic_ecc_process_data(struct mxic_ecc_engine *eng, dma_addr_t dirmap)
   ^
   static 
>> drivers/mtd/nand/ecc-mxic.c:742:29: warning: no previous prototype for function 'mxic_ecc_get_pipelined_ops' [-Wmissing-prototypes]
   struct nand_ecc_engine_ops *mxic_ecc_get_pipelined_ops(void)
                               ^
   drivers/mtd/nand/ecc-mxic.c:742:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct nand_ecc_engine_ops *mxic_ecc_get_pipelined_ops(void)
   ^
   static 
   2 warnings generated.

vim +/mxic_ecc_process_data +480 drivers/mtd/nand/ecc-mxic.c

   479	
 > 480	int mxic_ecc_process_data(struct mxic_ecc_engine *eng, dma_addr_t dirmap)
   481	{
   482		/* Retrieve the direction */
   483		unsigned int dir = (eng->req->type == NAND_PAGE_READ) ?
   484				   READ_NAND : WRITE_NAND;
   485	
   486		if (dirmap)
   487			writel(dirmap, eng->regs + HC_SLV_ADDR);
   488	
   489		/* Trigger processing */
   490		writel(SDMA_STRT | dir, eng->regs + SDMA_CTRL);
   491	
   492		/* Wait for completion */
   493		return mxic_ecc_data_xfer_wait_for_completion(eng);
   494	}
   495	EXPORT_SYMBOL_GPL(mxic_ecc_process_data);
   496	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29024 bytes --]

[-- Attachment #3: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/