All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Mark Brown <broonie@kernel.org>,
	linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Julien Su <juliensu@mxic.com.tw>,
	Jaime Liao <jaimeliao@mxic.com.tw>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Xiangsheng Hou <Xiangsheng.Hou@mediatek.com>
Subject: Re: [PATCH 09/18] dt-bindings: spi: mxic: Document the nand-ecc-engine property
Date: Thu, 28 Oct 2021 16:38:43 -0500	[thread overview]
Message-ID: <YXsYY6JaglRjan+L@robh.at.kernel.org> (raw)
In-Reply-To: <20211020142809.349347-10-miquel.raynal@bootlin.com>

On Wed, Oct 20, 2021 at 04:28:00PM +0200, Miquel Raynal wrote:
> This SPI controller supports interacting with an external ECC
> engine. The nand-ecc-engine property already exist in the NAND world but
> also applies to SPI controller nodes which have external correction
> capabilities like Macronix's.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  .../devicetree/bindings/spi/mxicy,mx25f0a-spi.yaml          | 6 ++++++
>  1 file changed, 6 insertions(+)

This should come before patch 8. The example would fail if 
'unevaluatedProperties' did anything.

Reviewed-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/spi/mxicy,mx25f0a-spi.yaml b/Documentation/devicetree/bindings/spi/mxicy,mx25f0a-spi.yaml
> index 4036c14fc533..01618a77627d 100644
> --- a/Documentation/devicetree/bindings/spi/mxicy,mx25f0a-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/mxicy,mx25f0a-spi.yaml
> @@ -43,6 +43,12 @@ properties:
>    "#size-cells":
>      const: 0
>  
> +  nand-ecc-engine:
> +    allOf:
> +      - $ref: /schemas/types.yaml#/definitions/phandle
> +    description: NAND ECC engine used by the SPI controller in order to perform
> +      on-the-fly correction when using a SPI-NAND memory.
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.27.0
> 
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Mark Brown <broonie@kernel.org>,
	linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Julien Su <juliensu@mxic.com.tw>,
	Jaime Liao <jaimeliao@mxic.com.tw>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Xiangsheng Hou <Xiangsheng.Hou@mediatek.com>
Subject: Re: [PATCH 09/18] dt-bindings: spi: mxic: Document the nand-ecc-engine property
Date: Thu, 28 Oct 2021 16:38:43 -0500	[thread overview]
Message-ID: <YXsYY6JaglRjan+L@robh.at.kernel.org> (raw)
In-Reply-To: <20211020142809.349347-10-miquel.raynal@bootlin.com>

On Wed, Oct 20, 2021 at 04:28:00PM +0200, Miquel Raynal wrote:
> This SPI controller supports interacting with an external ECC
> engine. The nand-ecc-engine property already exist in the NAND world but
> also applies to SPI controller nodes which have external correction
> capabilities like Macronix's.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  .../devicetree/bindings/spi/mxicy,mx25f0a-spi.yaml          | 6 ++++++
>  1 file changed, 6 insertions(+)

This should come before patch 8. The example would fail if 
'unevaluatedProperties' did anything.

Reviewed-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/spi/mxicy,mx25f0a-spi.yaml b/Documentation/devicetree/bindings/spi/mxicy,mx25f0a-spi.yaml
> index 4036c14fc533..01618a77627d 100644
> --- a/Documentation/devicetree/bindings/spi/mxicy,mx25f0a-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/mxicy,mx25f0a-spi.yaml
> @@ -43,6 +43,12 @@ properties:
>    "#size-cells":
>      const: 0
>  
> +  nand-ecc-engine:
> +    allOf:
> +      - $ref: /schemas/types.yaml#/definitions/phandle
> +    description: NAND ECC engine used by the SPI controller in order to perform
> +      on-the-fly correction when using a SPI-NAND memory.
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.27.0
> 
> 

  reply	other threads:[~2021-10-28 21:39 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 14:27 [PATCH 00/18] External ECC engines & Macronix support Miquel Raynal
2021-10-20 14:27 ` Miquel Raynal
2021-10-20 14:27 ` [PATCH 01/18] dt-bindings: mtd: nand-controller: Fix the reg property description Miquel Raynal
2021-10-20 14:27   ` Miquel Raynal
2021-10-28 21:25   ` Rob Herring
2021-10-28 21:25     ` Rob Herring
2021-10-20 14:27 ` [PATCH 02/18] dt-bindings: mtd: nand-controller: Fix a comment in the examples Miquel Raynal
2021-10-20 14:27   ` Miquel Raynal
2021-10-28 21:26   ` Rob Herring
2021-10-28 21:26     ` Rob Herring
2021-10-20 14:27 ` [PATCH 03/18] dt-bindings: mtd: nand-chip: Create a NAND chip description Miquel Raynal
2021-10-20 14:27   ` Miquel Raynal
2021-10-20 21:14   ` Rob Herring
2021-10-20 21:14     ` Rob Herring
2021-10-22 22:47   ` Rob Herring
2021-10-22 22:47     ` Rob Herring
2021-10-20 14:27 ` [PATCH 04/18] dt-bindings: mtd: spi-nand: Convert spi-nand description file to yaml Miquel Raynal
2021-10-20 14:27   ` Miquel Raynal
2021-10-20 21:14   ` Rob Herring
2021-10-20 21:14     ` Rob Herring
2021-10-21 14:09     ` Miquel Raynal
2021-10-21 14:09       ` Miquel Raynal
2021-10-22 22:36       ` Rob Herring
2021-10-22 22:36         ` Rob Herring
2021-11-24 13:54         ` Miquel Raynal
2021-11-24 13:54           ` Miquel Raynal
2021-10-28 21:28   ` Rob Herring
2021-10-28 21:28     ` Rob Herring
2021-10-20 14:27 ` [PATCH 05/18] dt-bindings: vendor-prefixes: Clarify Macronix prefix Miquel Raynal
2021-10-20 14:27   ` Miquel Raynal
2021-10-28 21:31   ` Rob Herring
2021-10-28 21:31     ` Rob Herring
2021-10-20 14:27 ` [PATCH 06/18] dt-bindings: spi: mxic: The interrupt property is not mandatory Miquel Raynal
2021-10-20 14:27   ` Miquel Raynal
2021-10-28 21:32   ` Rob Herring
2021-10-28 21:32     ` Rob Herring
2021-10-20 14:27 ` [PATCH 07/18] dt-bindings: spi: mxic: Convert to yaml Miquel Raynal
2021-10-20 14:27   ` Miquel Raynal
2021-10-28 21:34   ` Rob Herring
2021-10-28 21:34     ` Rob Herring
2021-10-20 14:27 ` [PATCH 08/18] dt-bindings: mtd: Describe Macronix NAND ECC engine Miquel Raynal
2021-10-20 14:27   ` Miquel Raynal
2021-10-28 21:35   ` Rob Herring
2021-10-28 21:35     ` Rob Herring
2021-10-20 14:28 ` [PATCH 09/18] dt-bindings: spi: mxic: Document the nand-ecc-engine property Miquel Raynal
2021-10-20 14:28   ` Miquel Raynal
2021-10-28 21:38   ` Rob Herring [this message]
2021-10-28 21:38     ` Rob Herring
2021-10-20 14:28 ` [PATCH 10/18] mtd: spinand: macronix: Use random program load Miquel Raynal
2021-10-20 14:28   ` Miquel Raynal
2021-10-20 14:28 ` [PATCH 11/18] mtd: nand: ecc: Add infrastructure to support hardware engines Miquel Raynal
2021-10-20 14:28   ` Miquel Raynal
2021-10-20 14:28 ` [PATCH 12/18] mtd: nand: mxic-ecc: Add Macronix external ECC engine support Miquel Raynal
2021-10-20 14:28   ` Miquel Raynal
2021-10-20 14:28 ` [PATCH 13/18] mtd: nand: mxic-ecc: Support SPI pipelined mode Miquel Raynal
2021-10-20 14:28   ` Miquel Raynal
2021-10-21  5:22   ` kernel test robot
2021-10-21  5:22     ` kernel test robot
2021-10-21  5:22     ` kernel test robot
2021-10-20 14:28 ` [PATCH 14/18] spi: mxic: Fix the transmit path Miquel Raynal
2021-10-20 14:28   ` Miquel Raynal
2021-10-20 14:28 ` [PATCH 15/18] spi: mxic: Create a helper to configure the controller before an operation Miquel Raynal
2021-10-20 14:28   ` Miquel Raynal
2021-10-20 14:28 ` [PATCH 16/18] spi: mxic: Create a helper to ease the start of " Miquel Raynal
2021-10-20 14:28   ` Miquel Raynal
2021-10-20 14:28 ` [PATCH 17/18] spi: mxic: Add support for direct mapping Miquel Raynal
2021-10-20 14:28   ` Miquel Raynal
2021-10-20 14:28 ` [PATCH 18/18] spi: mxic: Add support for pipelined ECC operations Miquel Raynal
2021-10-20 14:28   ` Miquel Raynal
2021-10-20 19:39   ` kernel test robot
2021-10-20 19:39     ` kernel test robot
2021-10-20 19:39     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXsYY6JaglRjan+L@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=Xiangsheng.Hou@mediatek.com \
    --cc=boris.brezillon@collabora.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jaimeliao@mxic.com.tw \
    --cc=juliensu@mxic.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.