Re: [PATCH] MIPS: rb532: move GPIOD definition into C-files

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Wed, Mar 30, 2022 at 12:23:59PM +0300, Andy Shevchenko wrote:
> On Wed, Mar 30, 2022 at 9:45 AM Thomas Bogendoerfer
> <tsbogend@alpha.franken.de> wrote:
> > On Wed, Mar 30, 2022 at 09:46:07AM +0800, Jackie Liu wrote:
> > > 在 2022/3/29 下午8:54, Andy Shevchenko 写道:
> 
> ...
> 
> > > I think it would be better to put it in gpio.c, after all it belongs to
> > > the GPIO module and is not used elsewhere. It doesn't feel good if we
> > > put it in the header file.
> >
> > I have a patchset, where the both files will go away. No need to
> > clean up now.
> 
> Do you plan them to be backported? If not, I would recommend applying

no plan for backporting

> this patch in order to have it backported and then do whatever you
> want we those files.

why ? This doesn't fix anything, doesn't it ?

But if it makes people happy, I'll apply it.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]