From: Jackie Liu <liu.yun@linux.dev>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Ralf Baechle <ralf@linux-mips.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] MIPS: rb532: move GPIOD definition into C-files
Date: Wed, 30 Mar 2022 17:56:03 +0800 [thread overview]
Message-ID: <f601dcf3-892c-e8de-9028-9e5108322074@linux.dev> (raw)
In-Reply-To: <CAHp75Vc+Gvte62Smnyi_RN=c0Fpy6LLyqJV2Oy0HP+Yv6CvtxQ@mail.gmail.com>
在 2022/3/30 下午5:41, Andy Shevchenko 写道:
> On Wed, Mar 30, 2022 at 12:32 PM Thomas Bogendoerfer
> <tsbogend@alpha.franken.de> wrote:
>> On Wed, Mar 30, 2022 at 12:23:59PM +0300, Andy Shevchenko wrote:
>>> On Wed, Mar 30, 2022 at 9:45 AM Thomas Bogendoerfer
>>> <tsbogend@alpha.franken.de> wrote:
>>>> On Wed, Mar 30, 2022 at 09:46:07AM +0800, Jackie Liu wrote:
>
> ...
>
>>>> I have a patchset, where the both files will go away. No need to
>>>> clean up now.
>>>
>>> Do you plan them to be backported? If not, I would recommend applying
>>
>> no plan for backporting
>>
>>> this patch in order to have it backported and then do whatever you
>>> want we those files.
>>
>> why ? This doesn't fix anything, doesn't it ?
Like the patch I submitted in the first version, there are some gcc
errors.
[...]
drivers/iio/adc/da9150-gpadc.c:254:13: error: ‘DA9150_GPADC_CHAN_0x08’
undeclared here (not in a function); did you mean ‘DA9150_GPADC_CHAN_TBAT’?
254 | .channel = DA9150_GPADC_CHAN_##_id, \
| ^~~~~~~~~~~~~~~~~~
drivers/iio/adc/da9150-gpadc.c:273:2: note: in expansion of macro
‘DA9150_GPADC_CHANNEL’
273 | DA9150_GPADC_CHANNEL(_id, _hw_id, _type, \
| ^~~~~~~~~~~~~~~~~~~~
drivers/iio/adc/da9150-gpadc.c:281:2: note: in expansion of macro
‘DA9150_GPADC_CHANNEL_PROCESSED’
281 | DA9150_GPADC_CHANNEL_PROCESSED(GPIOD, GPIOD_6V, IIO_VOLTAGE,
NULL),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[4]: *** [../scripts/Makefile.build:288:
drivers/iio/adc/da9150-gpadc.o] Error 1
make[3]: *** [../scripts/Makefile.build:550: drivers/iio/adc] Error 2
make[3]: *** Waiting for unfinished jobs....
>
> It fixes compilation breakage in some cases. I think the author of
> this patch can (should) elaborate.
> Also, it might need a Fixes tag.
Um, it's really hard to say which commit is fixed, just because this
header file defines a GPIOD, and someone else uses this later.
>
>> But if it makes people happy, I'll apply it.
>
> Yes, please.
>
--
Jackie Liu
next prev parent reply other threads:[~2022-03-30 9:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 1:45 [PATCH] MIPS: rb532: move GPIOD definition into C-files Jackie Liu
2022-03-29 12:54 ` Andy Shevchenko
2022-03-30 1:46 ` Jackie Liu
2022-03-30 6:42 ` Thomas Bogendoerfer
2022-03-30 9:23 ` Andy Shevchenko
2022-03-30 9:32 ` Thomas Bogendoerfer
2022-03-30 9:41 ` Andy Shevchenko
2022-03-30 9:56 ` Jackie Liu [this message]
2022-03-30 10:01 ` Andy Shevchenko
2022-03-30 10:04 ` Jackie Liu
2022-03-30 10:02 ` Thomas Bogendoerfer
2022-03-30 2:01 ` [PATCH v2] " Jackie Liu
2022-03-30 2:07 ` [PATCH v3] " Jackie Liu
2022-03-30 8:52 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f601dcf3-892c-e8de-9028-9e5108322074@linux.dev \
--to=liu.yun@linux.dev \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mips@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.