From: Jackie Liu <liu.yun@linux.dev>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Linus Walleij <linus.walleij@linaro.org>,
Ralf Baechle <ralf@linux-mips.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] MIPS: rb532: move GPIOD definition into C-files
Date: Wed, 30 Mar 2022 18:04:55 +0800 [thread overview]
Message-ID: <bb90ecd2-a750-574c-1b1c-6e06461c002a@linux.dev> (raw)
In-Reply-To: <CAHp75VdWBMQWtgL1ejk-2C2v4sfm48RzyJd-Z3hMcSvi=Tm4pg@mail.gmail.com>
在 2022/3/30 下午6:01, Andy Shevchenko 写道:
> On Wed, Mar 30, 2022 at 12:56 PM Jackie Liu <liu.yun@linux.dev> wrote:
>> 在 2022/3/30 下午5:41, Andy Shevchenko 写道:
>>> On Wed, Mar 30, 2022 at 12:32 PM Thomas Bogendoerfer
>>> <tsbogend@alpha.franken.de> wrote:
>
> ...
>
>>> It fixes compilation breakage in some cases. I think the author of
>>> this patch can (should) elaborate.
>>> Also, it might need a Fixes tag.
>>
>> Um, it's really hard to say which commit is fixed, just because this
>> header file defines a GPIOD, and someone else uses this later.
>
> I think we may use the original commit where the header in mips
> appeared with a justification that the definitions are not needed to
> be there and it may induce build errors, which in fact happens.
>
Sure, Thanks, I will send new patch v3 later.
--
BR, Jackie Liu
next prev parent reply other threads:[~2022-03-30 10:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 1:45 [PATCH] MIPS: rb532: move GPIOD definition into C-files Jackie Liu
2022-03-29 12:54 ` Andy Shevchenko
2022-03-30 1:46 ` Jackie Liu
2022-03-30 6:42 ` Thomas Bogendoerfer
2022-03-30 9:23 ` Andy Shevchenko
2022-03-30 9:32 ` Thomas Bogendoerfer
2022-03-30 9:41 ` Andy Shevchenko
2022-03-30 9:56 ` Jackie Liu
2022-03-30 10:01 ` Andy Shevchenko
2022-03-30 10:04 ` Jackie Liu [this message]
2022-03-30 10:02 ` Thomas Bogendoerfer
2022-03-30 2:01 ` [PATCH v2] " Jackie Liu
2022-03-30 2:07 ` [PATCH v3] " Jackie Liu
2022-03-30 8:52 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb90ecd2-a750-574c-1b1c-6e06461c002a@linux.dev \
--to=liu.yun@linux.dev \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mips@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.