All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] Makefile: error out printvars target when VARS is empty or unset
@ 2022-08-02 12:35 Quentin Schulz
  2022-08-03 17:07 ` Yann E. MORIN
  2022-09-14  9:29 ` Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Quentin Schulz @ 2022-08-02 12:35 UTC (permalink / raw)
  To: buildroot; +Cc: Quentin Schulz, Quentin Schulz, yann.morin.1998

From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

printvars returns nothing when VARS is not passed or empty. This is done
on purpose, see commit fd5bd12379dc ("Makefile: printvars: don't print
anything when VARS is not set").

An error message making explicit what is required from the user in order
to use printvars is however better than silently doing nothing.

This adds a check for a non-empty VARS variable.

Cc: Quentin Schulz <foss+buildroot@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
 Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Makefile b/Makefile
index a743e42f91..3cbcfa9196 100644
--- a/Makefile
+++ b/Makefile
@@ -1058,6 +1058,10 @@ endif
 # to workaround a bug in make 4.3; see https://savannah.gnu.org/bugs/?59093
 .PHONY: printvars
 printvars:
+ifndef VARS
+	@echo "Please pass a non-empty VARS to 'make printvars'"
+	@exit 1
+endif
 	@:
 	$(foreach V, \
 		$(sort $(foreach X, $(.VARIABLES), $(filter $(VARS),$(X)))), \
-- 
2.37.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 0/5] add support for libedit and linenoise CLI implementations for nftables
@ 2022-09-12  9:55 Quentin Schulz
  2022-09-12  9:55 ` [Buildroot] [PATCH] Makefile: error out printvars target when VARS is empty or unset Quentin Schulz
  0 siblings, 1 reply; 4+ messages in thread
From: Quentin Schulz @ 2022-09-12  9:55 UTC (permalink / raw)
  To: buildroot; +Cc: Quentin Schulz

From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

nftables supports three different cli implementations at the moment:
libedit, readline and linenoise. When --without_cli and --with_cli are
omitted, libedit is the default implementation if the lib is found by
the configure script. To select readline or linenoise implementation the
appropriate --with_cli option should be given.

linenoise 1.0 is unfortunately incompatible with linenoise CLI
implementation and requires to be bumped.

libedit implementation suffers from a missing header in v1.0.1 and
earlier which is fixed by bumping nftables to its latest version, 1.0.5.

nftables 1.0.5 requires libnftnl 1.2.3 or later so the latter is also
bumped to its latest version.

This has only been build tested, the nft binary is created properly.

Cheers,
Quentin

Quentin Schulz (5):
  package/linenoise: bump linenoise to latest commit
  package/nftables: support linenoise cli backend support
  package/libnftnl: bump to version 1.2.3
  package/nftables: bump to version 1.0.5
  package/nftables: support libedit cli implementation

 package/libnftnl/libnftnl.hash   |  2 +-
 package/libnftnl/libnftnl.mk     |  2 +-
 package/linenoise/linenoise.hash |  2 +-
 package/linenoise/linenoise.mk   |  2 +-
 package/nftables/nftables.hash   |  2 +-
 package/nftables/nftables.mk     | 11 +++++++++--
 6 files changed, 14 insertions(+), 7 deletions(-)

-- 
2.37.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-14  9:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-02 12:35 [Buildroot] [PATCH] Makefile: error out printvars target when VARS is empty or unset Quentin Schulz
2022-08-03 17:07 ` Yann E. MORIN
2022-09-14  9:29 ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2022-09-12  9:55 [Buildroot] [PATCH 0/5] add support for libedit and linenoise CLI implementations for nftables Quentin Schulz
2022-09-12  9:55 ` [Buildroot] [PATCH] Makefile: error out printvars target when VARS is empty or unset Quentin Schulz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.