All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/8] riscv: move riscv_noncoherent_supported() out of ZICBOM probe
Date: Thu,  6 Oct 2022 15:08:11 +0800	[thread overview]
Message-ID: <20221006070818.3616-2-jszhang@kernel.org> (raw)
In-Reply-To: <20221006070818.3616-1-jszhang@kernel.org>

It's a bit wired to call riscv_noncoherent_supported() once when
insmod a module. Move the calling out of feature patch func.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
 arch/riscv/kernel/cpufeature.c | 7 +------
 arch/riscv/kernel/setup.c      | 4 ++++
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
index 3b5583db9d80..03611b3ef45e 100644
--- a/arch/riscv/kernel/cpufeature.c
+++ b/arch/riscv/kernel/cpufeature.c
@@ -272,12 +272,7 @@ static bool __init_or_module cpufeature_probe_zicbom(unsigned int stage)
 	case RISCV_ALTERNATIVES_EARLY_BOOT:
 		return false;
 	default:
-		if (riscv_isa_extension_available(NULL, ZICBOM)) {
-			riscv_noncoherent_supported();
-			return true;
-		} else {
-			return false;
-		}
+		return riscv_isa_extension_available(NULL, ZICBOM);
 	}
 #endif
 
diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
index 2dfc463b86bb..1a055c3f5d9d 100644
--- a/arch/riscv/kernel/setup.c
+++ b/arch/riscv/kernel/setup.c
@@ -299,6 +299,10 @@ void __init setup_arch(char **cmdline_p)
 	riscv_init_cbom_blocksize();
 	riscv_fill_hwcap();
 	apply_boot_alternatives();
+#ifdef CONFIG_RISCV_DMA_NONCOHERENT
+	if (riscv_isa_extension_available(NULL, ZICBOM))
+		riscv_noncoherent_supported();
+#endif
 }
 
 static int __init topology_init(void)
-- 
2.37.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@kernel.org>
To: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/8] riscv: move riscv_noncoherent_supported() out of ZICBOM probe
Date: Thu,  6 Oct 2022 15:08:11 +0800	[thread overview]
Message-ID: <20221006070818.3616-2-jszhang@kernel.org> (raw)
In-Reply-To: <20221006070818.3616-1-jszhang@kernel.org>

It's a bit wired to call riscv_noncoherent_supported() once when
insmod a module. Move the calling out of feature patch func.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
 arch/riscv/kernel/cpufeature.c | 7 +------
 arch/riscv/kernel/setup.c      | 4 ++++
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
index 3b5583db9d80..03611b3ef45e 100644
--- a/arch/riscv/kernel/cpufeature.c
+++ b/arch/riscv/kernel/cpufeature.c
@@ -272,12 +272,7 @@ static bool __init_or_module cpufeature_probe_zicbom(unsigned int stage)
 	case RISCV_ALTERNATIVES_EARLY_BOOT:
 		return false;
 	default:
-		if (riscv_isa_extension_available(NULL, ZICBOM)) {
-			riscv_noncoherent_supported();
-			return true;
-		} else {
-			return false;
-		}
+		return riscv_isa_extension_available(NULL, ZICBOM);
 	}
 #endif
 
diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
index 2dfc463b86bb..1a055c3f5d9d 100644
--- a/arch/riscv/kernel/setup.c
+++ b/arch/riscv/kernel/setup.c
@@ -299,6 +299,10 @@ void __init setup_arch(char **cmdline_p)
 	riscv_init_cbom_blocksize();
 	riscv_fill_hwcap();
 	apply_boot_alternatives();
+#ifdef CONFIG_RISCV_DMA_NONCOHERENT
+	if (riscv_isa_extension_available(NULL, ZICBOM))
+		riscv_noncoherent_supported();
+#endif
 }
 
 static int __init topology_init(void)
-- 
2.37.2


  reply	other threads:[~2022-10-06  7:18 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06  7:08 [PATCH 0/8] riscv: improve boot time isa extensions handling Jisheng Zhang
2022-10-06  7:08 ` Jisheng Zhang
2022-10-06  7:08 ` Jisheng Zhang [this message]
2022-10-06  7:08   ` [PATCH 1/8] riscv: move riscv_noncoherent_supported() out of ZICBOM probe Jisheng Zhang
2022-10-06 13:10   ` Andrew Jones
2022-10-06 13:10     ` Andrew Jones
2022-10-06 17:44     ` Andrew Jones
2022-10-06 17:44       ` Andrew Jones
2022-10-07  9:18   ` Heiko Stübner
2022-10-07  9:18     ` Heiko Stübner
2022-10-08 13:06   ` Conor Dooley
2022-10-08 13:06     ` Conor Dooley
2022-10-08 13:59     ` Jisheng Zhang
2022-10-08 13:59       ` Jisheng Zhang
2022-10-13  5:37       ` Conor Dooley
2022-10-13  5:37         ` Conor Dooley
2022-10-06  7:08 ` [PATCH 2/8] riscv: cpufeature: detect RISCV_ALTERNATIVES_EARLY_BOOT earlier Jisheng Zhang
2022-10-06  7:08   ` Jisheng Zhang
2022-10-06 13:12   ` Andrew Jones
2022-10-06 13:12     ` Andrew Jones
2022-10-07  9:38   ` Heiko Stübner
2022-10-07  9:38     ` Heiko Stübner
2022-10-06  7:08 ` [PATCH 3/8] riscv: hwcap: make ISA extension ids can be used in asm Jisheng Zhang
2022-10-06  7:08   ` Jisheng Zhang
2022-10-06 13:15   ` Andrew Jones
2022-10-06 13:15     ` Andrew Jones
2022-10-07  9:22   ` Heiko Stübner
2022-10-07  9:22     ` Heiko Stübner
2022-10-06  7:08 ` [PATCH 4/8] riscv: cpufeature: extend riscv_cpufeature_patch_func to all ISA extensions Jisheng Zhang
2022-10-06  7:08   ` Jisheng Zhang
2022-10-06 13:31   ` Andrew Jones
2022-10-06 13:31     ` Andrew Jones
2022-10-07 11:54   ` Heiko Stübner
2022-10-07 11:54     ` Heiko Stübner
2022-10-13 13:28     ` Heiko Stuebner
2022-10-13 13:28       ` Heiko Stuebner
2022-10-06  7:08 ` [PATCH 5/8] riscv: introduce riscv_has_extension_[un]likely() Jisheng Zhang
2022-10-06  7:08   ` Jisheng Zhang
2022-10-06 13:36   ` Andrew Jones
2022-10-06 13:36     ` Andrew Jones
2022-10-06  7:08 ` [PATCH 6/8] riscv: fpu: switch has_fpu() to riscv_has_extension_likely() Jisheng Zhang
2022-10-06  7:08   ` Jisheng Zhang
2022-10-06 13:36   ` Andrew Jones
2022-10-06 13:36     ` Andrew Jones
2022-10-07 15:11   ` Heiko Stübner
2022-10-07 15:11     ` Heiko Stübner
2022-10-06  7:08 ` [PATCH 7/8] riscv: cpu_relax: switch " Jisheng Zhang
2022-10-06  7:08   ` Jisheng Zhang
2022-10-06 13:28   ` kernel test robot
2022-10-06 13:28     ` kernel test robot
2022-10-06 13:37   ` Andrew Jones
2022-10-06 13:37     ` Andrew Jones
2022-10-07 15:12   ` Heiko Stübner
2022-10-07 15:12     ` Heiko Stübner
2022-10-07 18:14   ` kernel test robot
2022-10-07 18:14     ` kernel test robot
2022-10-06  7:08 ` [PATCH 8/8] riscv: remove riscv_isa_ext_keys[] array and related usage Jisheng Zhang
2022-10-06  7:08   ` Jisheng Zhang
2022-10-06 13:38   ` Andrew Jones
2022-10-06 13:38     ` Andrew Jones
2022-10-07 15:12   ` Heiko Stübner
2022-10-07 15:12     ` Heiko Stübner
2022-10-13 16:20 ` [PATCH 0/8] riscv: improve boot time isa extensions handling Andrew Jones
2022-10-13 16:20   ` Andrew Jones
2022-10-29  9:56 ` Andrew Jones
2022-10-29  9:56   ` Andrew Jones
2022-10-29 11:38   ` Jisheng Zhang
2022-10-29 11:38     ` Jisheng Zhang
2022-10-30 16:03   ` Jisheng Zhang
2022-10-30 16:03     ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221006070818.3616-2-jszhang@kernel.org \
    --to=jszhang@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.