* [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec
@ 2022-11-22 8:12 ` Frieder Schrempf
0 siblings, 0 replies; 8+ messages in thread
From: Frieder Schrempf @ 2022-11-22 8:12 UTC (permalink / raw)
To: Andrzej Hajda, Daniel Vetter, David Airlie, dri-devel,
Frieder Schrempf, Linus Walleij, linux-kernel, Marek Vasut,
Neil Armstrong, Robert Foss
Cc: Jonas Karlman, Alexander Stein, Jernej Skrabec,
Christophe JAILLET, Laurent Pinchart, José Expósito,
Sam Ravnborg
From: Frieder Schrempf <frieder.schrempf@kontron.de>
The datasheet specifies a delay of 10 milliseconds, but the current
driver only waits for 1 ms. Fix this to make sure the initialization
sequence meets the spec.
Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver")
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index 7ba9467fff12..047c14ddbbf1 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge *bridge,
/* Deassert reset */
gpiod_set_value_cansleep(ctx->enable_gpio, 1);
- usleep_range(1000, 1100);
+ usleep_range(10000, 11000);
/* Get the LVDS format from the bridge state. */
bridge_state = drm_atomic_get_new_bridge_state(state, bridge);
--
2.38.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec
@ 2022-11-22 8:12 ` Frieder Schrempf
0 siblings, 0 replies; 8+ messages in thread
From: Frieder Schrempf @ 2022-11-22 8:12 UTC (permalink / raw)
To: Andrzej Hajda, Daniel Vetter, David Airlie, dri-devel,
Frieder Schrempf, Linus Walleij, linux-kernel, Marek Vasut,
Neil Armstrong, Robert Foss
Cc: Alexander Stein, Christophe JAILLET, Jernej Skrabec,
Jonas Karlman, José Expósito, Laurent Pinchart,
Sam Ravnborg, Ville Syrjälä
From: Frieder Schrempf <frieder.schrempf@kontron.de>
The datasheet specifies a delay of 10 milliseconds, but the current
driver only waits for 1 ms. Fix this to make sure the initialization
sequence meets the spec.
Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver")
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index 7ba9467fff12..047c14ddbbf1 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge *bridge,
/* Deassert reset */
gpiod_set_value_cansleep(ctx->enable_gpio, 1);
- usleep_range(1000, 1100);
+ usleep_range(10000, 11000);
/* Get the LVDS format from the bridge state. */
bridge_state = drm_atomic_get_new_bridge_state(state, bridge);
--
2.38.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec
2022-11-22 8:12 ` Frieder Schrempf
@ 2022-11-24 11:00 ` Alexander Stein
-1 siblings, 0 replies; 8+ messages in thread
From: Alexander Stein @ 2022-11-24 11:00 UTC (permalink / raw)
To: Andrzej Hajda, Daniel Vetter, David Airlie, dri-devel,
Frieder Schrempf, Linus Walleij, linux-kernel, Marek Vasut,
Neil Armstrong, Robert Foss, Frieder Schrempf
Cc: Jonas Karlman, Jernej Skrabec, Christophe JAILLET,
Laurent Pinchart, José Expósito, Sam Ravnborg
Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> The datasheet specifies a delay of 10 milliseconds, but the current
> driver only waits for 1 ms. Fix this to make sure the initialization
> sequence meets the spec.
>
> Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and
> SN65DSI84 driver") Signed-off-by: Frieder Schrempf
> <frieder.schrempf@kontron.de>
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1
> 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> @@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge
> *bridge,
>
> /* Deassert reset */
> gpiod_set_value_cansleep(ctx->enable_gpio, 1);
> - usleep_range(1000, 1100);
> + usleep_range(10000, 11000);
>
> /* Get the LVDS format from the bridge state. */
> bridge_state = drm_atomic_get_new_bridge_state(state, bridge);
How about using fsleep?
Either way:
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec
@ 2022-11-24 11:00 ` Alexander Stein
0 siblings, 0 replies; 8+ messages in thread
From: Alexander Stein @ 2022-11-24 11:00 UTC (permalink / raw)
To: Andrzej Hajda, Daniel Vetter, David Airlie, dri-devel,
Frieder Schrempf, Linus Walleij, linux-kernel, Marek Vasut,
Neil Armstrong, Robert Foss, Frieder Schrempf
Cc: Christophe JAILLET, Jernej Skrabec, Jonas Karlman,
José Expósito, Laurent Pinchart, Sam Ravnborg,
Ville Syrjälä
Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> The datasheet specifies a delay of 10 milliseconds, but the current
> driver only waits for 1 ms. Fix this to make sure the initialization
> sequence meets the spec.
>
> Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and
> SN65DSI84 driver") Signed-off-by: Frieder Schrempf
> <frieder.schrempf@kontron.de>
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1
> 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> @@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge
> *bridge,
>
> /* Deassert reset */
> gpiod_set_value_cansleep(ctx->enable_gpio, 1);
> - usleep_range(1000, 1100);
> + usleep_range(10000, 11000);
>
> /* Get the LVDS format from the bridge state. */
> bridge_state = drm_atomic_get_new_bridge_state(state, bridge);
How about using fsleep?
Either way:
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec
2022-11-24 11:00 ` Alexander Stein
@ 2022-11-24 11:07 ` Frieder Schrempf
-1 siblings, 0 replies; 8+ messages in thread
From: Frieder Schrempf @ 2022-11-24 11:07 UTC (permalink / raw)
To: Alexander Stein, Andrzej Hajda, Daniel Vetter, David Airlie,
dri-devel, Linus Walleij, linux-kernel, Marek Vasut,
Neil Armstrong, Robert Foss, Frieder Schrempf
Cc: Jonas Karlman, Jernej Skrabec, Christophe JAILLET,
Laurent Pinchart, José Expósito, Sam Ravnborg
On 24.11.22 12:00, Alexander Stein wrote:
> Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> The datasheet specifies a delay of 10 milliseconds, but the current
>> driver only waits for 1 ms. Fix this to make sure the initialization
>> sequence meets the spec.
>>
>> Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and
>> SN65DSI84 driver") Signed-off-by: Frieder Schrempf
>> <frieder.schrempf@kontron.de>
>> ---
>> drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
>> b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1
>> 100644
>> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
>> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
>> @@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge
>> *bridge,
>>
>> /* Deassert reset */
>> gpiod_set_value_cansleep(ctx->enable_gpio, 1);
>> - usleep_range(1000, 1100);
>> + usleep_range(10000, 11000);
>>
>> /* Get the LVDS format from the bridge state. */
>> bridge_state = drm_atomic_get_new_bridge_state(state, bridge);
>
> How about using fsleep?
>
> Either way:
> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Thanks for the review! I didn't know about fsleep. Anyway this would
probably be a separate change as the driver currently uses usleep
everywhere else. But I will keep it in mind for the future.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec
@ 2022-11-24 11:07 ` Frieder Schrempf
0 siblings, 0 replies; 8+ messages in thread
From: Frieder Schrempf @ 2022-11-24 11:07 UTC (permalink / raw)
To: Alexander Stein, Andrzej Hajda, Daniel Vetter, David Airlie,
dri-devel, Linus Walleij, linux-kernel, Marek Vasut,
Neil Armstrong, Robert Foss, Frieder Schrempf
Cc: Christophe JAILLET, Jernej Skrabec, Jonas Karlman,
José Expósito, Laurent Pinchart, Sam Ravnborg,
Ville Syrjälä
On 24.11.22 12:00, Alexander Stein wrote:
> Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> The datasheet specifies a delay of 10 milliseconds, but the current
>> driver only waits for 1 ms. Fix this to make sure the initialization
>> sequence meets the spec.
>>
>> Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and
>> SN65DSI84 driver") Signed-off-by: Frieder Schrempf
>> <frieder.schrempf@kontron.de>
>> ---
>> drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
>> b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1
>> 100644
>> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
>> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
>> @@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge
>> *bridge,
>>
>> /* Deassert reset */
>> gpiod_set_value_cansleep(ctx->enable_gpio, 1);
>> - usleep_range(1000, 1100);
>> + usleep_range(10000, 11000);
>>
>> /* Get the LVDS format from the bridge state. */
>> bridge_state = drm_atomic_get_new_bridge_state(state, bridge);
>
> How about using fsleep?
>
> Either way:
> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Thanks for the review! I didn't know about fsleep. Anyway this would
probably be a separate change as the driver currently uses usleep
everywhere else. But I will keep it in mind for the future.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec
2022-11-24 11:07 ` Frieder Schrempf
@ 2022-11-24 12:16 ` Robert Foss
-1 siblings, 0 replies; 8+ messages in thread
From: Robert Foss @ 2022-11-24 12:16 UTC (permalink / raw)
To: Frieder Schrempf
Cc: Marek Vasut, Neil Armstrong, Andrzej Hajda, Frieder Schrempf,
Alexander Stein, Sam Ravnborg, Jonas Karlman, linux-kernel,
dri-devel, Christophe JAILLET, Jernej Skrabec,
José Expósito, Laurent Pinchart
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec
@ 2022-11-24 12:16 ` Robert Foss
0 siblings, 0 replies; 8+ messages in thread
From: Robert Foss @ 2022-11-24 12:16 UTC (permalink / raw)
To: Frieder Schrempf
Cc: Alexander Stein, Andrzej Hajda, Daniel Vetter, David Airlie,
dri-devel, Linus Walleij, linux-kernel, Marek Vasut,
Neil Armstrong, Frieder Schrempf, Christophe JAILLET,
Jernej Skrabec, Jonas Karlman, José Expósito,
Laurent Pinchart, Sam Ravnborg, Ville Syrjälä
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-24 12:16 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-22 8:12 [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec Frieder Schrempf
2022-11-22 8:12 ` Frieder Schrempf
2022-11-24 11:00 ` Alexander Stein
2022-11-24 11:00 ` Alexander Stein
2022-11-24 11:07 ` Frieder Schrempf
2022-11-24 11:07 ` Frieder Schrempf
2022-11-24 12:16 ` Robert Foss
2022-11-24 12:16 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.