* [Buildroot] [PATCH] packge/libabseil-cpp: bump to version 20230125.0
@ 2023-02-18 11:48 Michael Nosthoff via buildroot
2023-02-19 21:02 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 3+ messages in thread
From: Michael Nosthoff via buildroot @ 2023-02-18 11:48 UTC (permalink / raw)
To: buildroot; +Cc: Robert Rose
libabseil now depends on c++14 and gcc >= 7.3.1 [0][1]
[0] https://github.com/abseil/abseil-cpp/releases/tag/20230125.0
[1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
---
Note:
I'm not sure if the BR2_TOOLCHAIN_GCC_AT_LEAST_7 dependency is sufficient.
But I don't think we have a more version specific Flag available?
---
package/grpc/Config.in | 6 +++---
package/libabseil-cpp/Config.in | 6 +++---
package/libabseil-cpp/libabseil-cpp.hash | 2 +-
package/libabseil-cpp/libabseil-cpp.mk | 6 +++---
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/package/grpc/Config.in b/package/grpc/Config.in
index db6425819b..06436fe888 100644
--- a/package/grpc/Config.in
+++ b/package/grpc/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_GRPC
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf, re2
depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # protobuf
- depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # libabseil-cpp
depends on !BR2_STATIC_LIBS # protobuf, libabseil-cpp
depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC
depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
@@ -19,9 +19,9 @@ config BR2_PACKAGE_GRPC
http://github.com/grpc/grpc
-comment "grpc needs a toolchain w/ C++, threads, dynamic library, gcc >= 5"
+comment "grpc needs a toolchain w/ C++, threads, dynamic library, gcc >= 7"
depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \
- || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_5
+ || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_7
depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
diff --git a/package/libabseil-cpp/Config.in b/package/libabseil-cpp/Config.in
index 45f339ff26..d4139e8e04 100644
--- a/package/libabseil-cpp/Config.in
+++ b/package/libabseil-cpp/Config.in
@@ -18,7 +18,7 @@ config BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
config BR2_PACKAGE_LIBABSEIL_CPP
bool "libabseil-cpp"
depends on BR2_INSTALL_LIBSTDCPP
- depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on !BR2_STATIC_LIBS # uses dlfcn.h
depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
@@ -31,7 +31,7 @@ config BR2_PACKAGE_LIBABSEIL_CPP
https://github.com/abseil/abseil-cpp
-comment "libabseil-cpp needs a toolchain w/ gcc >= 4.9, C++, threads, dynamic library"
+comment "libabseil-cpp needs a toolchain w/ gcc >= 7.3.1, C++14, threads, dynamic library"
depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
- BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+ BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_7
diff --git a/package/libabseil-cpp/libabseil-cpp.hash b/package/libabseil-cpp/libabseil-cpp.hash
index 808bdbab29..81710f50fb 100644
--- a/package/libabseil-cpp/libabseil-cpp.hash
+++ b/package/libabseil-cpp/libabseil-cpp.hash
@@ -1,3 +1,3 @@
# Locally computed
-sha256 91ac87d30cc6d79f9ab974c51874a704de9c2647c40f6932597329a282217ba8 libabseil-cpp-20220623.1.tar.gz
+sha256 3ea49a7d97421b88a8c48a0de16c16048e17725c7ec0f1d3ea2683a2a75adc21 libabseil-cpp-20230125.0.tar.gz
sha256 c79a7fea0e3cac04cd43f20e7b648e5a0ff8fa5344e644b0ee09ca1162b62747 LICENSE
diff --git a/package/libabseil-cpp/libabseil-cpp.mk b/package/libabseil-cpp/libabseil-cpp.mk
index ceda106b7d..4e6ac2ee31 100644
--- a/package/libabseil-cpp/libabseil-cpp.mk
+++ b/package/libabseil-cpp/libabseil-cpp.mk
@@ -4,19 +4,19 @@
#
################################################################################
-LIBABSEIL_CPP_VERSION = 20220623.1
+LIBABSEIL_CPP_VERSION = 20230125.0
LIBABSEIL_CPP_SITE = $(call github,abseil,abseil-cpp,$(LIBABSEIL_CPP_VERSION))
LIBABSEIL_CPP_LICENSE = Apache-2.0
LIBABSEIL_CPP_LICENSE_FILES = LICENSE
LIBABSEIL_CPP_INSTALL_STAGING = YES
LIBABSEIL_CPP_CONF_OPTS = \
- -DCMAKE_CXX_STANDARD=11 \
+ -DCMAKE_CXX_STANDARD=14 \
-DABSL_ENABLE_INSTALL=ON \
-DABSL_USE_GOOGLETEST_HEAD=OFF
HOST_LIBABSEIL_CPP_CONF_OPTS = \
- -DCMAKE_CXX_STANDARD=11 \
+ -DCMAKE_CXX_STANDARD=14 \
-DABSL_ENABLE_INSTALL=ON \
-DABSL_USE_GOOGLETEST_HEAD=OFF
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] packge/libabseil-cpp: bump to version 20230125.0
2023-02-18 11:48 [Buildroot] [PATCH] packge/libabseil-cpp: bump to version 20230125.0 Michael Nosthoff via buildroot
@ 2023-02-19 21:02 ` Thomas Petazzoni via buildroot
2023-02-20 7:48 ` Michael Nosthoff via buildroot
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-19 21:02 UTC (permalink / raw)
To: Michael Nosthoff via buildroot; +Cc: Robert Rose
Hello Michael,
On Sat, 18 Feb 2023 12:48:37 +0100
Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:
> libabseil now depends on c++14 and gcc >= 7.3.1 [0][1]
>
> [0] https://github.com/abseil/abseil-cpp/releases/tag/20230125.0
> [1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
>
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> ---
>
> Note:
> I'm not sure if the BR2_TOOLCHAIN_GCC_AT_LEAST_7 dependency is sufficient.
> But I don't think we have a more version specific Flag available?
We don't have more specific blind options than 7.x, 8.x, etc. to
describe a gcc dependency.
> package/grpc/Config.in | 6 +++---
> package/libabseil-cpp/Config.in | 6 +++---
> package/libabseil-cpp/libabseil-cpp.hash | 2 +-
> package/libabseil-cpp/libabseil-cpp.mk | 6 +++---
> 4 files changed, 10 insertions(+), 10 deletions(-)
I'm afraid this is not sufficient. Indeed, you need to look at the
reverse dependencies of GRPC for example.
So, package/falcosecurity-libs needs to be adjusted, then
package/sysdig as well, and also the BR2_PACKAGE_COLLECTD_GRPC option
from package/collectd.
Could you have a look into this, and submit an updated version?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] packge/libabseil-cpp: bump to version 20230125.0
2023-02-19 21:02 ` Thomas Petazzoni via buildroot
@ 2023-02-20 7:48 ` Michael Nosthoff via buildroot
0 siblings, 0 replies; 3+ messages in thread
From: Michael Nosthoff via buildroot @ 2023-02-20 7:48 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Robert Rose, Michael Nosthoff via buildroot
Hi,
On Sunday, February 19, 2023 22:02 CET, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello Michael,
>
> On Sat, 18 Feb 2023 12:48:37 +0100
> Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:
>
> > libabseil now depends on c++14 and gcc >= 7.3.1 [0][1]
> >
> > [0] https://github.com/abseil/abseil-cpp/releases/tag/20230125.0
> > [1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
> >
> > Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> > ---
> >
> > Note:
> > I'm not sure if the BR2_TOOLCHAIN_GCC_AT_LEAST_7 dependency is sufficient.
> > But I don't think we have a more version specific Flag available?
>
> We don't have more specific blind options than 7.x, 8.x, etc. to
> describe a gcc dependency.
>
> > package/grpc/Config.in | 6 +++---
> > package/libabseil-cpp/Config.in | 6 +++---
> > package/libabseil-cpp/libabseil-cpp.hash | 2 +-
> > package/libabseil-cpp/libabseil-cpp.mk | 6 +++---
> > 4 files changed, 10 insertions(+), 10 deletions(-)
>
> I'm afraid this is not sufficient. Indeed, you need to look at the
> reverse dependencies of GRPC for example.
>
> So, package/falcosecurity-libs needs to be adjusted, then
> package/sysdig as well, and also the BR2_PACKAGE_COLLECTD_GRPC option
> from package/collectd.
>
good point. since grpc now also only has "officially support for gcc 7.3+" I would then first bump grpc with all it dependencies and then resubmit this patch.
https://github.com/grpc/grpc/blob/master/src/cpp/README.md
> Could you have a look into this, and submit an updated version?
>
> Thanks a lot!
>
> Thomas
Regards,
Michael
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-20 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-18 11:48 [Buildroot] [PATCH] packge/libabseil-cpp: bump to version 20230125.0 Michael Nosthoff via buildroot
2023-02-19 21:02 ` Thomas Petazzoni via buildroot
2023-02-20 7:48 ` Michael Nosthoff via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.