Re: [PATCH 1/7] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp: Add ports and orientation-switch

[Rob Herring <robh@kernel.org>]

On Mon, Apr 24, 2023 at 08:40:04PM -0700, Bjorn Andersson wrote:
> The QMP combo phy can be connected to a TCPM, a USB controller and a
> DisplayPort controller for handling USB Type-C orientation switching
> and propagating HPD signals.
> 
> Extend the binding to allow these connections to be described.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
>  .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml    | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
> index 3cd5fc3e8fab..c037ac90ce7f 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
> @@ -60,6 +60,26 @@ properties:
>      description:
>        See include/dt-bindings/dt-bindings/phy/phy-qcom-qmp.h
>  
> +  orientation-switch:
> +    description:
> +      Flag the PHY as possible handler of USB Type-C orientation switching
> +    type: boolean
> +
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +    properties:
> +      port@0:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description: Output endpoint of the PHY
> +
> +      port@1:
> +        $ref: /schemas/graph.yaml#/$defs/port-base

'port-base' means you have extra properties to add. Where are they? It 
also needs 'unevaluatedProperties: false'.

> +        description: Incoming endpoint from the USB controller
> +
> +      port@2:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        description: Incoming endpoint from the DisplayPort controller
> +
>  required:
>    - compatible
>    - reg
> @@ -98,6 +118,37 @@ examples:
>        vdda-phy-supply = <&vreg_l9d>;
>        vdda-pll-supply = <&vreg_l4d>;
>  
> +      orientation-switch;
> +
>        #clock-cells = <1>;
>        #phy-cells = <1>;
> +
> +      ports {
> +          #address-cells = <1>;
> +          #size-cells = <0>;
> +
> +          port@0 {
> +              reg = <0>;
> +
> +              endpoint {
> +                  remote-endpoint = <&typec_connector_ss>;
> +              };
> +          };
> +
> +          port@1 {
> +              reg = <1>;
> +
> +              endpoint {
> +                  remote-endpoint = <&dwc3_ss_out>;
> +              };
> +          };
> +
> +          port@2 {
> +              reg = <2>;
> +
> +              endpoint {
> +                  remote-endpoint = <&mdss_dp_out>;
> +              };
> +          };
> +      };
>      };
> -- 
> 2.39.2
>