All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] phy: qcom-qmp-combo: Support orientation switching
Date: Tue, 2 May 2023 14:26:29 +0200	[thread overview]
Message-ID: <ZFEBdT4Yh4fBItHk@hovoldconsulting.com> (raw)
In-Reply-To: <20230425034010.3789376-1-quic_bjorande@quicinc.com>

On Mon, Apr 24, 2023 at 08:40:03PM -0700, Bjorn Andersson wrote:
> This adds support for USB and DisplayPort orientation switching to the
> QMP combo PHY, as well as updating the sc8280xp devices to include the
> QMP in the SuperSpeed graph.

Nice and clean series!

I've tested it a bit on the X13s and verified that DP works on both
ports and in both orientations. Coldplug also appears to work reliably.

Tested-by: Johan Hovold <johan+linaro@kernel.org>	# X13s

> Bjorn Andersson (7):
>   dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp: Add ports and
>     orientation-switch
>   phy: qcom-qmp-combo: Move phy_mutex out of com_init/exit
>   phy: qcom-qmp-combo: Introduce orientation variable
>   phy: qcom-qmp-combo: Introduce orientation switching
>   phy: qcom-qmp-combo: Introduce drm_bridge
>   arm64: dts: qcom: sc8280xp-crd: Add QMP to SuperSpeed graph
>   arm64: dts: qcom: sc8280xp-x13s: Add QMP to SuperSpeed graph
> 
>  .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml    |  51 ++++
>  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     |  28 ++-
>  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  28 ++-
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi        |  34 +++
>  drivers/phy/qualcomm/phy-qcom-qmp-combo.c     | 227 ++++++++++++++----
>  5 files changed, 309 insertions(+), 59 deletions(-)

Johan

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] phy: qcom-qmp-combo: Support orientation switching
Date: Tue, 2 May 2023 14:26:29 +0200	[thread overview]
Message-ID: <ZFEBdT4Yh4fBItHk@hovoldconsulting.com> (raw)
In-Reply-To: <20230425034010.3789376-1-quic_bjorande@quicinc.com>

On Mon, Apr 24, 2023 at 08:40:03PM -0700, Bjorn Andersson wrote:
> This adds support for USB and DisplayPort orientation switching to the
> QMP combo PHY, as well as updating the sc8280xp devices to include the
> QMP in the SuperSpeed graph.

Nice and clean series!

I've tested it a bit on the X13s and verified that DP works on both
ports and in both orientations. Coldplug also appears to work reliably.

Tested-by: Johan Hovold <johan+linaro@kernel.org>	# X13s

> Bjorn Andersson (7):
>   dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp: Add ports and
>     orientation-switch
>   phy: qcom-qmp-combo: Move phy_mutex out of com_init/exit
>   phy: qcom-qmp-combo: Introduce orientation variable
>   phy: qcom-qmp-combo: Introduce orientation switching
>   phy: qcom-qmp-combo: Introduce drm_bridge
>   arm64: dts: qcom: sc8280xp-crd: Add QMP to SuperSpeed graph
>   arm64: dts: qcom: sc8280xp-x13s: Add QMP to SuperSpeed graph
> 
>  .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml    |  51 ++++
>  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     |  28 ++-
>  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  28 ++-
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi        |  34 +++
>  drivers/phy/qualcomm/phy-qcom-qmp-combo.c     | 227 ++++++++++++++----
>  5 files changed, 309 insertions(+), 59 deletions(-)

Johan

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2023-05-02 12:26 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25  3:40 [PATCH 0/7] phy: qcom-qmp-combo: Support orientation switching Bjorn Andersson
2023-04-25  3:40 ` Bjorn Andersson
2023-04-25  3:40 ` [PATCH 1/7] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp: Add ports and orientation-switch Bjorn Andersson
2023-04-25  3:40   ` Bjorn Andersson
2023-04-25 18:58   ` Rob Herring
2023-04-25 18:58     ` Rob Herring
2023-04-26 10:21   ` Bryan O'Donoghue
2023-04-26 10:21     ` Bryan O'Donoghue
2023-04-27 19:52     ` Bjorn Andersson
2023-04-27 19:52       ` Bjorn Andersson
2023-05-03 20:37       ` Bryan O'Donoghue
2023-05-03 20:37         ` Bryan O'Donoghue
2023-05-04 13:50       ` Neil Armstrong
2023-05-04 13:50         ` Neil Armstrong
2023-05-04 14:51         ` Bjorn Andersson
2023-05-04 14:51           ` Bjorn Andersson
2023-04-25  3:40 ` [PATCH 2/7] phy: qcom-qmp-combo: Move phy_mutex out of com_init/exit Bjorn Andersson
2023-04-25  3:40   ` Bjorn Andersson
2023-05-02 10:43   ` Johan Hovold
2023-05-02 10:43     ` Johan Hovold
2023-04-25  3:40 ` [PATCH 3/7] phy: qcom-qmp-combo: Introduce orientation variable Bjorn Andersson
2023-04-25  3:40   ` Bjorn Andersson
2023-04-27 13:13   ` Neil Armstrong
2023-04-27 13:13     ` Neil Armstrong
2023-05-02 11:48   ` Johan Hovold
2023-05-02 11:48     ` Johan Hovold
2023-05-04  3:29     ` Bjorn Andersson
2023-05-04  3:29       ` Bjorn Andersson
2023-05-04 13:44       ` Johan Hovold
2023-05-04 13:44         ` Johan Hovold
2023-05-04 15:16         ` Bjorn Andersson
2023-05-04 15:16           ` Bjorn Andersson
2023-05-04 15:41           ` Johan Hovold
2023-05-04 15:41             ` Johan Hovold
2023-04-25  3:40 ` [PATCH 4/7] phy: qcom-qmp-combo: Introduce orientation switching Bjorn Andersson
2023-04-25  3:40   ` Bjorn Andersson
2023-04-27 13:18   ` Neil Armstrong
2023-04-27 13:18     ` Neil Armstrong
2023-05-02 11:56   ` Johan Hovold
2023-05-02 11:56     ` Johan Hovold
2023-04-25  3:40 ` [PATCH 5/7] phy: qcom-qmp-combo: Introduce drm_bridge Bjorn Andersson
2023-04-25  3:40   ` Bjorn Andersson
2023-04-26 10:33   ` Bryan O'Donoghue
2023-04-26 10:33     ` Bryan O'Donoghue
2023-04-27 13:11     ` Neil Armstrong
2023-04-27 13:11       ` Neil Armstrong
2023-04-27 18:00       ` Dmitry Baryshkov
2023-04-27 18:00         ` Dmitry Baryshkov
2023-04-27 19:55     ` Bjorn Andersson
2023-04-27 19:55       ` Bjorn Andersson
2023-04-28  6:55       ` Bryan O'Donoghue
2023-04-28  6:55         ` Bryan O'Donoghue
2023-05-01 19:32   ` kernel test robot
2023-05-02  5:16   ` kernel test robot
2023-05-02 12:05   ` Johan Hovold
2023-05-02 12:05     ` Johan Hovold
2023-05-04  3:13     ` Bjorn Andersson
2023-05-04  3:13       ` Bjorn Andersson
2023-05-04  8:38       ` Johan Hovold
2023-05-04  8:38         ` Johan Hovold
2023-05-04  8:55         ` Dmitry Baryshkov
2023-05-04  8:55           ` Dmitry Baryshkov
2023-05-04 15:49         ` Bjorn Andersson
2023-05-04 15:49           ` Bjorn Andersson
2023-04-25  3:40 ` [PATCH 6/7] arm64: dts: qcom: sc8280xp-crd: Add QMP to SuperSpeed graph Bjorn Andersson
2023-04-25  3:40   ` Bjorn Andersson
2023-04-26 23:33   ` Konrad Dybcio
2023-04-26 23:33     ` Konrad Dybcio
2023-04-27 13:27     ` Neil Armstrong
2023-04-27 13:27       ` Neil Armstrong
2023-05-02 11:03       ` Konrad Dybcio
2023-05-02 11:03         ` Konrad Dybcio
2023-04-27 19:48     ` Bjorn Andersson
2023-04-27 19:48       ` Bjorn Andersson
2023-05-02 12:22   ` Johan Hovold
2023-05-02 12:22     ` Johan Hovold
2023-05-04  3:07     ` Bjorn Andersson
2023-05-04  3:07       ` Bjorn Andersson
2023-04-25  3:40 ` [PATCH 7/7] arm64: dts: qcom: sc8280xp-x13s: " Bjorn Andersson
2023-04-25  3:40   ` Bjorn Andersson
2023-04-25  4:58 ` [PATCH 0/7] phy: qcom-qmp-combo: Support orientation switching Steev Klimaszewski
2023-04-25  4:58   ` Steev Klimaszewski
2023-04-26 14:25 ` Abel Vesa
2023-04-26 14:25   ` Abel Vesa
2023-05-02 12:26 ` Johan Hovold [this message]
2023-05-02 12:26   ` Johan Hovold
2023-05-03  9:50 ` Neil Armstrong
2023-05-03  9:50   ` Neil Armstrong
2023-05-23  3:03 ` Bjorn Andersson
2023-05-23  3:03   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFEBdT4Yh4fBItHk@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=quic_bjorande@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.