Re: [PATCH b4] b4: fix from header not using real name

[Justin Stitt <justinstitt@google.com>]

On Thu, Jul 27, 2023 at 06:47:36PM +0000, Justin Stitt wrote:
> When using `b4 send` there seems to be an issue with the real name not
> being included in the From: header.
>
> Here's an example:
> | From:	justinstitt@google.com
>
> Whereas, something like the following is preferred:
> | From: Justin Stitt <justinstitt@google.com>
>
> This patch fixes this issue and achieves the preferred behavior (above)
> by properly using both parts of a user's `from` field from their config.
>
> A .gitconfig like this now properly works
> | [sendemail]
> |   from = Justin Stitt <justinstitt@google.com>
>
> It should be noted that myself and Nick (reported this issue) use an
> internal smtpserver called sendgmr. I'm not sure if this is a non-issue
> on other smtpservers but the fix I've outlined in this patch looks
> universal for locally-ran smtp commands.

I wonder if this breaks other non-sendgmr use cases and as such this
patch should take on a different form. One such idea is checking
specifically for sendgmr usage and adjusting the -f flag as such.

>
> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217332#c9
> Signed-off-by: Justin Stitt <justinstitt@google.com>
> ---
>  b4/__init__.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/b4/__init__.py b/b4/__init__.py
> index b974642..760ba33 100644
> --- a/b4/__init__.py
> +++ b/b4/__init__.py
> @@ -3259,7 +3259,7 @@ def get_smtp(dryrun: bool = False) -> Tuple[Union[smtplib.SMTP, smtplib.SMTP_SSL
>          else:
>              envpair = email.utils.parseaddr(fromaddr)
>          if envpair[1]:
> -            smtp += ['-f', envpair[1]]
> +            smtp += ['-f', f"{envpair[0]} <{envpair[1]}>"]
>          return smtp, fromaddr
>
>      encryption = sconfig.get('smtpencryption')
>
> ---
> base-commit: 099c9b47b39b6076752b8c757872080fad8fae56
> change-id: 20230727-fix-from-header-c81940de575b
>
> Best regards,
> --
> Justin Stitt <justinstitt@google.com>
>