From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Justin Stitt <justinstitt@google.com>,
Kees Cook <keescook@chromium.org>, Kees Cook <kees@kernel.org>,
"Kernel.org Tools" <tools@linux.kernel.org>,
Sterling Stein <scubed@google.com>
Subject: Re: [PATCH b4] b4: fix from header not using real name
Date: Thu, 3 Aug 2023 15:32:38 -0400 [thread overview]
Message-ID: <20230803-swifter-chalice-67392c@meerkat> (raw)
In-Reply-To: <CAKwvOd=5PuW1VWUxmOkXGZtkus2ZoyyW_9HNKnjUwfjGKEr14w@mail.gmail.com>
On Thu, Aug 03, 2023 at 11:41:51AM -0700, Nick Desaulniers wrote:
> > I am fairly certain that at least some clients will not properly handle such
> > situations, because I think -f is only supposed to have the email address, not
> > the full From-like header.
> >
> > Now, the question is -- does sendgmr support the -F flag?
>
> It does not currently, but we probably could add support for it.
Per our IRC discussion, I think we stumbled on the solution that works for
your case and makes b4 more compatible with git-send-email. Specifically, we
only pass the -f switch if envelopesender is set.
> What are your thoughts Konstantin on -t?
I don't really see the point of it, as we already pass the list of recipients
as part of the command line invocation. The -t switch is just a convenience
flag for humans.
-K
next prev parent reply other threads:[~2023-08-03 19:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 18:47 [PATCH b4] b4: fix from header not using real name Justin Stitt
2023-07-27 23:07 ` Justin Stitt
2023-07-27 23:20 ` Kees Cook
2023-08-01 16:12 ` Nick Desaulniers
2023-08-01 16:44 ` Kees Cook
2023-08-01 17:04 ` Konstantin Ryabitsev
2023-08-01 20:07 ` Justin Stitt
2023-08-01 22:25 ` Nick Desaulniers
2023-08-01 22:27 ` Justin Stitt
2023-08-01 22:34 ` Nick Desaulniers
2023-08-03 17:47 ` Nick Desaulniers
2023-08-03 17:51 ` Justin Stitt
2023-08-03 18:17 ` Konstantin Ryabitsev
2023-08-03 18:41 ` Nick Desaulniers
2023-08-03 19:32 ` Konstantin Ryabitsev [this message]
2023-08-03 20:58 ` Nick Desaulniers
2023-08-03 18:41 ` Justin Stitt
2023-08-01 22:20 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803-swifter-chalice-67392c@meerkat \
--to=konstantin@linuxfoundation.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=keescook@chromium.org \
--cc=ndesaulniers@google.com \
--cc=scubed@google.com \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.