Re: [PATCH b4] b4: fix from header not using real name

[Kees Cook <kees@kernel.org>]

On July 27, 2023 11:47:36 AM PDT, Justin Stitt <justinstitt@google.com> wrote:
>When using `b4 send` there seems to be an issue with the real name not
>being included in the From: header.
>
>Here's an example:
>| From:	justinstitt@google.com
>
>Whereas, something like the following is preferred:
>| From: Justin Stitt <justinstitt@google.com>

Hmm. There are actually two "From" fields. There's envelope sender "From" (which is what -f sets), and the in-body "From:" field. I wonder if b4 isn't constructing the in-body From: field, and when missing, the MUAs add it based on the -f flag?

>This patch fixes this issue and achieves the preferred behavior (above)
>by properly using both parts of a user's `from` field from their config.
>
>A .gitconfig like this now properly works
>| [sendemail]
>|   from = Justin Stitt <justinstitt@google.com>

Perhaps what's needed is this (which is what I've been using forever):

[sendemail]
	envelopesender = auto



-- 
Kees Cook