Re: [PATCH b4] b4: fix from header not using real name

[Kees Cook <keescook@chromium.org>]

On Tue, Aug 01, 2023 at 09:12:35AM -0700, Nick Desaulniers wrote:
> On Thu, Jul 27, 2023 at 4:20 PM Kees Cook <kees@kernel.org> wrote:
> >
> > On July 27, 2023 11:47:36 AM PDT, Justin Stitt <justinstitt@google.com> wrote:
> > >When using `b4 send` there seems to be an issue with the real name not
> > >being included in the From: header.
> > >
> > >Here's an example:
> > >| From:        justinstitt@google.com
> > >
> > >Whereas, something like the following is preferred:
> > >| From: Justin Stitt <justinstitt@google.com>
> >
> > Hmm. There are actually two "From" fields. There's envelope sender "From" (which is what -f sets), and the in-body "From:" field. I wonder if b4 isn't constructing the in-body From: field, and when missing, the MUAs add it based on the -f flag?
> >
> > >This patch fixes this issue and achieves the preferred behavior (above)
> > >by properly using both parts of a user's `from` field from their config.
> > >
> > >A .gitconfig like this now properly works
> > >| [sendemail]
> > >|   from = Justin Stitt <justinstitt@google.com>
> >
> > Perhaps what's needed is this (which is what I've been using forever):
> >
> > [sendemail]
> >         envelopesender = auto
> 
> Thanks for the tip; I'll give that a shot. Do you have `from` set
> under `[sendemail]` as well or no?

I don't, no. I also don't use "b4 send" (just "git send-email"), so it's
not clear to me what's actually going wrong here. It still looks to me
like either "b4 send" isn't writing a "From:" header, or Justin (and
your?) MUA is removing/replacing it when it processes the "-f" argument.

FWIW, my MUA is postfix. (Though actually, I guess, it's the MTA, b4 or
git is the MUA... whatever. The thing I hand off to is postfix.)

For the relevant ~/.gitconfig settings, I have:

[user]
        email = keescook@chromium.org
        name = Kees Cook
[sendemail]
        envelopesender = auto
        confirm = auto


-- 
Kees Cook