All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <michael@walle.cc>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Dhruva Gole <d-gole@ti.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported
Date: Fri, 10 Nov 2023 07:39:17 +0200	[thread overview]
Message-ID: <20231110053917.GH17433@black.fi.intel.com> (raw)
In-Reply-To: <20231108094303.46303-2-acelan.kao@canonical.com>

On Wed, Nov 08, 2023 at 05:43:03PM +0800, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> When the software reset command isn't supported, we now stop reporting
> the warning message to avoid unnecessary warnings and potential confusion.
> 
> Reviewed-by: Dhruva Gole <d-gole@ti.com>
> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>

Looks good to me, only small comment is that perhaps you want to update
the kernel-doc of spi_mem_exec_op() to mention that if the
driver/controller does not support reset it can return -EOPNOTSUPP.

In any case,

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <michael@walle.cc>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Dhruva Gole <d-gole@ti.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported
Date: Fri, 10 Nov 2023 07:39:17 +0200	[thread overview]
Message-ID: <20231110053917.GH17433@black.fi.intel.com> (raw)
In-Reply-To: <20231108094303.46303-2-acelan.kao@canonical.com>

On Wed, Nov 08, 2023 at 05:43:03PM +0800, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> When the software reset command isn't supported, we now stop reporting
> the warning message to avoid unnecessary warnings and potential confusion.
> 
> Reviewed-by: Dhruva Gole <d-gole@ti.com>
> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>

Looks good to me, only small comment is that perhaps you want to update
the kernel-doc of spi_mem_exec_op() to mention that if the
driver/controller does not support reset it can return -EOPNOTSUPP.

In any case,

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

  parent reply	other threads:[~2023-11-10  5:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08  9:43 [PATCH v5 1/2] spi: Replace -ENOTSUPP with -EOPNOTSUPP in op checking AceLan Kao
2023-11-08  9:43 ` AceLan Kao
2023-11-08  9:43 ` [PATCH v5 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported AceLan Kao
2023-11-08  9:43   ` AceLan Kao
2023-11-09 10:57   ` Michael Walle
2023-11-09 10:57     ` Michael Walle
2023-11-13 12:44     ` Pratyush Yadav
2023-11-13 12:44       ` Pratyush Yadav
2023-11-10  5:39   ` Mika Westerberg [this message]
2023-11-10  5:39     ` Mika Westerberg
2023-11-09 10:56 ` [PATCH v5 1/2] spi: Replace -ENOTSUPP with -EOPNOTSUPP in op checking Michael Walle
2023-11-09 10:56   ` Michael Walle
2023-11-10 10:22   ` AceLan Kao
2023-11-10 10:22     ` AceLan Kao
2023-11-10  5:37 ` Mika Westerberg
2023-11-10  5:37   ` Mika Westerberg
2023-11-10 10:25   ` AceLan Kao
2023-11-10 10:25     ` AceLan Kao
2023-11-10 10:37     ` Mika Westerberg
2023-11-10 10:37       ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231110053917.GH17433@black.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=acelan.kao@canonical.com \
    --cc=d-gole@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.