All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: AceLan Kao <acelan.kao@canonical.com>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 Mika Westerberg <mika.westerberg@linux.intel.com>,
	 Dhruva Gole <d-gole@ti.com>,
	linux-mtd@lists.infradead.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported
Date: Mon, 13 Nov 2023 13:44:42 +0100	[thread overview]
Message-ID: <mafs04jhpg6v9.fsf@kernel.org> (raw)
In-Reply-To: <7fbd05e9683e7c79d7d9ef1bf2cec5e8@walle.cc> (Michael Walle's message of "Thu, 09 Nov 2023 11:57:48 +0100")

Hi Michael,

On Thu, Nov 09 2023, Michael Walle wrote:

>> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
>> When the software reset command isn't supported, we now stop reporting
>> the warning message to avoid unnecessary warnings and potential confusion.
>> Reviewed-by: Dhruva Gole <d-gole@ti.com>
>> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
>
> Reviewed-by: Michael Walle <michael@walle.cc>

I did read your reply on the previous thread but did not find time to
write a response. I do largely see sense in your argument though I have
not fully thought it through yet. But I think it would be great if we
can ask the controller "do we need to do a soft reset?"

Anyway, I do not think this patch does anything too bad so it is
probably not worth debating so much on. So for now,

Acked-by: Pratyush Yadav <pratyush@kernel.org>

-- 
Regards,
Pratyush Yadav

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <pratyush@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: AceLan Kao <acelan.kao@canonical.com>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Dhruva Gole <d-gole@ti.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported
Date: Mon, 13 Nov 2023 13:44:42 +0100	[thread overview]
Message-ID: <mafs04jhpg6v9.fsf@kernel.org> (raw)
In-Reply-To: <7fbd05e9683e7c79d7d9ef1bf2cec5e8@walle.cc> (Michael Walle's message of "Thu, 09 Nov 2023 11:57:48 +0100")

Hi Michael,

On Thu, Nov 09 2023, Michael Walle wrote:

>> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
>> When the software reset command isn't supported, we now stop reporting
>> the warning message to avoid unnecessary warnings and potential confusion.
>> Reviewed-by: Dhruva Gole <d-gole@ti.com>
>> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
>
> Reviewed-by: Michael Walle <michael@walle.cc>

I did read your reply on the previous thread but did not find time to
write a response. I do largely see sense in your argument though I have
not fully thought it through yet. But I think it would be great if we
can ask the controller "do we need to do a soft reset?"

Anyway, I do not think this patch does anything too bad so it is
probably not worth debating so much on. So for now,

Acked-by: Pratyush Yadav <pratyush@kernel.org>

-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2023-11-13 12:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08  9:43 [PATCH v5 1/2] spi: Replace -ENOTSUPP with -EOPNOTSUPP in op checking AceLan Kao
2023-11-08  9:43 ` AceLan Kao
2023-11-08  9:43 ` [PATCH v5 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported AceLan Kao
2023-11-08  9:43   ` AceLan Kao
2023-11-09 10:57   ` Michael Walle
2023-11-09 10:57     ` Michael Walle
2023-11-13 12:44     ` Pratyush Yadav [this message]
2023-11-13 12:44       ` Pratyush Yadav
2023-11-10  5:39   ` Mika Westerberg
2023-11-10  5:39     ` Mika Westerberg
2023-11-09 10:56 ` [PATCH v5 1/2] spi: Replace -ENOTSUPP with -EOPNOTSUPP in op checking Michael Walle
2023-11-09 10:56   ` Michael Walle
2023-11-10 10:22   ` AceLan Kao
2023-11-10 10:22     ` AceLan Kao
2023-11-10  5:37 ` Mika Westerberg
2023-11-10  5:37   ` Mika Westerberg
2023-11-10 10:25   ` AceLan Kao
2023-11-10 10:25     ` AceLan Kao
2023-11-10 10:37     ` Mika Westerberg
2023-11-10 10:37       ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mafs04jhpg6v9.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=acelan.kao@canonical.com \
    --cc=d-gole@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=mika.westerberg@linux.intel.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.