From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Dhruva Gole <d-gole@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] spi: Replace -ENOTSUPP with -EOPNOTSUPP in op checking
Date: Fri, 10 Nov 2023 12:37:34 +0200 [thread overview]
Message-ID: <20231110103734.GJ17433@black.fi.intel.com> (raw)
In-Reply-To: <CAFv23QnbG0QX=cGjVYA1GnQFf9HFd7M7gXuAxBDO4o-POvO9yg@mail.gmail.com>
On Fri, Nov 10, 2023 at 06:25:41PM +0800, AceLan Kao wrote:
> Hi Mika,
>
> Mika Westerberg <mika.westerberg@linux.intel.com> 於 2023年11月10日 週五 下午1:37寫道：
> >
> > Hi,
> >
> > On Wed, Nov 08, 2023 at 05:43:02PM +0800, AceLan Kao wrote:
> > > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> > >
> > > No functional changes are introduced by this patch; it's a code cleanup
> > > to use the correct error code.
> >
> > Probably good to mention here that this affect only the "SPI MEM"
> > drivers and the core parts. Also you could explain here that the reaosn
> > for this is to make sure we use unified "operation not supported" return
> > code accross these.
> Got it.
> >
> > Does some kernel-doc need updating as well to make sure the future
> > drivers will return the correct one if they do not support given
> > optional operations?
> I have no idea where to add this, do you mean add a section in
> Documentation/spi/spi-summary.rst?
I mean in include/linux/spi/spi-mem.h kernel-doc of struct
spi_controller_mem_ops perhaps? Or kernel-doc of spi_mem_exec_op()?
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Dhruva Gole <d-gole@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] spi: Replace -ENOTSUPP with -EOPNOTSUPP in op checking
Date: Fri, 10 Nov 2023 12:37:34 +0200 [thread overview]
Message-ID: <20231110103734.GJ17433@black.fi.intel.com> (raw)
In-Reply-To: <CAFv23QnbG0QX=cGjVYA1GnQFf9HFd7M7gXuAxBDO4o-POvO9yg@mail.gmail.com>
On Fri, Nov 10, 2023 at 06:25:41PM +0800, AceLan Kao wrote:
> Hi Mika,
>
> Mika Westerberg <mika.westerberg@linux.intel.com> 於 2023年11月10日 週五 下午1:37寫道：
> >
> > Hi,
> >
> > On Wed, Nov 08, 2023 at 05:43:02PM +0800, AceLan Kao wrote:
> > > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> > >
> > > No functional changes are introduced by this patch; it's a code cleanup
> > > to use the correct error code.
> >
> > Probably good to mention here that this affect only the "SPI MEM"
> > drivers and the core parts. Also you could explain here that the reaosn
> > for this is to make sure we use unified "operation not supported" return
> > code accross these.
> Got it.
> >
> > Does some kernel-doc need updating as well to make sure the future
> > drivers will return the correct one if they do not support given
> > optional operations?
> I have no idea where to add this, do you mean add a section in
> Documentation/spi/spi-summary.rst?
I mean in include/linux/spi/spi-mem.h kernel-doc of struct
spi_controller_mem_ops perhaps? Or kernel-doc of spi_mem_exec_op()?
next prev parent reply other threads:[~2023-11-10 10:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 9:43 [PATCH v5 1/2] spi: Replace -ENOTSUPP with -EOPNOTSUPP in op checking AceLan Kao
2023-11-08 9:43 ` AceLan Kao
2023-11-08 9:43 ` [PATCH v5 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported AceLan Kao
2023-11-08 9:43 ` AceLan Kao
2023-11-09 10:57 ` Michael Walle
2023-11-09 10:57 ` Michael Walle
2023-11-13 12:44 ` Pratyush Yadav
2023-11-13 12:44 ` Pratyush Yadav
2023-11-10 5:39 ` Mika Westerberg
2023-11-10 5:39 ` Mika Westerberg
2023-11-09 10:56 ` [PATCH v5 1/2] spi: Replace -ENOTSUPP with -EOPNOTSUPP in op checking Michael Walle
2023-11-09 10:56 ` Michael Walle
2023-11-10 10:22 ` AceLan Kao
2023-11-10 10:22 ` AceLan Kao
2023-11-10 5:37 ` Mika Westerberg
2023-11-10 5:37 ` Mika Westerberg
2023-11-10 10:25 ` AceLan Kao
2023-11-10 10:25 ` AceLan Kao
2023-11-10 10:37 ` Mika Westerberg [this message]
2023-11-10 10:37 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110103734.GJ17433@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=acelan.kao@canonical.com \
--cc=d-gole@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.