From: Rob Herring <robh@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Alexander Couzens <lynxis@fe80.eu>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [RFC PATCH v2 5/8] net: pcs: add driver for MediaTek USXGMII PCS
Date: Wed, 6 Dec 2023 07:34:03 -0600 [thread overview]
Message-ID: <20231206133403.GA1894508-robh@kernel.org> (raw)
In-Reply-To: <3cd8af5e44554c2db2d7898494ee813967206bd9.1701826319.git.daniel@makrotopia.org>
On Wed, Dec 06, 2023 at 01:44:38AM +0000, Daniel Golle wrote:
> Add driver for USXGMII PCS found in the MediaTek MT7988 SoC and supporting
> USXGMII, 10GBase-R and 5GBase-R interface modes. In order to support
> Cisco SGMII, 1000Base-X and 2500Base-X via the also present LynxI PCS
> create a wrapped PCS taking care of the components shared between the
> new USXGMII PCS and the legacy LynxI PCS.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../bindings/net/pcs/mediatek,usxgmii.yaml | 46 +-
Why are you changing the binding you just added?
In any case, bindings are separate patches.
> MAINTAINERS | 2 +
> drivers/net/pcs/Kconfig | 11 +
> drivers/net/pcs/Makefile | 1 +
> drivers/net/pcs/pcs-mtk-usxgmii.c | 413 ++++++++++++++++++
> include/linux/pcs/pcs-mtk-usxgmii.h | 26 ++
> 6 files changed, 456 insertions(+), 43 deletions(-)
> create mode 100644 drivers/net/pcs/pcs-mtk-usxgmii.c
> create mode 100644 include/linux/pcs/pcs-mtk-usxgmii.h
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Alexander Couzens <lynxis@fe80.eu>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [RFC PATCH v2 5/8] net: pcs: add driver for MediaTek USXGMII PCS
Date: Wed, 6 Dec 2023 07:34:03 -0600 [thread overview]
Message-ID: <20231206133403.GA1894508-robh@kernel.org> (raw)
In-Reply-To: <3cd8af5e44554c2db2d7898494ee813967206bd9.1701826319.git.daniel@makrotopia.org>
On Wed, Dec 06, 2023 at 01:44:38AM +0000, Daniel Golle wrote:
> Add driver for USXGMII PCS found in the MediaTek MT7988 SoC and supporting
> USXGMII, 10GBase-R and 5GBase-R interface modes. In order to support
> Cisco SGMII, 1000Base-X and 2500Base-X via the also present LynxI PCS
> create a wrapped PCS taking care of the components shared between the
> new USXGMII PCS and the legacy LynxI PCS.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../bindings/net/pcs/mediatek,usxgmii.yaml | 46 +-
Why are you changing the binding you just added?
In any case, bindings are separate patches.
> MAINTAINERS | 2 +
> drivers/net/pcs/Kconfig | 11 +
> drivers/net/pcs/Makefile | 1 +
> drivers/net/pcs/pcs-mtk-usxgmii.c | 413 ++++++++++++++++++
> include/linux/pcs/pcs-mtk-usxgmii.h | 26 ++
> 6 files changed, 456 insertions(+), 43 deletions(-)
> create mode 100644 drivers/net/pcs/pcs-mtk-usxgmii.c
> create mode 100644 include/linux/pcs/pcs-mtk-usxgmii.h
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Alexander Couzens <lynxis@fe80.eu>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [RFC PATCH v2 5/8] net: pcs: add driver for MediaTek USXGMII PCS
Date: Wed, 6 Dec 2023 07:34:03 -0600 [thread overview]
Message-ID: <20231206133403.GA1894508-robh@kernel.org> (raw)
In-Reply-To: <3cd8af5e44554c2db2d7898494ee813967206bd9.1701826319.git.daniel@makrotopia.org>
On Wed, Dec 06, 2023 at 01:44:38AM +0000, Daniel Golle wrote:
> Add driver for USXGMII PCS found in the MediaTek MT7988 SoC and supporting
> USXGMII, 10GBase-R and 5GBase-R interface modes. In order to support
> Cisco SGMII, 1000Base-X and 2500Base-X via the also present LynxI PCS
> create a wrapped PCS taking care of the components shared between the
> new USXGMII PCS and the legacy LynxI PCS.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../bindings/net/pcs/mediatek,usxgmii.yaml | 46 +-
Why are you changing the binding you just added?
In any case, bindings are separate patches.
> MAINTAINERS | 2 +
> drivers/net/pcs/Kconfig | 11 +
> drivers/net/pcs/Makefile | 1 +
> drivers/net/pcs/pcs-mtk-usxgmii.c | 413 ++++++++++++++++++
> include/linux/pcs/pcs-mtk-usxgmii.h | 26 ++
> 6 files changed, 456 insertions(+), 43 deletions(-)
> create mode 100644 drivers/net/pcs/pcs-mtk-usxgmii.c
> create mode 100644 include/linux/pcs/pcs-mtk-usxgmii.h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-06 13:34 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 1:43 [RFC PATCH v2 0/8] Add support for 10G Ethernet SerDes on MT7988 Daniel Golle
2023-12-06 1:43 ` Daniel Golle
2023-12-06 1:43 ` Daniel Golle
2023-12-06 1:43 ` [RFC PATCH v2 1/8] dt-bindings: phy: mediatek,xfi-pextp: add new bindings Daniel Golle
2023-12-06 1:43 ` Daniel Golle
2023-12-06 1:43 ` Daniel Golle
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 1:44 ` [RFC PATCH v2 2/8] phy: add driver for MediaTek pextp 10GE SerDes PHY Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 9:44 ` Maxime Chevallier
2023-12-06 9:44 ` Maxime Chevallier
2023-12-06 9:44 ` Maxime Chevallier
2023-12-06 1:44 ` [RFC PATCH v2 3/8] net: pcs: pcs-mtk-lynxi: add platform driver for MT7988 Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 9:38 ` Maxime Chevallier
2023-12-06 9:38 ` Maxime Chevallier
2023-12-06 9:38 ` Maxime Chevallier
2023-12-06 17:51 ` Russell King (Oracle)
2023-12-06 17:51 ` Russell King (Oracle)
2023-12-06 17:51 ` Russell King (Oracle)
2023-12-07 0:07 ` Daniel Golle
2023-12-07 0:07 ` Daniel Golle
2023-12-07 0:07 ` Daniel Golle
2023-12-06 1:44 ` [RFC PATCH v2 4/8] dt-bindings: net: pcs: add bindings for MediaTek USXGMII PCS Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 1:44 ` [RFC PATCH v2 5/8] net: pcs: add driver " Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 9:58 ` Maxime Chevallier
2023-12-06 9:58 ` Maxime Chevallier
2023-12-06 9:58 ` Maxime Chevallier
2023-12-06 17:58 ` Russell King (Oracle)
2023-12-06 17:58 ` Russell King (Oracle)
2023-12-06 17:58 ` Russell King (Oracle)
2023-12-06 18:58 ` Maxime Chevallier
2023-12-06 18:58 ` Maxime Chevallier
2023-12-06 18:58 ` Maxime Chevallier
2023-12-06 13:34 ` Rob Herring [this message]
2023-12-06 13:34 ` Rob Herring
2023-12-06 13:34 ` Rob Herring
2023-12-06 13:37 ` Daniel Golle
2023-12-06 13:37 ` Daniel Golle
2023-12-06 13:37 ` Daniel Golle
2023-12-06 17:56 ` Russell King (Oracle)
2023-12-06 17:56 ` Russell King (Oracle)
2023-12-06 17:56 ` Russell King (Oracle)
2023-12-06 1:44 ` [RFC PATCH v2 6/8] dt-bindings: net: mediatek: remove wrongly added clocks and SerDes Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 1:45 ` [RFC PATCH v2 7/8] dt-bindings: net: mediatek,net: fix and complete mt7988-eth binding Daniel Golle
2023-12-06 1:45 ` Daniel Golle
2023-12-06 1:45 ` Daniel Golle
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 13:38 ` Rob Herring
2023-12-06 13:38 ` Rob Herring
2023-12-06 13:38 ` Rob Herring
2023-12-06 16:08 ` Daniel Golle
2023-12-06 16:08 ` Daniel Golle
2023-12-06 16:08 ` Daniel Golle
2023-12-06 1:45 ` [RFC PATCH v2 8/8] net: ethernet: mtk_eth_soc: add paths and SerDes modes for MT7988 Daniel Golle
2023-12-06 1:45 ` Daniel Golle
2023-12-06 1:45 ` Daniel Golle
2023-12-06 18:55 ` Russell King (Oracle)
2023-12-06 18:55 ` Russell King (Oracle)
2023-12-06 18:55 ` Russell King (Oracle)
2023-12-06 19:52 ` Daniel Golle
2023-12-06 19:52 ` Daniel Golle
2023-12-06 19:52 ` Daniel Golle
2023-12-06 20:23 ` Russell King (Oracle)
2023-12-06 20:23 ` Russell King (Oracle)
2023-12-06 20:23 ` Russell King (Oracle)
2023-12-06 20:47 ` Daniel Golle
2023-12-06 20:47 ` Daniel Golle
2023-12-06 20:47 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206133403.GA1894508-robh@kernel.org \
--to=robh@kernel.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=SkyLake.Huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=lynxis@fe80.eu \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.