From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Daniel Golle <daniel@makrotopia.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Alexander Couzens <lynxis@fe80.eu>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [RFC PATCH v2 5/8] net: pcs: add driver for MediaTek USXGMII PCS
Date: Wed, 6 Dec 2023 17:58:08 +0000 [thread overview]
Message-ID: <ZXC2MFn7pVX/KNmJ@shell.armlinux.org.uk> (raw)
In-Reply-To: <20231206105838.069ae288@device.home>
On Wed, Dec 06, 2023 at 10:58:38AM +0100, Maxime Chevallier wrote:
> On Wed, 6 Dec 2023 01:44:38 +0000
> Daniel Golle <daniel@makrotopia.org> wrote:
> > + /* Read USXGMII link status */
> > + state->link = FIELD_GET(RG_PCS_RX_LINK_STATUS,
> > + mtk_r32(mpcs, RG_PCS_RX_STATUS0));
> > +
> > + /* Continuously repeat re-configuration sequence until link comes up */
> > + if (!state->link) {
> > + mtk_usxgmii_pcs_config(pcs, mpcs->neg_mode,
> > + state->interface, NULL, false);
> > + return;
>
> .pcs_get_state() isn't called only for link state polling,but also when querying
> the link state from ethtool, from phylink_ethtool_ksettings_get().
>
> As mtk_usxgmii_pcs_config triggers a pcs reset and reconfiguration, won't this disrupt
> the link ?
Highly likely if there's a race, but note that mtk_usxgmii_pcs_config()
only gets called if the link is *down*. I guess some IPs need a bit of
kicking to work properly.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Daniel Golle <daniel@makrotopia.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Alexander Couzens <lynxis@fe80.eu>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [RFC PATCH v2 5/8] net: pcs: add driver for MediaTek USXGMII PCS
Date: Wed, 6 Dec 2023 17:58:08 +0000 [thread overview]
Message-ID: <ZXC2MFn7pVX/KNmJ@shell.armlinux.org.uk> (raw)
In-Reply-To: <20231206105838.069ae288@device.home>
On Wed, Dec 06, 2023 at 10:58:38AM +0100, Maxime Chevallier wrote:
> On Wed, 6 Dec 2023 01:44:38 +0000
> Daniel Golle <daniel@makrotopia.org> wrote:
> > + /* Read USXGMII link status */
> > + state->link = FIELD_GET(RG_PCS_RX_LINK_STATUS,
> > + mtk_r32(mpcs, RG_PCS_RX_STATUS0));
> > +
> > + /* Continuously repeat re-configuration sequence until link comes up */
> > + if (!state->link) {
> > + mtk_usxgmii_pcs_config(pcs, mpcs->neg_mode,
> > + state->interface, NULL, false);
> > + return;
>
> .pcs_get_state() isn't called only for link state polling,but also when querying
> the link state from ethtool, from phylink_ethtool_ksettings_get().
>
> As mtk_usxgmii_pcs_config triggers a pcs reset and reconfiguration, won't this disrupt
> the link ?
Highly likely if there's a race, but note that mtk_usxgmii_pcs_config()
only gets called if the link is *down*. I guess some IPs need a bit of
kicking to work properly.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Daniel Golle <daniel@makrotopia.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Alexander Couzens <lynxis@fe80.eu>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [RFC PATCH v2 5/8] net: pcs: add driver for MediaTek USXGMII PCS
Date: Wed, 6 Dec 2023 17:58:08 +0000 [thread overview]
Message-ID: <ZXC2MFn7pVX/KNmJ@shell.armlinux.org.uk> (raw)
In-Reply-To: <20231206105838.069ae288@device.home>
On Wed, Dec 06, 2023 at 10:58:38AM +0100, Maxime Chevallier wrote:
> On Wed, 6 Dec 2023 01:44:38 +0000
> Daniel Golle <daniel@makrotopia.org> wrote:
> > + /* Read USXGMII link status */
> > + state->link = FIELD_GET(RG_PCS_RX_LINK_STATUS,
> > + mtk_r32(mpcs, RG_PCS_RX_STATUS0));
> > +
> > + /* Continuously repeat re-configuration sequence until link comes up */
> > + if (!state->link) {
> > + mtk_usxgmii_pcs_config(pcs, mpcs->neg_mode,
> > + state->interface, NULL, false);
> > + return;
>
> .pcs_get_state() isn't called only for link state polling,but also when querying
> the link state from ethtool, from phylink_ethtool_ksettings_get().
>
> As mtk_usxgmii_pcs_config triggers a pcs reset and reconfiguration, won't this disrupt
> the link ?
Highly likely if there's a race, but note that mtk_usxgmii_pcs_config()
only gets called if the link is *down*. I guess some IPs need a bit of
kicking to work properly.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-06 17:58 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 1:43 [RFC PATCH v2 0/8] Add support for 10G Ethernet SerDes on MT7988 Daniel Golle
2023-12-06 1:43 ` Daniel Golle
2023-12-06 1:43 ` Daniel Golle
2023-12-06 1:43 ` [RFC PATCH v2 1/8] dt-bindings: phy: mediatek,xfi-pextp: add new bindings Daniel Golle
2023-12-06 1:43 ` Daniel Golle
2023-12-06 1:43 ` Daniel Golle
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 1:44 ` [RFC PATCH v2 2/8] phy: add driver for MediaTek pextp 10GE SerDes PHY Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 9:44 ` Maxime Chevallier
2023-12-06 9:44 ` Maxime Chevallier
2023-12-06 9:44 ` Maxime Chevallier
2023-12-06 1:44 ` [RFC PATCH v2 3/8] net: pcs: pcs-mtk-lynxi: add platform driver for MT7988 Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 9:38 ` Maxime Chevallier
2023-12-06 9:38 ` Maxime Chevallier
2023-12-06 9:38 ` Maxime Chevallier
2023-12-06 17:51 ` Russell King (Oracle)
2023-12-06 17:51 ` Russell King (Oracle)
2023-12-06 17:51 ` Russell King (Oracle)
2023-12-07 0:07 ` Daniel Golle
2023-12-07 0:07 ` Daniel Golle
2023-12-07 0:07 ` Daniel Golle
2023-12-06 1:44 ` [RFC PATCH v2 4/8] dt-bindings: net: pcs: add bindings for MediaTek USXGMII PCS Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 1:44 ` [RFC PATCH v2 5/8] net: pcs: add driver " Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 9:58 ` Maxime Chevallier
2023-12-06 9:58 ` Maxime Chevallier
2023-12-06 9:58 ` Maxime Chevallier
2023-12-06 17:58 ` Russell King (Oracle) [this message]
2023-12-06 17:58 ` Russell King (Oracle)
2023-12-06 17:58 ` Russell King (Oracle)
2023-12-06 18:58 ` Maxime Chevallier
2023-12-06 18:58 ` Maxime Chevallier
2023-12-06 18:58 ` Maxime Chevallier
2023-12-06 13:34 ` Rob Herring
2023-12-06 13:34 ` Rob Herring
2023-12-06 13:34 ` Rob Herring
2023-12-06 13:37 ` Daniel Golle
2023-12-06 13:37 ` Daniel Golle
2023-12-06 13:37 ` Daniel Golle
2023-12-06 17:56 ` Russell King (Oracle)
2023-12-06 17:56 ` Russell King (Oracle)
2023-12-06 17:56 ` Russell King (Oracle)
2023-12-06 1:44 ` [RFC PATCH v2 6/8] dt-bindings: net: mediatek: remove wrongly added clocks and SerDes Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 1:44 ` Daniel Golle
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 1:45 ` [RFC PATCH v2 7/8] dt-bindings: net: mediatek,net: fix and complete mt7988-eth binding Daniel Golle
2023-12-06 1:45 ` Daniel Golle
2023-12-06 1:45 ` Daniel Golle
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 3:39 ` Rob Herring
2023-12-06 13:38 ` Rob Herring
2023-12-06 13:38 ` Rob Herring
2023-12-06 13:38 ` Rob Herring
2023-12-06 16:08 ` Daniel Golle
2023-12-06 16:08 ` Daniel Golle
2023-12-06 16:08 ` Daniel Golle
2023-12-06 1:45 ` [RFC PATCH v2 8/8] net: ethernet: mtk_eth_soc: add paths and SerDes modes for MT7988 Daniel Golle
2023-12-06 1:45 ` Daniel Golle
2023-12-06 1:45 ` Daniel Golle
2023-12-06 18:55 ` Russell King (Oracle)
2023-12-06 18:55 ` Russell King (Oracle)
2023-12-06 18:55 ` Russell King (Oracle)
2023-12-06 19:52 ` Daniel Golle
2023-12-06 19:52 ` Daniel Golle
2023-12-06 19:52 ` Daniel Golle
2023-12-06 20:23 ` Russell King (Oracle)
2023-12-06 20:23 ` Russell King (Oracle)
2023-12-06 20:23 ` Russell King (Oracle)
2023-12-06 20:47 ` Daniel Golle
2023-12-06 20:47 ` Daniel Golle
2023-12-06 20:47 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXC2MFn7pVX/KNmJ@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Mark-MC.Lee@mediatek.com \
--cc=SkyLake.Huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=lynxis@fe80.eu \
--cc=matthias.bgg@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.