All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Büsch" <m@bues.ch>
To: Rahul Rameshbabu <sergeantsagara@protonmail.com>
Cc: Kalle Valo <kvalo@kernel.org>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless 5/5] wifi: b43: Support advertising lack of QoS capability
Date: Sat, 30 Dec 2023 14:45:23 +0100	[thread overview]
Message-ID: <20231230144523.7df01ff5@barney> (raw)
In-Reply-To: <20231230045105.91351-6-sergeantsagara@protonmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1362 bytes --]

On Sat, 30 Dec 2023 04:51:51 +0000
Rahul Rameshbabu <sergeantsagara@protonmail.com> wrote:

> bcm4331 appears to lack QoS support.

I think that's rather unlikely.
The firmware probably is just too old for this device.

> +static const u16 b43_no_qos_chip_ids[] = {
> +	BCMA_CHIP_ID_BCM4331,
> +	0,
> +};
> +
> +static bool b43_qos_not_supported(struct b43_wldev *dev)
> +{
> +	int idx;
> +
> +	for (idx = 0; b43_no_qos_chip_ids[idx]; idx++)
> +		if (dev->dev->chip_id == b43_no_qos_chip_ids[idx])
> +			return true;
> +
> +	return false;
> +}
> +
>  static void b43_wireless_core_exit(struct b43_wldev *dev);
>  static int b43_wireless_core_init(struct b43_wldev *dev);
>  static struct b43_wldev * b43_wireless_core_stop(struct b43_wldev *dev);
> @@ -2587,7 +2603,7 @@ static void b43_request_firmware(struct work_struct *work)
>  
>  start_ieee80211:
>  	wl->hw->queues = B43_QOS_QUEUE_NUM;
> -	if (!modparam_qos || dev->fw.opensource)
> +	if (!modparam_qos || dev->fw.opensource || b43_qos_not_supported(wl->current_dev))

This looks a bit over-engineered to me.
Can we just instead do it like this, please?

	if (!modparam_qos || dev->fw.opensource || dev->dev->chip_id == BCMA_CHIP_ID_BCM4331)

>  		wl->hw->queues = 1;
>  
>  	err = ieee80211_register_hw(wl->hw);





-- 
Michael Büsch
https://bues.ch/

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: Rahul Rameshbabu <sergeantsagara@protonmail.com>
Cc: Kalle Valo <kvalo@kernel.org>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless 5/5] wifi: b43: Support advertising lack of QoS capability
Date: Sat, 30 Dec 2023 14:45:23 +0100	[thread overview]
Message-ID: <20231230144523.7df01ff5@barney> (raw)
In-Reply-To: <20231230045105.91351-6-sergeantsagara@protonmail.com>

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

On Sat, 30 Dec 2023 04:51:51 +0000
Rahul Rameshbabu <sergeantsagara@protonmail.com> wrote:

> bcm4331 appears to lack QoS support.

I think that's rather unlikely.
The firmware probably is just too old for this device.

> +static const u16 b43_no_qos_chip_ids[] = {
> +	BCMA_CHIP_ID_BCM4331,
> +	0,
> +};
> +
> +static bool b43_qos_not_supported(struct b43_wldev *dev)
> +{
> +	int idx;
> +
> +	for (idx = 0; b43_no_qos_chip_ids[idx]; idx++)
> +		if (dev->dev->chip_id == b43_no_qos_chip_ids[idx])
> +			return true;
> +
> +	return false;
> +}
> +
>  static void b43_wireless_core_exit(struct b43_wldev *dev);
>  static int b43_wireless_core_init(struct b43_wldev *dev);
>  static struct b43_wldev * b43_wireless_core_stop(struct b43_wldev *dev);
> @@ -2587,7 +2603,7 @@ static void b43_request_firmware(struct work_struct *work)
>  
>  start_ieee80211:
>  	wl->hw->queues = B43_QOS_QUEUE_NUM;
> -	if (!modparam_qos || dev->fw.opensource)
> +	if (!modparam_qos || dev->fw.opensource || b43_qos_not_supported(wl->current_dev))

This looks a bit over-engineered to me.
Can we just instead do it like this, please?

	if (!modparam_qos || dev->fw.opensource || dev->dev->chip_id == BCMA_CHIP_ID_BCM4331)

>  		wl->hw->queues = 1;
>  
>  	err = ieee80211_register_hw(wl->hw);





-- 
Michael Büsch
https://bues.ch/

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-12-30 13:46 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-30  4:51 [PATCH wireless 0/5] wifi: b43: Various QoS-related fixes Rahul Rameshbabu
2023-12-30  4:51 ` Rahul Rameshbabu
2023-12-30  4:51 ` [PATCH wireless 1/5] wifi: b43: Correct OpenFW QoS capability warning conditional Rahul Rameshbabu
2023-12-30  4:51   ` Rahul Rameshbabu
2023-12-30 13:34   ` Michael Büsch
2023-12-30 13:34     ` Michael Büsch
2023-12-30 17:17     ` Rahul Rameshbabu
2023-12-30 17:17       ` Rahul Rameshbabu
2023-12-30  4:51 ` [PATCH wireless 2/5] wifi: b43: Stop/wake correct queue in DMA Tx path when QoS is disabled Rahul Rameshbabu
2023-12-30  4:51   ` Rahul Rameshbabu
2023-12-30  7:48   ` Julian Calaby
2023-12-30  7:48     ` Julian Calaby
2023-12-30 13:40     ` Michael Büsch
2023-12-30 13:40       ` Michael Büsch
2023-12-30 17:15       ` Rahul Rameshbabu
2023-12-30 17:15         ` Rahul Rameshbabu
2023-12-30 17:41         ` Michael Büsch
2023-12-30 17:41           ` Michael Büsch
2023-12-30 19:37           ` Rahul Rameshbabu
2023-12-30 19:37             ` Rahul Rameshbabu
2023-12-30  4:51 ` [PATCH wireless 3/5] wifi: b43: Stop/wake correct queue in PIO " Rahul Rameshbabu
2023-12-30  4:51   ` Rahul Rameshbabu
2023-12-30 18:04   ` Larry Finger
2023-12-30 18:04     ` Larry Finger
2023-12-30 19:43     ` Rahul Rameshbabu
2023-12-30 19:43       ` Rahul Rameshbabu
2023-12-30 22:23       ` Larry Finger
2023-12-30 22:23         ` Larry Finger
2023-12-31  0:02         ` Rahul Rameshbabu
2023-12-31  0:02           ` Rahul Rameshbabu
2023-12-31  9:33           ` Michael Büsch
2023-12-31  9:33             ` Michael Büsch
2023-12-31 17:29             ` Rahul Rameshbabu
2023-12-31 17:29               ` Rahul Rameshbabu
2023-12-30  4:51 ` [PATCH wireless 4/5] wifi: b43: Stop correct queue in DMA worker " Rahul Rameshbabu
2023-12-30  4:51   ` Rahul Rameshbabu
2023-12-30  4:51 ` [PATCH wireless 5/5] wifi: b43: Support advertising lack of QoS capability Rahul Rameshbabu
2023-12-30  4:51   ` Rahul Rameshbabu
2023-12-30 13:45   ` Michael Büsch [this message]
2023-12-30 13:45     ` Michael Büsch
2023-12-30 17:10     ` Rahul Rameshbabu
2023-12-30 17:10       ` Rahul Rameshbabu
2023-12-30 17:43       ` Michael Büsch
2023-12-30 17:43         ` Michael Büsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231230144523.7df01ff5@barney \
    --to=m@bues.ch \
    --cc=b43-dev@lists.infradead.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sergeantsagara@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.