From: Rahul Rameshbabu <sergeantsagara@protonmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless 3/5] wifi: b43: Stop/wake correct queue in PIO Tx path when QoS is disabled
Date: Sun, 31 Dec 2023 00:02:32 +0000 [thread overview]
Message-ID: <874jfzutm5.fsf@protonmail.com> (raw)
In-Reply-To: <ca357d13-7da9-490f-9e69-4674c6ede057@lwfinger.net>
On Sat, 30 Dec, 2023 16:23:58 -0600 "Larry Finger" <Larry.Finger@lwfinger.net> wrote:
> On 12/30/23 13:43, Rahul Rameshbabu wrote:
>> Unfortunately, new firmware would not prevent the need to fix up the
>> code with regards to QoS being disabled via the kernel parameter or
>> using OpenFW. That said, new firmware could help us drop the fifth patch
>> in this series. I am thinking about using b43-fwcutter to extract
>> proprietary fw from a newer release of broadcom-wl to see if that makes
>> a difference. That said, I am a bit puzzled since the device I am
>> testing on released in early 2011, and I used firmware released in late
>> 2012.
>
> Unfortunately, it is very difficult to get the parameters for fwcutter from an
> x86 binary. Some of the other architectures are easier.
Just tried this with the x86 binary just because and ran into extraction
issues as expected. I could not find other architecture options from
Broadcom's download page, but I may not have been looking well enough...
❯ b43-fwcutter ./wlc_hybrid.o_shipped
Sorry, the input file is either wrong or not supported by b43-fwcutter.
This file has an unknown MD5sum 6889dbd24abf8006de5cc6eddd138518.
https://www.broadcom.com/support/download-search?pg=Wireless+Embedded+Solutions+and+RF+Components&pf=Legacy+Wireless&pn=&pa=Driver&po=&dk=BCM4331&pl=&l=true
I guess, for now, we can keep the exception for bcm4331 and see if
future firmware extractions help.
--
Thanks,
Rahul Rameshbabu
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
WARNING: multiple messages have this Message-ID (diff)
From: Rahul Rameshbabu <sergeantsagara@protonmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless 3/5] wifi: b43: Stop/wake correct queue in PIO Tx path when QoS is disabled
Date: Sun, 31 Dec 2023 00:02:32 +0000 [thread overview]
Message-ID: <874jfzutm5.fsf@protonmail.com> (raw)
In-Reply-To: <ca357d13-7da9-490f-9e69-4674c6ede057@lwfinger.net>
On Sat, 30 Dec, 2023 16:23:58 -0600 "Larry Finger" <Larry.Finger@lwfinger.net> wrote:
> On 12/30/23 13:43, Rahul Rameshbabu wrote:
>> Unfortunately, new firmware would not prevent the need to fix up the
>> code with regards to QoS being disabled via the kernel parameter or
>> using OpenFW. That said, new firmware could help us drop the fifth patch
>> in this series. I am thinking about using b43-fwcutter to extract
>> proprietary fw from a newer release of broadcom-wl to see if that makes
>> a difference. That said, I am a bit puzzled since the device I am
>> testing on released in early 2011, and I used firmware released in late
>> 2012.
>
> Unfortunately, it is very difficult to get the parameters for fwcutter from an
> x86 binary. Some of the other architectures are easier.
Just tried this with the x86 binary just because and ran into extraction
issues as expected. I could not find other architecture options from
Broadcom's download page, but I may not have been looking well enough...
❯ b43-fwcutter ./wlc_hybrid.o_shipped
Sorry, the input file is either wrong or not supported by b43-fwcutter.
This file has an unknown MD5sum 6889dbd24abf8006de5cc6eddd138518.
https://www.broadcom.com/support/download-search?pg=Wireless+Embedded+Solutions+and+RF+Components&pf=Legacy+Wireless&pn=&pa=Driver&po=&dk=BCM4331&pl=&l=true
I guess, for now, we can keep the exception for bcm4331 and see if
future firmware extractions help.
--
Thanks,
Rahul Rameshbabu
next prev parent reply other threads:[~2023-12-31 0:03 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-30 4:51 [PATCH wireless 0/5] wifi: b43: Various QoS-related fixes Rahul Rameshbabu
2023-12-30 4:51 ` Rahul Rameshbabu
2023-12-30 4:51 ` [PATCH wireless 1/5] wifi: b43: Correct OpenFW QoS capability warning conditional Rahul Rameshbabu
2023-12-30 4:51 ` Rahul Rameshbabu
2023-12-30 13:34 ` Michael Büsch
2023-12-30 13:34 ` Michael Büsch
2023-12-30 17:17 ` Rahul Rameshbabu
2023-12-30 17:17 ` Rahul Rameshbabu
2023-12-30 4:51 ` [PATCH wireless 2/5] wifi: b43: Stop/wake correct queue in DMA Tx path when QoS is disabled Rahul Rameshbabu
2023-12-30 4:51 ` Rahul Rameshbabu
2023-12-30 7:48 ` Julian Calaby
2023-12-30 7:48 ` Julian Calaby
2023-12-30 13:40 ` Michael Büsch
2023-12-30 13:40 ` Michael Büsch
2023-12-30 17:15 ` Rahul Rameshbabu
2023-12-30 17:15 ` Rahul Rameshbabu
2023-12-30 17:41 ` Michael Büsch
2023-12-30 17:41 ` Michael Büsch
2023-12-30 19:37 ` Rahul Rameshbabu
2023-12-30 19:37 ` Rahul Rameshbabu
2023-12-30 4:51 ` [PATCH wireless 3/5] wifi: b43: Stop/wake correct queue in PIO " Rahul Rameshbabu
2023-12-30 4:51 ` Rahul Rameshbabu
2023-12-30 18:04 ` Larry Finger
2023-12-30 18:04 ` Larry Finger
2023-12-30 19:43 ` Rahul Rameshbabu
2023-12-30 19:43 ` Rahul Rameshbabu
2023-12-30 22:23 ` Larry Finger
2023-12-30 22:23 ` Larry Finger
2023-12-31 0:02 ` Rahul Rameshbabu [this message]
2023-12-31 0:02 ` Rahul Rameshbabu
2023-12-31 9:33 ` Michael Büsch
2023-12-31 9:33 ` Michael Büsch
2023-12-31 17:29 ` Rahul Rameshbabu
2023-12-31 17:29 ` Rahul Rameshbabu
2023-12-30 4:51 ` [PATCH wireless 4/5] wifi: b43: Stop correct queue in DMA worker " Rahul Rameshbabu
2023-12-30 4:51 ` Rahul Rameshbabu
2023-12-30 4:51 ` [PATCH wireless 5/5] wifi: b43: Support advertising lack of QoS capability Rahul Rameshbabu
2023-12-30 4:51 ` Rahul Rameshbabu
2023-12-30 13:45 ` Michael Büsch
2023-12-30 13:45 ` Michael Büsch
2023-12-30 17:10 ` Rahul Rameshbabu
2023-12-30 17:10 ` Rahul Rameshbabu
2023-12-30 17:43 ` Michael Büsch
2023-12-30 17:43 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jfzutm5.fsf@protonmail.com \
--to=sergeantsagara@protonmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.