All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rahul Rameshbabu <sergeantsagara@protonmail.com>
To: "Michael Büsch" <m@bues.ch>
Cc: Kalle Valo <kvalo@kernel.org>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless 1/5] wifi: b43: Correct OpenFW QoS capability warning conditional
Date: Sat, 30 Dec 2023 17:17:40 +0000	[thread overview]
Message-ID: <874jfzk3tb.fsf@protonmail.com> (raw)
In-Reply-To: <20231230143455.4d64ffc7@barney>

On Sat, 30 Dec, 2023 14:34:55 +0100 Michael Büsch <m@bues.ch> wrote:
> [[PGP Signed Part:Undecided]]
> On Sat, 30 Dec 2023 04:51:29 +0000
> Rahul Rameshbabu <sergeantsagara@protonmail.com> wrote:
>
>> Trigger the warning message should be when the OpenFW capability for QoS
>> does not advertise QoS support. Previously, the warning would be
>> incorrectly triggered when OpenFW reported QoS capability is present.
>
>> --- a/drivers/net/wireless/broadcom/b43/main.c
>> +++ b/drivers/net/wireless/broadcom/b43/main.c
>> @@ -2713,7 +2713,7 @@ static int b43_upload_microcode(struct b43_wldev *dev)
>>  			dev->hwcrypto_enabled = false;
>>  		}
>>  		/* adding QoS support should use an offline discovery mechanism */
>> -		WARN(fwcapa & B43_FWCAPA_QOS, "QoS in OpenFW not supported\n");
>> +		WARN(!(fwcapa & B43_FWCAPA_QOS), "QoS in OpenFW not supported\n");
>>  	} else {
>>  		b43info(dev->wl, "Loading firmware version %u.%u "
>>  			"(20%.2i-%.2i-%.2i %.2i:%.2i:%.2i)\n",
>
> I don't think this patch is correct.
> It should warn, if the firmware advertises QoS, because that is not
> supported by b43 in case of OpenFW.

Thanks. I had a hard time understanding the intention of this warning. I
figured it could be the case where the warning is about the driver
disabling QoS when firmware has support but was not sure. Will drop this
patch going forward.

--
Thanks,

Rahul Rameshbabu


_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev

WARNING: multiple messages have this Message-ID (diff)
From: Rahul Rameshbabu <sergeantsagara@protonmail.com>
To: "Michael Büsch" <m@bues.ch>
Cc: Kalle Valo <kvalo@kernel.org>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless 1/5] wifi: b43: Correct OpenFW QoS capability warning conditional
Date: Sat, 30 Dec 2023 17:17:40 +0000	[thread overview]
Message-ID: <874jfzk3tb.fsf@protonmail.com> (raw)
In-Reply-To: <20231230143455.4d64ffc7@barney>

On Sat, 30 Dec, 2023 14:34:55 +0100 Michael Büsch <m@bues.ch> wrote:
> [[PGP Signed Part:Undecided]]
> On Sat, 30 Dec 2023 04:51:29 +0000
> Rahul Rameshbabu <sergeantsagara@protonmail.com> wrote:
>
>> Trigger the warning message should be when the OpenFW capability for QoS
>> does not advertise QoS support. Previously, the warning would be
>> incorrectly triggered when OpenFW reported QoS capability is present.
>
>> --- a/drivers/net/wireless/broadcom/b43/main.c
>> +++ b/drivers/net/wireless/broadcom/b43/main.c
>> @@ -2713,7 +2713,7 @@ static int b43_upload_microcode(struct b43_wldev *dev)
>>  			dev->hwcrypto_enabled = false;
>>  		}
>>  		/* adding QoS support should use an offline discovery mechanism */
>> -		WARN(fwcapa & B43_FWCAPA_QOS, "QoS in OpenFW not supported\n");
>> +		WARN(!(fwcapa & B43_FWCAPA_QOS), "QoS in OpenFW not supported\n");
>>  	} else {
>>  		b43info(dev->wl, "Loading firmware version %u.%u "
>>  			"(20%.2i-%.2i-%.2i %.2i:%.2i:%.2i)\n",
>
> I don't think this patch is correct.
> It should warn, if the firmware advertises QoS, because that is not
> supported by b43 in case of OpenFW.

Thanks. I had a hard time understanding the intention of this warning. I
figured it could be the case where the warning is about the driver
disabling QoS when firmware has support but was not sure. Will drop this
patch going forward.

--
Thanks,

Rahul Rameshbabu


  reply	other threads:[~2023-12-30 17:17 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-30  4:51 [PATCH wireless 0/5] wifi: b43: Various QoS-related fixes Rahul Rameshbabu
2023-12-30  4:51 ` Rahul Rameshbabu
2023-12-30  4:51 ` [PATCH wireless 1/5] wifi: b43: Correct OpenFW QoS capability warning conditional Rahul Rameshbabu
2023-12-30  4:51   ` Rahul Rameshbabu
2023-12-30 13:34   ` Michael Büsch
2023-12-30 13:34     ` Michael Büsch
2023-12-30 17:17     ` Rahul Rameshbabu [this message]
2023-12-30 17:17       ` Rahul Rameshbabu
2023-12-30  4:51 ` [PATCH wireless 2/5] wifi: b43: Stop/wake correct queue in DMA Tx path when QoS is disabled Rahul Rameshbabu
2023-12-30  4:51   ` Rahul Rameshbabu
2023-12-30  7:48   ` Julian Calaby
2023-12-30  7:48     ` Julian Calaby
2023-12-30 13:40     ` Michael Büsch
2023-12-30 13:40       ` Michael Büsch
2023-12-30 17:15       ` Rahul Rameshbabu
2023-12-30 17:15         ` Rahul Rameshbabu
2023-12-30 17:41         ` Michael Büsch
2023-12-30 17:41           ` Michael Büsch
2023-12-30 19:37           ` Rahul Rameshbabu
2023-12-30 19:37             ` Rahul Rameshbabu
2023-12-30  4:51 ` [PATCH wireless 3/5] wifi: b43: Stop/wake correct queue in PIO " Rahul Rameshbabu
2023-12-30  4:51   ` Rahul Rameshbabu
2023-12-30 18:04   ` Larry Finger
2023-12-30 18:04     ` Larry Finger
2023-12-30 19:43     ` Rahul Rameshbabu
2023-12-30 19:43       ` Rahul Rameshbabu
2023-12-30 22:23       ` Larry Finger
2023-12-30 22:23         ` Larry Finger
2023-12-31  0:02         ` Rahul Rameshbabu
2023-12-31  0:02           ` Rahul Rameshbabu
2023-12-31  9:33           ` Michael Büsch
2023-12-31  9:33             ` Michael Büsch
2023-12-31 17:29             ` Rahul Rameshbabu
2023-12-31 17:29               ` Rahul Rameshbabu
2023-12-30  4:51 ` [PATCH wireless 4/5] wifi: b43: Stop correct queue in DMA worker " Rahul Rameshbabu
2023-12-30  4:51   ` Rahul Rameshbabu
2023-12-30  4:51 ` [PATCH wireless 5/5] wifi: b43: Support advertising lack of QoS capability Rahul Rameshbabu
2023-12-30  4:51   ` Rahul Rameshbabu
2023-12-30 13:45   ` Michael Büsch
2023-12-30 13:45     ` Michael Büsch
2023-12-30 17:10     ` Rahul Rameshbabu
2023-12-30 17:10       ` Rahul Rameshbabu
2023-12-30 17:43       ` Michael Büsch
2023-12-30 17:43         ` Michael Büsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jfzk3tb.fsf@protonmail.com \
    --to=sergeantsagara@protonmail.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m@bues.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.