Re: [PATCH v4 03/16] iommu/arm-smmu-v3: Move arm_smmu_rmr_install_bypass_ste()

[Jason Gunthorpe <jgg@nvidia.com>]

On Mon, Jan 29, 2024 at 03:07:21PM +0000, Shameerali Kolothum Thodi wrote:

> > Logically arm_smmu_init_strtab_linear() is the function that allocates and
> > populates the stream table with the initial value of the STEs. After this
> > function returns the stream table should be fully ready.
> > 
> > arm_smmu_rmr_install_bypass_ste() adjusts the initial stream table to force
> > any SIDs that the FW says have IOMMU_RESV_DIRECT to use bypass. This
> > ensures there is no disruption to the identity mapping during boot.
> > 
> > Put arm_smmu_rmr_install_bypass_ste() into arm_smmu_init_strtab_linear(),
> > it already executes immediately after arm_smmu_init_strtab_linear().
> > 
> > No functional change intended.
> 
> I think this actually changes the behavior and will cause regression as we
> now install rmr  sids only for linear stream table not for SMMUv3 with 
> 2-level stream table supported.

Oh you are right, it should be in arm_smmu_init_strtab()

Thanks!
Jason