All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Stark <gnstark@salutedevices.com>
To: <andy.shevchenko@gmail.com>, <pavel@ucw.cz>, <lee@kernel.org>,
	<vadimp@nvidia.com>, <mpe@ellerman.id.au>, <npiggin@gmail.com>,
	<christophe.leroy@csgroup.eu>, <hdegoede@redhat.com>,
	<mazziesaccount@gmail.com>, <peterz@infradead.org>,
	<mingo@redhat.com>, <will@kernel.org>, <longman@redhat.com>,
	<boqun.feng@gmail.com>, <nikitos.tr@gmail.com>,
	<kabel@kernel.org>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linuxppc-dev@lists.ozlabs.org>, <kernel@salutedevices.com>,
	George Stark <gnstark@salutedevices.com>
Subject: [PATCH v5 01/10] locking/mutex: move mutex_destroy() definition lower
Date: Thu, 7 Mar 2024 05:40:25 +0300	[thread overview]
Message-ID: <20240307024034.1548605-2-gnstark@salutedevices.com> (raw)
In-Reply-To: <20240307024034.1548605-1-gnstark@salutedevices.com>

mutex_destroy() definition is located in the middle of the code related
purely to mutex initialization so place it separately after mutex_init()

Signed-off-by: George Stark <gnstark@salutedevices.com>
---
Hello Waiman. This is helper patch to make resulting mutex.h look like we discussed
it in December. It was in you cleanup patch at first but slept away somehow

 include/linux/mutex.h | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/include/linux/mutex.h b/include/linux/mutex.h
index 67edc4ca2bee..f7611c092db7 100644
--- a/include/linux/mutex.h
+++ b/include/linux/mutex.h
@@ -37,14 +37,10 @@
 # define __DEBUG_MUTEX_INITIALIZER(lockname)				\
 	, .magic = &lockname

-extern void mutex_destroy(struct mutex *lock);
-
 #else

 # define __DEBUG_MUTEX_INITIALIZER(lockname)

-static inline void mutex_destroy(struct mutex *lock) {}
-
 #endif

 #ifndef CONFIG_PREEMPT_RT
@@ -117,6 +113,16 @@ do {							\
 } while (0)
 #endif /* CONFIG_PREEMPT_RT */

+#ifdef CONFIG_DEBUG_MUTEXES
+
+void mutex_destroy(struct mutex *lock);
+
+#else
+
+static inline void mutex_destroy(struct mutex *lock) {}
+
+#endif
+
 /*
  * See kernel/locking/mutex.c for detailed documentation of these APIs.
  * Also see Documentation/locking/mutex-design.rst.
--
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: George Stark <gnstark@salutedevices.com>
To: <andy.shevchenko@gmail.com>, <pavel@ucw.cz>, <lee@kernel.org>,
	<vadimp@nvidia.com>, <mpe@ellerman.id.au>, <npiggin@gmail.com>,
	<christophe.leroy@csgroup.eu>, <hdegoede@redhat.com>,
	<mazziesaccount@gmail.com>, <peterz@infradead.org>,
	<mingo@redhat.com>, <will@kernel.org>, <longman@redhat.com>,
	<boqun.feng@gmail.com>, <nikitos.tr@gmail.com>,
	<kabel@kernel.org>
Cc: kernel@salutedevices.com, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
	George Stark <gnstark@salutedevices.com>
Subject: [PATCH v5 01/10] locking/mutex: move mutex_destroy() definition lower
Date: Thu, 7 Mar 2024 05:40:25 +0300	[thread overview]
Message-ID: <20240307024034.1548605-2-gnstark@salutedevices.com> (raw)
In-Reply-To: <20240307024034.1548605-1-gnstark@salutedevices.com>

mutex_destroy() definition is located in the middle of the code related
purely to mutex initialization so place it separately after mutex_init()

Signed-off-by: George Stark <gnstark@salutedevices.com>
---
Hello Waiman. This is helper patch to make resulting mutex.h look like we discussed
it in December. It was in you cleanup patch at first but slept away somehow

 include/linux/mutex.h | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/include/linux/mutex.h b/include/linux/mutex.h
index 67edc4ca2bee..f7611c092db7 100644
--- a/include/linux/mutex.h
+++ b/include/linux/mutex.h
@@ -37,14 +37,10 @@
 # define __DEBUG_MUTEX_INITIALIZER(lockname)				\
 	, .magic = &lockname

-extern void mutex_destroy(struct mutex *lock);
-
 #else

 # define __DEBUG_MUTEX_INITIALIZER(lockname)

-static inline void mutex_destroy(struct mutex *lock) {}
-
 #endif

 #ifndef CONFIG_PREEMPT_RT
@@ -117,6 +113,16 @@ do {							\
 } while (0)
 #endif /* CONFIG_PREEMPT_RT */

+#ifdef CONFIG_DEBUG_MUTEXES
+
+void mutex_destroy(struct mutex *lock);
+
+#else
+
+static inline void mutex_destroy(struct mutex *lock) {}
+
+#endif
+
 /*
  * See kernel/locking/mutex.c for detailed documentation of these APIs.
  * Also see Documentation/locking/mutex-design.rst.
--
2.25.1


  reply	other threads:[~2024-03-07  2:40 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07  2:40 [PATCH v5 00/10] devm_led_classdev_register() usage problem George Stark
2024-03-07  2:40 ` George Stark
2024-03-07  2:40 ` George Stark [this message]
2024-03-07  2:40   ` [PATCH v5 01/10] locking/mutex: move mutex_destroy() definition lower George Stark
2024-03-07  2:40 ` [PATCH v5 02/10] locking/mutex: introduce devm_mutex_init George Stark
2024-03-07  2:40   ` George Stark
2024-03-07  9:56   ` Marek Behún
2024-03-07  9:56     ` Marek Behún
2024-03-07 13:39     ` Waiman Long
2024-03-07 13:39       ` Waiman Long
2024-03-07 16:44       ` Marek Behún
2024-03-07 16:44         ` Marek Behún
2024-03-11 23:47         ` George Stark
2024-03-11 23:47           ` George Stark
2024-03-12  1:10           ` Waiman Long
2024-03-12  1:10             ` Waiman Long
2024-03-12  5:44             ` Christophe Leroy
2024-03-12  5:44               ` Christophe Leroy
2024-03-12  6:04           ` Christophe Leroy
2024-03-12  6:04             ` Christophe Leroy
2024-03-12 11:39             ` George Stark
2024-03-12 11:39               ` George Stark
2024-03-12 11:51               ` Christophe Leroy
2024-03-12 11:51                 ` Christophe Leroy
2024-03-12 15:30                 ` George Stark
2024-03-12 15:30                   ` George Stark
2024-03-12 18:17                   ` Christophe Leroy
2024-03-12 18:17                     ` Christophe Leroy
2024-03-07 10:34   ` Andy Shevchenko
2024-03-07 10:34     ` Andy Shevchenko
2024-03-12  0:01     ` George Stark
2024-03-12  0:01       ` George Stark
2024-03-12  5:41       ` Christophe Leroy
2024-03-12  5:41         ` Christophe Leroy
2024-03-12  8:58         ` Andy Shevchenko
2024-03-12  8:58           ` Andy Shevchenko
2024-03-07 13:50   ` Christophe Leroy
2024-03-07 13:50     ` Christophe Leroy
2024-03-11 23:31     ` George Stark
2024-03-11 23:31       ` George Stark
2024-03-07  2:40 ` [PATCH v5 03/10] leds: aw2013: use devm API to cleanup module's resources George Stark
2024-03-07  2:40   ` George Stark
2024-03-07  2:40 ` [PATCH v5 04/10] leds: aw200xx: " George Stark
2024-03-07  2:40   ` George Stark
2024-03-07  2:40 ` [PATCH v5 05/10] leds: lp3952: " George Stark
2024-03-07  2:40   ` George Stark
2024-03-07  2:40 ` [PATCH v5 06/10] leds: lm3532: " George Stark
2024-03-07  2:40   ` George Stark
2024-03-07  2:40 ` [PATCH v5 07/10] leds: nic78bx: " George Stark
2024-03-07  2:40   ` George Stark
2024-03-07  2:40 ` [PATCH v5 08/10] leds: mlxreg: use devm_mutex_init for mutex initializtion George Stark
2024-03-07  2:40   ` George Stark
2024-03-07  2:40 ` [PATCH v5 09/10] leds: an30259a: use devm_mutext_init for mutext initialization George Stark
2024-03-07  2:40   ` George Stark
2024-03-07  2:40 ` [PATCH v5 10/10] leds: powernv: use LED_RETAIN_AT_SHUTDOWN flag for leds George Stark
2024-03-07  2:40   ` George Stark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240307024034.1548605-2-gnstark@salutedevices.com \
    --to=gnstark@salutedevices.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=hdegoede@redhat.com \
    --cc=kabel@kernel.org \
    --cc=kernel@salutedevices.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=longman@redhat.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=nikitos.tr@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=vadimp@nvidia.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.