From: Herve Codina <herve.codina@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Lee Jones <lee@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
UNGLinuxDriver@microchip.com,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Saravana Kannan <saravanak@google.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Allan Nielsen <allan.nielsen@microchip.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 07/17] net: mdio: mscc-miim: Handle the switch reset
Date: Tue, 30 Apr 2024 17:40:44 +0200 [thread overview]
Message-ID: <20240430174044.606c2ed4@bootlin.com> (raw)
In-Reply-To: <74e40e5d-e71f-4909-811e-7e9fc1120360@lunn.ch>
Hi Andrew,
On Tue, 30 Apr 2024 15:46:18 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> On Tue, Apr 30, 2024 at 10:37:16AM +0200, Herve Codina wrote:
> > The mscc-miim device can be impacted by the switch reset, at least when
> > this device is part of the LAN966x PCI device.
>
> Just to be sure i understand this correctly. The MDIO bus master can
> be reset using the "switch" reset. So you are adding code to ensure
> the "switch" reset is out of reset state, so the MDIO bus master
> works.
Exactly.
>
> Given that this is a new property, maybe give it a better name to
> indicate it resets both the switch and the MDIO bus master?
>
Replied in the patch in the same series introducing the property
[PATCH 06/17] dt-bindings: net: mscc-miim: Add resets property
Thanks for the feedback.
Best regards,
Hervé
WARNING: multiple messages have this Message-ID (diff)
From: Herve Codina <herve.codina@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Lee Jones <lee@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
UNGLinuxDriver@microchip.com,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Saravana Kannan <saravanak@google.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Allan Nielsen <allan.nielsen@microchip.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 07/17] net: mdio: mscc-miim: Handle the switch reset
Date: Tue, 30 Apr 2024 17:40:44 +0200 [thread overview]
Message-ID: <20240430174044.606c2ed4@bootlin.com> (raw)
In-Reply-To: <74e40e5d-e71f-4909-811e-7e9fc1120360@lunn.ch>
Hi Andrew,
On Tue, 30 Apr 2024 15:46:18 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> On Tue, Apr 30, 2024 at 10:37:16AM +0200, Herve Codina wrote:
> > The mscc-miim device can be impacted by the switch reset, at least when
> > this device is part of the LAN966x PCI device.
>
> Just to be sure i understand this correctly. The MDIO bus master can
> be reset using the "switch" reset. So you are adding code to ensure
> the "switch" reset is out of reset state, so the MDIO bus master
> works.
Exactly.
>
> Given that this is a new property, maybe give it a better name to
> indicate it resets both the switch and the MDIO bus master?
>
Replied in the patch in the same series introducing the property
[PATCH 06/17] dt-bindings: net: mscc-miim: Add resets property
Thanks for the feedback.
Best regards,
Hervé
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-30 15:40 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 8:37 [PATCH 00/17] Add support for the LAN966x PCI device using a DT overlay Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 8:37 ` [PATCH 01/17] mfd: syscon: Add reference counting and device managed support Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 20:34 ` Simon Horman
2024-04-30 20:34 ` Simon Horman
2024-05-02 13:29 ` Herve Codina
2024-05-02 13:29 ` Herve Codina
2024-04-30 21:55 ` kernel test robot
2024-04-30 21:55 ` kernel test robot
2024-04-30 22:07 ` kernel test robot
2024-04-30 22:07 ` kernel test robot
2024-04-30 8:37 ` [PATCH 02/17] reset: mchp: sparx5: Remove dependencies and allow building as a module Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 8:37 ` [PATCH 03/17] reset: mchp: sparx5: Release syscon when not use anymore Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 8:37 ` [PATCH 04/17] reset: core: add get_device()/put_device on rcdev Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-06-21 10:16 ` Philipp Zabel
2024-04-30 8:37 ` [PATCH 05/17] reset: mchp: sparx5: set the dev member of the reset controller Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 8:37 ` [PATCH 06/17] dt-bindings: net: mscc-miim: Add resets property Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 13:55 ` Andrew Lunn
2024-04-30 13:55 ` Andrew Lunn
2024-04-30 15:40 ` Herve Codina
2024-04-30 15:40 ` Herve Codina
2024-04-30 16:31 ` Andrew Lunn
2024-04-30 16:31 ` Andrew Lunn
2024-05-02 9:50 ` Herve Codina
2024-05-02 9:50 ` Herve Codina
2024-05-02 10:31 ` Conor Dooley
2024-05-02 10:31 ` Conor Dooley
2024-05-02 12:26 ` Andrew Lunn
2024-05-02 12:26 ` Andrew Lunn
2024-05-02 13:22 ` Alexandre Belloni
2024-05-02 13:22 ` Alexandre Belloni
2024-05-03 14:21 ` Herve Codina
2024-05-03 14:21 ` Herve Codina
2024-04-30 8:37 ` [PATCH 07/17] net: mdio: mscc-miim: Handle the switch reset Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 9:21 ` Sai Krishna Gajula
2024-04-30 9:21 ` Sai Krishna Gajula
2024-05-02 13:26 ` Herve Codina
2024-05-02 13:26 ` Herve Codina
2024-04-30 13:46 ` Andrew Lunn
2024-04-30 13:46 ` Andrew Lunn
2024-04-30 15:40 ` Herve Codina [this message]
2024-04-30 15:40 ` Herve Codina
2024-04-30 8:37 ` [PATCH 08/17] net: lan966x: remove debugfs directory in probe() error path Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 13:57 ` Andrew Lunn
2024-04-30 13:57 ` Andrew Lunn
2024-04-30 14:01 ` Andrew Lunn
2024-04-30 14:01 ` Andrew Lunn
2024-04-30 8:37 ` [PATCH 09/17] dt-bindings: interrupt-controller: Add support for Microchip LAN966x OIC Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-05-07 15:28 ` Rob Herring
2024-05-07 15:28 ` Rob Herring
2024-05-13 12:37 ` Herve Codina
2024-05-13 12:37 ` Herve Codina
2024-05-13 14:53 ` Rob Herring
2024-05-13 14:53 ` Rob Herring
2024-05-13 17:04 ` Herve Codina
2024-05-13 17:04 ` Herve Codina
2024-05-22 14:24 ` Rob Herring (Arm)
2024-05-22 14:24 ` Rob Herring (Arm)
2024-04-30 8:37 ` [PATCH 10/17] irqdomain: Add missing parameter descriptions in docs Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-05-02 0:03 ` Thomas Gleixner
2024-05-02 0:03 ` Thomas Gleixner
2024-04-30 8:37 ` [PATCH 11/17] irqdomain: Introduce irq_domain_alloc() and irq_domain_publish() Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 8:37 ` [PATCH 12/17] irqchip: Add support for LAN966x OIC Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 20:24 ` Simon Horman
2024-04-30 20:24 ` Simon Horman
2024-05-02 13:24 ` Herve Codina
2024-05-02 13:24 ` Herve Codina
2024-05-01 1:17 ` kernel test robot
2024-05-01 1:17 ` kernel test robot
2024-05-08 8:08 ` Steen.Hegelund
2024-05-08 8:08 ` Steen.Hegelund
2024-05-13 12:50 ` Herve Codina
2024-05-13 12:50 ` Herve Codina
2024-04-30 8:37 ` [PATCH 13/17] MAINTAINERS: Add the Microchip LAN966x OIC driver entry Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 8:37 ` [PATCH 14/17] of: dynamic: Introduce of_changeset_add_prop_bool() Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-05-08 18:03 ` Rob Herring
2024-05-08 18:03 ` Rob Herring
2024-04-30 8:37 ` [PATCH 15/17] pci: of_property: Add the interrupt-controller property in PCI device nodes Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-05-01 17:38 ` Bjorn Helgaas
2024-05-01 17:38 ` Bjorn Helgaas
2024-05-03 14:40 ` Herve Codina
2024-05-03 14:40 ` Herve Codina
2024-04-30 8:37 ` [PATCH 16/17] mfd: Add support for LAN966x PCI device Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-05-08 8:20 ` Steen.Hegelund
2024-05-08 8:20 ` Steen.Hegelund
2024-05-14 12:55 ` Herve Codina
2024-05-14 12:55 ` Herve Codina
2024-04-30 8:37 ` [PATCH 17/17] MAINTAINERS: Add the Microchip LAN966x PCI driver entry Herve Codina
2024-04-30 8:37 ` Herve Codina
2024-04-30 13:40 ` [PATCH 00/17] Add support for the LAN966x PCI device using a DT overlay Andrew Lunn
2024-04-30 13:40 ` Andrew Lunn
2024-04-30 16:33 ` Herve Codina
2024-04-30 16:33 ` Herve Codina
2024-04-30 18:15 ` Andrew Lunn
2024-04-30 18:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430174044.606c2ed4@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luca.ceresoli@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.