From: Tomer Maimon <tmaimon77@gmail.com>
To: <linus.walleij@linaro.org>, <avifishman70@gmail.com>,
<tali.perry1@gmail.com>, <joel@jms.id.au>, <venture@google.com>,
<yuenn@google.com>, <benjaminfair@google.com>
Cc: <openbmc@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, Tomer Maimon <tmaimon77@gmail.com>
Subject: [PATCH v1 1/7] pinctrl: nuvoton: npcm8xx: clear polarity before set both edge
Date: Thu, 11 Jul 2024 22:37:43 +0300 [thread overview]
Message-ID: <20240711193749.2397471-2-tmaimon77@gmail.com> (raw)
In-Reply-To: <20240711193749.2397471-1-tmaimon77@gmail.com>
Clear polarity before setting both edges to ensure that the polarity is
in the same state before configuring events for both edges
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
index a377d36b0eb0..0cd8a5e00cde 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
@@ -241,6 +241,7 @@ static int npcmgpio_set_irq_type(struct irq_data *d, unsigned int type)
npcm_gpio_set(&bank->gc, bank->base + NPCM8XX_GP_N_POL, gpio);
break;
case IRQ_TYPE_EDGE_BOTH:
+ npcm_gpio_clr(&bank->gc, bank->base + NPCM8XX_GP_N_POL, gpio);
npcm_gpio_set(&bank->gc, bank->base + NPCM8XX_GP_N_EVBE, gpio);
break;
case IRQ_TYPE_LEVEL_LOW:
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Tomer Maimon <tmaimon77@gmail.com>
To: <linus.walleij@linaro.org>, <avifishman70@gmail.com>,
<tali.perry1@gmail.com>, <joel@jms.id.au>, <venture@google.com>,
<yuenn@google.com>, <benjaminfair@google.com>
Cc: linux-gpio@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Tomer Maimon <tmaimon77@gmail.com>
Subject: [PATCH v1 1/7] pinctrl: nuvoton: npcm8xx: clear polarity before set both edge
Date: Thu, 11 Jul 2024 22:37:43 +0300 [thread overview]
Message-ID: <20240711193749.2397471-2-tmaimon77@gmail.com> (raw)
In-Reply-To: <20240711193749.2397471-1-tmaimon77@gmail.com>
Clear polarity before setting both edges to ensure that the polarity is
in the same state before configuring events for both edges
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
index a377d36b0eb0..0cd8a5e00cde 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
@@ -241,6 +241,7 @@ static int npcmgpio_set_irq_type(struct irq_data *d, unsigned int type)
npcm_gpio_set(&bank->gc, bank->base + NPCM8XX_GP_N_POL, gpio);
break;
case IRQ_TYPE_EDGE_BOTH:
+ npcm_gpio_clr(&bank->gc, bank->base + NPCM8XX_GP_N_POL, gpio);
npcm_gpio_set(&bank->gc, bank->base + NPCM8XX_GP_N_EVBE, gpio);
break;
case IRQ_TYPE_LEVEL_LOW:
--
2.34.1
next prev parent reply other threads:[~2024-07-11 19:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 19:37 [PATCH v1 0/7] pinctrl: npcm8xx: pin configuration changes Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon [this message]
2024-07-11 19:37 ` [PATCH v1 1/7] pinctrl: nuvoton: npcm8xx: clear polarity before set both edge Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 2/7] pinctrl: nuvoton: npcm8xx: add gpi35 and gpi36 Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 3/7] pinctrl: nuvoton: npcm8xx: add pin 250 to DDR pins group Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 4/7] pinctrl: nuvoton: npcm8xx: remove unused smb4den pin, group, function Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-12 17:45 ` J. Neuschäfer
2024-07-12 17:45 ` J. Neuschäfer
2024-07-16 14:24 ` Tomer Maimon
2024-07-16 14:24 ` Tomer Maimon
2024-07-18 20:58 ` J. Neuschäfer
2024-07-18 20:58 ` J. Neuschäfer
2024-07-18 22:05 ` Tomer Maimon
2024-07-18 22:05 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 5/7] pinctrl: nuvoton: npcm8xx: remove unused lpcclk " Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 6/7] pinctrl: nuvoton: npcm8xx: modify clkrun and serirq pin configuration Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 7/7] pinctrl: nuvoton: npcm8xx: modify pins flags Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-13 12:35 ` [PATCH v1 0/7] pinctrl: npcm8xx: pin configuration changes Jonas Gorski
2024-07-13 12:35 ` Jonas Gorski
2024-07-16 14:24 ` Tomer Maimon
2024-07-16 14:24 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711193749.2397471-2-tmaimon77@gmail.com \
--to=tmaimon77@gmail.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=joel@jms.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.