From: "J. Neuschäfer" <j.neuschaefer@gmx.net>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: linus.walleij@linaro.org, avifishman70@gmail.com,
tali.perry1@gmail.com, joel@jms.id.au, venture@google.com,
yuenn@google.com, benjaminfair@google.com,
linux-gpio@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/7] pinctrl: nuvoton: npcm8xx: remove unused smb4den pin, group, function
Date: Fri, 12 Jul 2024 19:45:22 +0200 [thread overview]
Message-ID: <ZpFrslx57m62SEsg@probook> (raw)
In-Reply-To: <20240711193749.2397471-5-tmaimon77@gmail.com>
On Thu, Jul 11, 2024 at 10:37:46PM +0300, Tomer Maimon wrote:
> Remove unused smb4den pin, group and function on the Nuvoton NPCM8XX BMC
> SoC.
Does "unused" mean that they are just unused in current board designs,
or does the hardware functionality actually not exist?
Best regards, J
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
> index f342aec3f6ca..396bd07e7c74 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
> @@ -438,7 +438,6 @@ static const int smb4_pins[] = { 28, 29 };
> static const int smb4b_pins[] = { 18, 19 };
> static const int smb4c_pins[] = { 20, 21 };
> static const int smb4d_pins[] = { 22, 23 };
> -static const int smb4den_pins[] = { 17 };
> static const int smb5_pins[] = { 26, 27 };
> static const int smb5b_pins[] = { 13, 12 };
> static const int smb5c_pins[] = { 15, 14 };
> @@ -700,7 +699,6 @@ struct npcm8xx_pingroup {
> NPCM8XX_GRP(smb4b), \
> NPCM8XX_GRP(smb4c), \
> NPCM8XX_GRP(smb4d), \
> - NPCM8XX_GRP(smb4den), \
> NPCM8XX_GRP(smb5), \
> NPCM8XX_GRP(smb5b), \
> NPCM8XX_GRP(smb5c), \
> @@ -949,7 +947,6 @@ NPCM8XX_SFUNC(smb4);
> NPCM8XX_SFUNC(smb4b);
> NPCM8XX_SFUNC(smb4c);
> NPCM8XX_SFUNC(smb4d);
> -NPCM8XX_SFUNC(smb4den);
> NPCM8XX_SFUNC(smb5);
> NPCM8XX_SFUNC(smb5b);
> NPCM8XX_SFUNC(smb5c);
> @@ -1173,7 +1170,6 @@ static struct npcm8xx_func npcm8xx_funcs[] = {
> NPCM8XX_MKFUNC(smb4b),
> NPCM8XX_MKFUNC(smb4c),
> NPCM8XX_MKFUNC(smb4d),
> - NPCM8XX_MKFUNC(smb4den),
> NPCM8XX_MKFUNC(smb5),
> NPCM8XX_MKFUNC(smb5b),
> NPCM8XX_MKFUNC(smb5c),
> @@ -1348,7 +1344,7 @@ static const struct npcm8xx_pincfg pincfg[] = {
> NPCM8XX_PINCFG(14, gspi, MFSEL1, 24, smb5c, I2CSEGSEL, 20, none, NONE, 0, none, NONE, 0, none, NONE, 0, SLEW),
> NPCM8XX_PINCFG(15, gspi, MFSEL1, 24, smb5c, I2CSEGSEL, 20, none, NONE, 0, none, NONE, 0, none, NONE, 0, SLEW),
> NPCM8XX_PINCFG(16, lkgpo0, FLOCKR1, 0, smb7b, I2CSEGSEL, 27, tp_gpio2b, MFSEL7, 10, none, NONE, 0, none, NONE, 0, SLEW),
> - NPCM8XX_PINCFG(17, pspi, MFSEL3, 13, cp1gpio5, MFSEL6, 7, smb4den, I2CSEGSEL, 23, none, NONE, 0, none, NONE, 0, SLEW),
> + NPCM8XX_PINCFG(17, pspi, MFSEL3, 13, cp1gpio5, MFSEL6, 7, none, NONE, 0, none, NONE, 0, none, NONE, 0, SLEW),
> NPCM8XX_PINCFG(18, pspi, MFSEL3, 13, smb4b, I2CSEGSEL, 14, none, NONE, 0, none, NONE, 0, none, NONE, 0, SLEW),
> NPCM8XX_PINCFG(19, pspi, MFSEL3, 13, smb4b, I2CSEGSEL, 14, none, NONE, 0, none, NONE, 0, none, NONE, 0, SLEW),
> NPCM8XX_PINCFG(20, hgpio0, MFSEL2, 24, smb15, MFSEL3, 8, smb4c, I2CSEGSEL, 15, none, NONE, 0, none, NONE, 0, SLEW),
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: "J. Neuschäfer" <j.neuschaefer@gmx.net>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: benjaminfair@google.com, linux-gpio@vger.kernel.org,
avifishman70@gmail.com, venture@google.com,
linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
tali.perry1@gmail.com, joel@jms.id.au, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v1 4/7] pinctrl: nuvoton: npcm8xx: remove unused smb4den pin, group, function
Date: Fri, 12 Jul 2024 19:45:22 +0200 [thread overview]
Message-ID: <ZpFrslx57m62SEsg@probook> (raw)
In-Reply-To: <20240711193749.2397471-5-tmaimon77@gmail.com>
On Thu, Jul 11, 2024 at 10:37:46PM +0300, Tomer Maimon wrote:
> Remove unused smb4den pin, group and function on the Nuvoton NPCM8XX BMC
> SoC.
Does "unused" mean that they are just unused in current board designs,
or does the hardware functionality actually not exist?
Best regards, J
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
> index f342aec3f6ca..396bd07e7c74 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
> @@ -438,7 +438,6 @@ static const int smb4_pins[] = { 28, 29 };
> static const int smb4b_pins[] = { 18, 19 };
> static const int smb4c_pins[] = { 20, 21 };
> static const int smb4d_pins[] = { 22, 23 };
> -static const int smb4den_pins[] = { 17 };
> static const int smb5_pins[] = { 26, 27 };
> static const int smb5b_pins[] = { 13, 12 };
> static const int smb5c_pins[] = { 15, 14 };
> @@ -700,7 +699,6 @@ struct npcm8xx_pingroup {
> NPCM8XX_GRP(smb4b), \
> NPCM8XX_GRP(smb4c), \
> NPCM8XX_GRP(smb4d), \
> - NPCM8XX_GRP(smb4den), \
> NPCM8XX_GRP(smb5), \
> NPCM8XX_GRP(smb5b), \
> NPCM8XX_GRP(smb5c), \
> @@ -949,7 +947,6 @@ NPCM8XX_SFUNC(smb4);
> NPCM8XX_SFUNC(smb4b);
> NPCM8XX_SFUNC(smb4c);
> NPCM8XX_SFUNC(smb4d);
> -NPCM8XX_SFUNC(smb4den);
> NPCM8XX_SFUNC(smb5);
> NPCM8XX_SFUNC(smb5b);
> NPCM8XX_SFUNC(smb5c);
> @@ -1173,7 +1170,6 @@ static struct npcm8xx_func npcm8xx_funcs[] = {
> NPCM8XX_MKFUNC(smb4b),
> NPCM8XX_MKFUNC(smb4c),
> NPCM8XX_MKFUNC(smb4d),
> - NPCM8XX_MKFUNC(smb4den),
> NPCM8XX_MKFUNC(smb5),
> NPCM8XX_MKFUNC(smb5b),
> NPCM8XX_MKFUNC(smb5c),
> @@ -1348,7 +1344,7 @@ static const struct npcm8xx_pincfg pincfg[] = {
> NPCM8XX_PINCFG(14, gspi, MFSEL1, 24, smb5c, I2CSEGSEL, 20, none, NONE, 0, none, NONE, 0, none, NONE, 0, SLEW),
> NPCM8XX_PINCFG(15, gspi, MFSEL1, 24, smb5c, I2CSEGSEL, 20, none, NONE, 0, none, NONE, 0, none, NONE, 0, SLEW),
> NPCM8XX_PINCFG(16, lkgpo0, FLOCKR1, 0, smb7b, I2CSEGSEL, 27, tp_gpio2b, MFSEL7, 10, none, NONE, 0, none, NONE, 0, SLEW),
> - NPCM8XX_PINCFG(17, pspi, MFSEL3, 13, cp1gpio5, MFSEL6, 7, smb4den, I2CSEGSEL, 23, none, NONE, 0, none, NONE, 0, SLEW),
> + NPCM8XX_PINCFG(17, pspi, MFSEL3, 13, cp1gpio5, MFSEL6, 7, none, NONE, 0, none, NONE, 0, none, NONE, 0, SLEW),
> NPCM8XX_PINCFG(18, pspi, MFSEL3, 13, smb4b, I2CSEGSEL, 14, none, NONE, 0, none, NONE, 0, none, NONE, 0, SLEW),
> NPCM8XX_PINCFG(19, pspi, MFSEL3, 13, smb4b, I2CSEGSEL, 14, none, NONE, 0, none, NONE, 0, none, NONE, 0, SLEW),
> NPCM8XX_PINCFG(20, hgpio0, MFSEL2, 24, smb15, MFSEL3, 8, smb4c, I2CSEGSEL, 15, none, NONE, 0, none, NONE, 0, SLEW),
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-07-12 17:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 19:37 [PATCH v1 0/7] pinctrl: npcm8xx: pin configuration changes Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 1/7] pinctrl: nuvoton: npcm8xx: clear polarity before set both edge Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 2/7] pinctrl: nuvoton: npcm8xx: add gpi35 and gpi36 Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 3/7] pinctrl: nuvoton: npcm8xx: add pin 250 to DDR pins group Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 4/7] pinctrl: nuvoton: npcm8xx: remove unused smb4den pin, group, function Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-12 17:45 ` J. Neuschäfer [this message]
2024-07-12 17:45 ` J. Neuschäfer
2024-07-16 14:24 ` Tomer Maimon
2024-07-16 14:24 ` Tomer Maimon
2024-07-18 20:58 ` J. Neuschäfer
2024-07-18 20:58 ` J. Neuschäfer
2024-07-18 22:05 ` Tomer Maimon
2024-07-18 22:05 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 5/7] pinctrl: nuvoton: npcm8xx: remove unused lpcclk " Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 6/7] pinctrl: nuvoton: npcm8xx: modify clkrun and serirq pin configuration Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-11 19:37 ` [PATCH v1 7/7] pinctrl: nuvoton: npcm8xx: modify pins flags Tomer Maimon
2024-07-11 19:37 ` Tomer Maimon
2024-07-13 12:35 ` [PATCH v1 0/7] pinctrl: npcm8xx: pin configuration changes Jonas Gorski
2024-07-13 12:35 ` Jonas Gorski
2024-07-16 14:24 ` Tomer Maimon
2024-07-16 14:24 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpFrslx57m62SEsg@probook \
--to=j.neuschaefer@gmx.net \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=joel@jms.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.