[Buildroot] [PATCH] package/connman: Remove wpa_supplicant selection for wifi

[Buildroot] [PATCH] package/connman: Remove wpa_supplicant selection for wifi

[Bryce Johnson]

Connman wifi works both with IWD and wpa_supplicant.  You don't want
BR2_PACKAGE_WPA_SUPPLICANT selected when using IWD.

---
 package/connman/Config.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/connman/Config.in b/package/connman/Config.in
index af3e1f69f6..44a3b41fb2 100644
--- a/package/connman/Config.in
+++ b/package/connman/Config.in
@@ -45,8 +45,6 @@ config BR2_PACKAGE_CONNMAN_ETHERNET

 config BR2_PACKAGE_CONNMAN_WIFI
        bool "enable WiFi support"
-       select BR2_PACKAGE_WPA_SUPPLICANT # runtime
-       select BR2_PACKAGE_WPA_SUPPLICANT_DBUS # runtime
        help
          Enable WiFi support (scan and static/dhcp interface
          setup). ConnMan detects the start of wpa_supplicant
-- 
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/connman: Remove wpa_supplicant selection for wifi

[Arnout Vandecappelle via buildroot]

On 16/07/2024 23:14, Bryce Johnson wrote:
> Connman wifi works both with IWD and wpa_supplicant.  You don't want
> BR2_PACKAGE_WPA_SUPPLICANT selected when using IWD.

  But you still need one of them, right? We normally do that with a condition like:

	select BR2_PACKAGE_WPA_SUPPLICANT if !BR2_PACKAGE_IWD

(or the other way round, of course).

> 
> ---
>   package/connman/Config.in | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/package/connman/Config.in b/package/connman/Config.in
> index af3e1f69f6..44a3b41fb2 100644
> --- a/package/connman/Config.in
> +++ b/package/connman/Config.in
> @@ -45,8 +45,6 @@ config BR2_PACKAGE_CONNMAN_ETHERNET
> 
>   config BR2_PACKAGE_CONNMAN_WIFI
>          bool "enable WiFi support"
> -       select BR2_PACKAGE_WPA_SUPPLICANT # runtime
> -       select BR2_PACKAGE_WPA_SUPPLICANT_DBUS # runtime

  Actually, we would typically only enable it automatically in the .mk file, 
something like

ifneq ($(BR2_PACKAGE_IWD)$(BR2_PACKAGE_WPA_SUPPLICANT),)
CONNMAN_CONF_OPTS += --enable-wifi
else
CONNMAN_CONF_OPTS += --disable-wifi
endif

  But since we already have the explicit option, I guess we should keep it.

  Regards,
  Arnout

>          help
>            Enable WiFi support (scan and static/dhcp interface
>            setup). ConnMan detects the start of wpa_supplicant
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/connman: Remove wpa_supplicant selection for wifi

[Bryce Johnson]

Hi Arnout,
Thanks for the feedback.


On Thu, Jul 18, 2024 at 4:04 AM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
>
> On 16/07/2024 23:14, Bryce Johnson wrote:
> > Connman wifi works both with IWD and wpa_supplicant.  You don't want
> > BR2_PACKAGE_WPA_SUPPLICANT selected when using IWD.
>
>   But you still need one of them, right? We normally do that with a condition like:
>
>         select BR2_PACKAGE_WPA_SUPPLICANT if !BR2_PACKAGE_IWD
>
>

Yes you still need one or the other. I'll update the patch to do it with the

select BR2_PACKAGE_WPA_SUPPLICANT if !BR2_PACKAGE_IWD

That is probably the least unexpected behavior if someone was relying
on connman selecting wpa_supplicant by default.

First time trying to push a patch up to buildroot. Was a little
annoying trying to get git-mail working with gmail, ended up just copy
pasting the patch into an email.  I know you have your processes
already setup, but would you consider allowing the gitlab PRs someday?
 Might get more contributors!

Thanks
Bryce
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 1/1] package/connman: Remove wpa_supplicant selection for wifi

[Bryce Johnson]

Connman wifi works both with IWD and wpa_supplicant

Signed-off-by: Bryce Johnson <bryce@redpinelabs.com>
---
 package/connman/Config.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/connman/Config.in b/package/connman/Config.in
index af3e1f69f6..62516d435f 100644
--- a/package/connman/Config.in
+++ b/package/connman/Config.in
@@ -45,8 +45,7 @@ config BR2_PACKAGE_CONNMAN_ETHERNET

 config BR2_PACKAGE_CONNMAN_WIFI
     bool "enable WiFi support"
-    select BR2_PACKAGE_WPA_SUPPLICANT # runtime
-    select BR2_PACKAGE_WPA_SUPPLICANT_DBUS # runtime
+    select BR2_PACKAGE_WPA_SUPPLICANT if !BR2_PACKAGE_IWD #runtime
     help
       Enable WiFi support (scan and static/dhcp interface
       setup). ConnMan detects the start of wpa_supplicant
-- 
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/connman: Remove wpa_supplicant selection for wifi

[Thomas Petazzoni via buildroot]

Hello Bryce,

On Thu, 18 Jul 2024 09:15:16 -0600
Bryce Johnson <bryce@redpinelabs.com> wrote:

> Connman wifi works both with IWD and wpa_supplicant
> 
> Signed-off-by: Bryce Johnson <bryce@redpinelabs.com>
> ---
>  package/connman/Config.in | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/package/connman/Config.in b/package/connman/Config.in
> index af3e1f69f6..62516d435f 100644
> --- a/package/connman/Config.in
> +++ b/package/connman/Config.in
> @@ -45,8 +45,7 @@ config BR2_PACKAGE_CONNMAN_ETHERNET
> 
>  config BR2_PACKAGE_CONNMAN_WIFI
>      bool "enable WiFi support"
> -    select BR2_PACKAGE_WPA_SUPPLICANT # runtime
> -    select BR2_PACKAGE_WPA_SUPPLICANT_DBUS # runtime
> +    select BR2_PACKAGE_WPA_SUPPLICANT if !BR2_PACKAGE_IWD #runtime

But what about BR2_PACKAGE_WPA_SUPPLICANT_DBUS ?

Don't we need to also have:

	select BR2_PACKAGE_WPA_SUPPLICANT_DBUS if !BR2_PACKAGE_IWD # runtime

to preserve the same behavior?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot