From: Andrew Jones <andrew.jones@linux.dev>
To: kvm-riscv@lists.infradead.org
Subject: [kvm-unit-tests PATCH v6 5/5] riscv: sbi: Add test for timer extension
Date: Fri, 2 Aug 2024 10:36:42 +0200 [thread overview]
Message-ID: <20240802-e1bd80fc34bfd2caaf52d0b8@orel> (raw)
In-Reply-To: <20240730061821.43811-6-jamestiotio@gmail.com>
On Tue, Jul 30, 2024 at 02:18:20PM GMT, James Raphael Tiovalen wrote:
> Add a test for the set_timer function of the time extension. The test
> checks that:
> - The time extension is available
> - The installed timer interrupt handler is called
> - The timer interrupt is received within a reasonable time interval
> - The timer interrupt pending bit is cleared after the set_timer SBI
> call is made
> - The timer interrupt can be cleared either by requesting a timer
> interrupt infinitely far into the future or by masking the timer
> interrupt
I've modified the "or by masking the timer interrupt" test to work as I'd
expect it to based on a bit more thought about what the SBI TIME extension
spec is trying to say (we should clarify the spec with the PR you've
written). I also added a test for ensuring a timer is pending immediately
when setting the time with a value of zero. All tests pass.
I also moved some code around a bit and a couple other minor cleanups.
And (drum roll, please), it's now merged!
Thanks,
drew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <andrew.jones@linux.dev>
To: James Raphael Tiovalen <jamestiotio@gmail.com>
Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
atishp@rivosinc.com, cade.richard@berkeley.edu
Subject: Re: [kvm-unit-tests PATCH v6 5/5] riscv: sbi: Add test for timer extension
Date: Fri, 2 Aug 2024 10:36:42 +0200 [thread overview]
Message-ID: <20240802-e1bd80fc34bfd2caaf52d0b8@orel> (raw)
In-Reply-To: <20240730061821.43811-6-jamestiotio@gmail.com>
On Tue, Jul 30, 2024 at 02:18:20PM GMT, James Raphael Tiovalen wrote:
> Add a test for the set_timer function of the time extension. The test
> checks that:
> - The time extension is available
> - The installed timer interrupt handler is called
> - The timer interrupt is received within a reasonable time interval
> - The timer interrupt pending bit is cleared after the set_timer SBI
> call is made
> - The timer interrupt can be cleared either by requesting a timer
> interrupt infinitely far into the future or by masking the timer
> interrupt
I've modified the "or by masking the timer interrupt" test to work as I'd
expect it to based on a bit more thought about what the SBI TIME extension
spec is trying to say (we should clarify the spec with the PR you've
written). I also added a test for ensuring a timer is pending immediately
when setting the time with a value of zero. All tests pass.
I also moved some code around a bit and a couple other minor cleanups.
And (drum roll, please), it's now merged!
Thanks,
drew
next prev parent reply other threads:[~2024-08-02 8:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 6:18 [kvm-unit-tests PATCH v6 0/5] riscv: sbi: Add support to test timer extension James Raphael Tiovalen
2024-07-30 6:18 ` James Raphael Tiovalen
2024-07-30 6:18 ` [kvm-unit-tests PATCH v6 1/5] riscv: Extend exception handling support for interrupts James Raphael Tiovalen
2024-07-30 6:18 ` James Raphael Tiovalen
2024-07-30 6:18 ` [kvm-unit-tests PATCH v6 2/5] riscv: Update exception cause list James Raphael Tiovalen
2024-07-30 6:18 ` James Raphael Tiovalen
2024-07-30 6:18 ` [kvm-unit-tests PATCH v6 3/5] riscv: Add method to probe for SBI extensions James Raphael Tiovalen
2024-07-30 6:18 ` James Raphael Tiovalen
2024-07-30 6:18 ` [kvm-unit-tests PATCH v6 4/5] riscv: Add some delay and timer routines James Raphael Tiovalen
2024-07-30 6:18 ` James Raphael Tiovalen
2024-07-30 6:18 ` [kvm-unit-tests PATCH v6 5/5] riscv: sbi: Add test for timer extension James Raphael Tiovalen
2024-07-30 6:18 ` James Raphael Tiovalen
2024-08-02 8:36 ` Andrew Jones [this message]
2024-08-02 8:36 ` Andrew Jones
2024-08-02 12:23 ` James R T
2024-08-02 12:23 ` James R T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802-e1bd80fc34bfd2caaf52d0b8@orel \
--to=andrew.jones@linux.dev \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.