Re: [PATCH v5 00/14] Fix and improve the Rockchip endpoint driver

From: "Krzysztof Wilczyński" <kw@linux.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
	Rick Wertenbroek <rick.wertenbroek@gmail.com>,
	Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH v5 00/14] Fix and improve the Rockchip endpoint driver
Date: Thu, 14 Nov 2024 05:49:13 +0900	[thread overview]
Message-ID: <20241113204913.GC1138879@rocinante> (raw)
In-Reply-To: <20241017015849.190271-1-dlemoal@kernel.org>

Hello,

> This patch series fix the PCI address mapping handling of the Rockchip
> PCI endpoint driver, refactor some of its code, improves link training
> and adds handling of the PERST# signal.
> 
> This series is organized as follows:
>  - Patch 1 fixes the rockchip ATU programming
>  - Patch 2, 3 and 4 introduce small code improvments
>  - Patch 5 implements the .align_addr() operation to make the RK3399
>    endpoint controller driver fully functional with the new
>    pci_epc_mem_map() function
>  - Patch 6 uses the new align_addr operation function to fix the ATU
>    programming for MSI IRQ data mapping
>  - Patch 7, 8, 9 and 10 refactor the driver code to make it more
>    readable
>  - Patch 11 introduces the .stop() endpoint controller operation to
>    correctly disable the endpopint controller after use
>  - Patch 12 improves link training
>  - Patch 13 implements handling of the #PERST signal
>  - Patch 14 adds a DT overlay file to enable EP mode and define the
>    PERST# GPIO (reset-gpios) property.
> 
> These patches were tested using a Pine Rockpro64 board used as an
> endpoint with the test endpoint function driver and a prototype nvme
> endpoint function driver.

Applied to controller/rockchip, thank you!

[01/13] PCI: rockchip-ep: Fix address translation unit programming
        https://git.kernel.org/pci/pci/c/289cd5c0db35

[02/13] PCI: rockchip-ep: Use a macro to define EP controller .align feature
        https://git.kernel.org/pci/pci/c/8ba3b41eb7ec

[03/13] PCI: rockchip-ep: Improve rockchip_pcie_ep_unmap_addr()
        https://git.kernel.org/pci/pci/c/db68baa5d884

[04/13] PCI: rockchip-ep: Improve rockchip_pcie_ep_map_addr()
        https://git.kernel.org/pci/pci/c/c5b097d2a295

[05/13] PCI: rockchip-ep: Implement the pci_epc_ops::align_addr() operation
        https://git.kernel.org/pci/pci/c/75b011d9006e

[06/13] PCI: rockchip-ep: Fix MSI IRQ data mapping
        https://git.kernel.org/pci/pci/c/42c55124c3b2

[07/13] PCI: rockchip-ep: Rename rockchip_pcie_parse_ep_dt()
        https://git.kernel.org/pci/pci/c/c8b915ec5338

[08/13] PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() memory allocations
        https://git.kernel.org/pci/pci/c/c0473caa87f1

[09/13] PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() MSI-X hiding
        https://git.kernel.org/pci/pci/c/48e848c8727c

[10/13] PCI: rockchip-ep: Refactor endpoint link training enable
        https://git.kernel.org/pci/pci/c/c6de5dd3fd0c

[11/13] PCI: rockship-ep: Implement the pci_epc_ops::stop_link() operation
        https://git.kernel.org/pci/pci/c/8a9424d83e20

	Krzysztof