Re: [PATCH v5 13/14] PCI: rockchip-ep: Handle PERST# signal in endpoint mode

From: Damien Le Moal <dlemoal@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Shawn Lin" <shawn.lin@rock-chips.com>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
	"Rick Wertenbroek" <rick.wertenbroek@gmail.com>,
	"Niklas Cassel" <cassel@kernel.org>
Subject: Re: [PATCH v5 13/14] PCI: rockchip-ep: Handle PERST# signal in endpoint mode
Date: Sun, 15 Dec 2024 11:09:49 +0900	[thread overview]
Message-ID: <35282804-9a4a-4272-9f39-e5ba443a0cbb@kernel.org> (raw)
In-Reply-To: <20241215001313.GA3482864@bhelgaas>

On 12/15/24 09:13, Bjorn Helgaas wrote:
> On Thu, Oct 17, 2024 at 10:58:48AM +0900, Damien Le Moal wrote:
>> Currently, the Rockchip PCIe endpoint controller driver does not handle
>> the PERST# signal, which prevents detecting when link training should
>> actually be started or if the host resets the device. This however can
>> be supported using the controller reset_gpios property set as an input
>> GPIO for endpoint mode.
> 
>> @@ -50,6 +51,9 @@ struct rockchip_pcie_ep {
>>  	u64			irq_pci_addr;
>>  	u8			irq_pci_fn;
>>  	u8			irq_pending;
>> +	int			perst_irq;
>> +	bool			perst_asserted;
>> +	bool			link_up;
>>  	struct delayed_work	link_training;
>>  };
> 
> I should have caught this last cycle, but just noticed this:
> 
>   $ make W=1 -k drivers/pci/ drivers/misc/pci_*
>   ...
>     CC      drivers/pci/controller/pcie-rockchip-ep.o
>   drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'perst_irq' not described in 'rockchip_pcie_ep'
>   drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'perst_asserted' not described in 'rockchip_pcie_ep'
>   drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'link_up' not described in 'rockchip_pcie_ep'
>   drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'link_training' not described in 'rockchip_pcie_ep'

Oops... Sending a fix.

-- 
Damien Le Moal
Western Digital Research