All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lothar Rubusch <l.rubusch@gmail.com>
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: l.rubusch@gmx.ch, Lothar Rubusch <l.rubusch@gmail.com>
Subject: [PATCH 17/22] iio: accel: adxl345: push FIFO data to iio
Date: Thu, 14 Nov 2024 23:09:57 +0000	[thread overview]
Message-ID: <20241114231002.98595-18-l.rubusch@gmail.com> (raw)
In-Reply-To: <20241114231002.98595-1-l.rubusch@gmail.com>

Add FIFO and hwfifo handling. Add some functions to deal with FIFO
entries and configuration. This feature will be needed for e.g.
watermark setting.

Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
---
 drivers/iio/accel/adxl345_core.c | 38 ++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/drivers/iio/accel/adxl345_core.c b/drivers/iio/accel/adxl345_core.c
index b917b02245..f686037df3 100644
--- a/drivers/iio/accel/adxl345_core.c
+++ b/drivers/iio/accel/adxl345_core.c
@@ -420,6 +420,41 @@ static int adxl345_get_status(struct adxl34x_state *st, u8 *int_stat)
 	return 0;
 }
 
+static int adxl345_push_fifo_data(struct iio_dev *indio_dev,
+				  u8 status,
+				  int fifo_entries)
+{
+	struct adxl34x_state *st = iio_priv(indio_dev);
+	int ndirs = 3; /* 3 directions */
+	int i, ret;
+
+	if (fifo_entries <= 0)
+		return true;
+
+	ret = adxl345_read_fifo_elements(st, fifo_entries);
+	if (ret)
+		return false;
+
+	for (i = 0; i < ndirs * fifo_entries; i += ndirs) {
+		/* To ensure that the FIFO has completely popped, there must be at least 5
+		 * us between the end of reading the data registers, signified by the
+		 * transition to register 0x38 from 0x37 or the CS pin going high, and the
+		 * start of new reads of the FIFO or reading the FIFO_STATUS register. For
+		 * SPI operation at 1.5 MHz or lower, the register addressing portion of the
+		 * transmission is sufficient delay to ensure the FIFO has completely
+		 * popped. It is necessary for SPI operation greater than 1.5 MHz to
+		 * de-assert the CS pin to ensure a total of 5 us, which is at most 3.4 us
+		 * at 5 MHz operation.
+		 */
+		if (st->fifo_delay && (fifo_entries > 1))
+			udelay(3);
+
+		iio_push_to_buffers(indio_dev, &st->fifo_buf[i]);
+	}
+
+	return true;
+}
+
 /* data ready trigger */
 
 static int adxl345_trig_dready(struct iio_trigger *trig, bool state)
@@ -492,6 +527,9 @@ static irqreturn_t adxl345_trigger_handler(int irq, void *p)
 		if (adxl345_get_fifo_entries(st, &fifo_entries) < 0)
 			goto err;
 
+		if (adxl345_push_fifo_data(indio_dev, int_stat, fifo_entries) < 0)
+			goto err;
+
 		iio_trigger_notify_done(indio_dev->trig);
 	}
 
-- 
2.39.2


  parent reply	other threads:[~2024-11-14 23:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14 23:09 [PATCH 00/22] iio: accel: adxl345: add FIFO operating with IRQ triggered watermark events Lothar Rubusch
2024-11-14 23:09 ` [PATCH 01/22] iio: accel: adxl345: fix comment on probe Lothar Rubusch
2024-11-14 23:09 ` [PATCH 02/22] iio: accel: adxl345: rename variable data to st Lothar Rubusch
2024-11-14 23:09 ` [PATCH 03/22] iio: accel: adxl345: rename struct adxl34x_state Lothar Rubusch
2024-11-14 23:09 ` [PATCH 04/22] iio: accel: adxl345: rename to adxl34x_channels Lothar Rubusch
2024-11-14 23:09 ` [PATCH 05/22] iio: accel: adxl345: measure right-justified Lothar Rubusch
2024-11-14 23:09 ` [PATCH 06/22] iio: accel: adxl345: add function to switch measuring Lothar Rubusch
2024-11-17  5:37   ` kernel test robot
2024-11-14 23:09 ` [PATCH 07/22] iio: accel: adxl345: initialize IRQ number Lothar Rubusch
2024-11-14 23:09 ` [PATCH 08/22] iio: accel: adxl345: initialize FIFO delay value for SPI Lothar Rubusch
2024-11-14 23:09 ` [PATCH 09/22] iio: accel: adxl345: unexpose private defines Lothar Rubusch
2024-11-14 23:09 ` [PATCH 10/22] iio: accel: adxl345: set interrupt line to INT1 Lothar Rubusch
2024-11-14 23:09 ` [PATCH 11/22] iio: accel: adxl345: import adxl345 general data Lothar Rubusch
2024-11-14 23:09 ` [PATCH 12/22] iio: accel: adxl345: elaborate iio channel definition Lothar Rubusch
2024-11-14 23:09 ` [PATCH 13/22] iio: accel: adxl345: add trigger handler Lothar Rubusch
2024-11-14 23:09 ` [PATCH 14/22] iio: accel: adxl345: read FIFO entries Lothar Rubusch
2024-11-14 23:09 ` [PATCH 15/22] iio: accel: adxl345: reset the FIFO on error Lothar Rubusch
2024-11-17  0:45   ` kernel test robot
2024-11-17  7:12   ` kernel test robot
2024-11-17 15:49   ` kernel test robot
2024-11-14 23:09 ` [PATCH 16/22] iio: accel: adxl345: register trigger ops Lothar Rubusch
2024-11-14 23:09 ` Lothar Rubusch [this message]
2024-11-14 23:09 ` [PATCH 18/22] iio: accel: adxl345: start measure at buffer en/disable Lothar Rubusch
2024-11-14 23:09 ` [PATCH 19/22] iio: accel: adxl345: prepare FIFO watermark handling Lothar Rubusch
2024-11-14 23:10 ` [PATCH 20/22] iio: accel: adxl345: use FIFO with watermark IRQ Lothar Rubusch
2024-11-14 23:10 ` [PATCH 21/22] iio: accel: adxl345: sync FIFO reading with sensor Lothar Rubusch
2024-11-14 23:10 ` [PATCH 22/22] iio: accel: adxl345: add debug printout Lothar Rubusch
2024-11-17 18:35   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241114231002.98595-18-l.rubusch@gmail.com \
    --to=l.rubusch@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=jic23@kernel.org \
    --cc=l.rubusch@gmx.ch \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.