All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@kernel.org>
To: ltp@lists.linux.it
Cc: linux-btrfs@vger.kernel.org, zlang@redhat.com
Subject: [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero
Date: Sun,  1 Dec 2024 17:36:04 +0800	[thread overview]
Message-ID: <20241201093606.68993-2-zlang@kernel.org> (raw)
In-Reply-To: <20241201093606.68993-1-zlang@kernel.org>

This test need to skip test known filesystems, but according to below
code logic (in lib/tst_test.c):

  if (!tst_test->all_filesystems && tst_test->skip_filesystems) {
        long fs_type = tst_fs_type(".");
        const char *fs_name = tst_fs_type_name(fs_type);

        if (tst_fs_in_skiplist(fs_name, tst_test->skip_filesystems)) {
            tst_brk(TCONF, "%s is not supported by the test",
            fs_name);
        }

        tst_res(TINFO, "%s is supported by the test", fs_name);
  }

if all_filesystems is 1, the skip_filesystems doesn't work. So set
all_filesystems to 0.

Signed-off-by: Zorro Lang <zlang@kernel.org>
---
 testcases/kernel/syscalls/ioctl/ioctl_ficlone02.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ficlone02.c b/testcases/kernel/syscalls/ioctl/ioctl_ficlone02.c
index fab0daaee..b7f676ec7 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_ficlone02.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_ficlone02.c
@@ -57,7 +57,7 @@ static struct tst_test test = {
 	.needs_root = 1,
 	.mount_device = 1,
 	.mntpoint = MNTPOINT,
-	.all_filesystems = 1,
+	.all_filesystems = 0,
 	.skip_filesystems = (const char *[]) {
 		"bcachefs",
 		"btrfs",
-- 
2.45.2


WARNING: multiple messages have this Message-ID (diff)
From: Zorro Lang via ltp <ltp@lists.linux.it>
To: ltp@lists.linux.it
Cc: linux-btrfs@vger.kernel.org
Subject: [LTP] [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero
Date: Sun,  1 Dec 2024 17:36:04 +0800	[thread overview]
Message-ID: <20241201093606.68993-2-zlang@kernel.org> (raw)
In-Reply-To: <20241201093606.68993-1-zlang@kernel.org>

This test need to skip test known filesystems, but according to below
code logic (in lib/tst_test.c):

  if (!tst_test->all_filesystems && tst_test->skip_filesystems) {
        long fs_type = tst_fs_type(".");
        const char *fs_name = tst_fs_type_name(fs_type);

        if (tst_fs_in_skiplist(fs_name, tst_test->skip_filesystems)) {
            tst_brk(TCONF, "%s is not supported by the test",
            fs_name);
        }

        tst_res(TINFO, "%s is supported by the test", fs_name);
  }

if all_filesystems is 1, the skip_filesystems doesn't work. So set
all_filesystems to 0.

Signed-off-by: Zorro Lang <zlang@kernel.org>
---
 testcases/kernel/syscalls/ioctl/ioctl_ficlone02.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ficlone02.c b/testcases/kernel/syscalls/ioctl/ioctl_ficlone02.c
index fab0daaee..b7f676ec7 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_ficlone02.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_ficlone02.c
@@ -57,7 +57,7 @@ static struct tst_test test = {
 	.needs_root = 1,
 	.mount_device = 1,
 	.mntpoint = MNTPOINT,
-	.all_filesystems = 1,
+	.all_filesystems = 0,
 	.skip_filesystems = (const char *[]) {
 		"bcachefs",
 		"btrfs",
-- 
2.45.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-12-01  9:36 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-01  9:36 [PATCH 0/3] LTP random fixes for xfs and btrfs Zorro Lang
2024-12-01  9:36 ` [LTP] " Zorro Lang via ltp
2024-12-01  9:36 ` Zorro Lang [this message]
2024-12-01  9:36   ` [LTP] [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero Zorro Lang via ltp
2024-12-02 13:36   ` Cyril Hrubis
2024-12-02 13:36     ` Cyril Hrubis
2024-12-02 13:59     ` Cyril Hrubis
2024-12-02 13:59       ` Cyril Hrubis
2024-12-02 14:42       ` Petr Vorel
2024-12-02 14:42         ` Petr Vorel
2024-12-02 15:23         ` Cyril Hrubis
2024-12-02 15:23           ` Cyril Hrubis
2024-12-03  4:53           ` Petr Vorel
2024-12-03  4:53             ` Petr Vorel
2024-12-03  7:58             ` Cyril Hrubis
2024-12-03  7:58               ` Cyril Hrubis
2024-12-03  9:24               ` Petr Vorel
2024-12-03  9:24                 ` Petr Vorel
2024-12-09  5:53         ` Zorro Lang
2024-12-09  5:53           ` Zorro Lang via ltp
2024-12-09  6:14           ` Petr Vorel
2024-12-09  6:14             ` Petr Vorel
2024-12-09  9:49             ` Zorro Lang via ltp
2024-12-09 10:42               ` Petr Vorel
2024-12-09 11:34               ` Petr Vorel
2024-12-11 12:08             ` Cyril Hrubis
2024-12-11 12:08               ` Cyril Hrubis
2024-12-11 19:40               ` Petr Vorel
2024-12-11 19:40                 ` Petr Vorel
2024-12-01  9:36 ` [PATCH 2/3] stat04+lstat03: fix bad blocksize mkfs option for xfs Zorro Lang
2024-12-01  9:36   ` [LTP] " Zorro Lang via ltp
2024-12-02 13:56   ` Cyril Hrubis
2024-12-02 13:56     ` Cyril Hrubis
2024-12-01  9:36 ` [PATCH 3/3] stat04+lstat03: skip test on btrfs Zorro Lang
2024-12-01  9:36   ` [LTP] " Zorro Lang via ltp
2024-12-02 13:55   ` Cyril Hrubis
2024-12-02 13:55     ` Cyril Hrubis
2024-12-01  9:55 ` [PATCH 0/3] LTP random fixes for xfs and btrfs Qu Wenruo
2024-12-01  9:55   ` [LTP] " Qu Wenruo via ltp
2024-12-03 16:22   ` David Sterba
2024-12-03 16:22     ` [LTP] " David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241201093606.68993-2-zlang@kernel.org \
    --to=zlang@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=ltp@lists.linux.it \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.