From: Cyril Hrubis <chrubis@suse.cz>
To: Zorro Lang <zlang@kernel.org>
Cc: ltp@lists.linux.it, linux-btrfs@vger.kernel.org
Subject: Re: [LTP] [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero
Date: Mon, 2 Dec 2024 14:36:31 +0100 [thread overview]
Message-ID: <Z02337yqxrfeZxIn@yuki.lan> (raw)
In-Reply-To: <20241201093606.68993-2-zlang@kernel.org>
Hi!
> This test need to skip test known filesystems, but according to below
> code logic (in lib/tst_test.c):
>
> if (!tst_test->all_filesystems && tst_test->skip_filesystems) {
> long fs_type = tst_fs_type(".");
> const char *fs_name = tst_fs_type_name(fs_type);
>
> if (tst_fs_in_skiplist(fs_name, tst_test->skip_filesystems)) {
> tst_brk(TCONF, "%s is not supported by the test",
> fs_name);
> }
>
> tst_res(TINFO, "%s is supported by the test", fs_name);
> }
>
> if all_filesystems is 1, the skip_filesystems doesn't work. So set
> all_filesystems to 0.
The code to skip filesystems in the case of all filesystems is in the
run_tcase_per_fs() function:
static int run_tcases_per_fs(void)
{
int ret = 0;
unsigned int i;
const char *const *filesystems = tst_get_supported_fs_types(tst_test->skip_filesystems);
The skip_filesystems array is passed to the tst_get_supporte_fs_types()
function which filters out them.
--
Cyril Hrubis
chrubis@suse.cz
WARNING: multiple messages have this Message-ID (diff)
From: Cyril Hrubis <chrubis@suse.cz>
To: Zorro Lang <zlang@kernel.org>
Cc: linux-btrfs@vger.kernel.org, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero
Date: Mon, 2 Dec 2024 14:36:31 +0100 [thread overview]
Message-ID: <Z02337yqxrfeZxIn@yuki.lan> (raw)
In-Reply-To: <20241201093606.68993-2-zlang@kernel.org>
Hi!
> This test need to skip test known filesystems, but according to below
> code logic (in lib/tst_test.c):
>
> if (!tst_test->all_filesystems && tst_test->skip_filesystems) {
> long fs_type = tst_fs_type(".");
> const char *fs_name = tst_fs_type_name(fs_type);
>
> if (tst_fs_in_skiplist(fs_name, tst_test->skip_filesystems)) {
> tst_brk(TCONF, "%s is not supported by the test",
> fs_name);
> }
>
> tst_res(TINFO, "%s is supported by the test", fs_name);
> }
>
> if all_filesystems is 1, the skip_filesystems doesn't work. So set
> all_filesystems to 0.
The code to skip filesystems in the case of all filesystems is in the
run_tcase_per_fs() function:
static int run_tcases_per_fs(void)
{
int ret = 0;
unsigned int i;
const char *const *filesystems = tst_get_supported_fs_types(tst_test->skip_filesystems);
The skip_filesystems array is passed to the tst_get_supporte_fs_types()
function which filters out them.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-12-02 13:36 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-01 9:36 [PATCH 0/3] LTP random fixes for xfs and btrfs Zorro Lang
2024-12-01 9:36 ` [LTP] " Zorro Lang via ltp
2024-12-01 9:36 ` [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero Zorro Lang
2024-12-01 9:36 ` [LTP] " Zorro Lang via ltp
2024-12-02 13:36 ` Cyril Hrubis [this message]
2024-12-02 13:36 ` Cyril Hrubis
2024-12-02 13:59 ` Cyril Hrubis
2024-12-02 13:59 ` Cyril Hrubis
2024-12-02 14:42 ` Petr Vorel
2024-12-02 14:42 ` Petr Vorel
2024-12-02 15:23 ` Cyril Hrubis
2024-12-02 15:23 ` Cyril Hrubis
2024-12-03 4:53 ` Petr Vorel
2024-12-03 4:53 ` Petr Vorel
2024-12-03 7:58 ` Cyril Hrubis
2024-12-03 7:58 ` Cyril Hrubis
2024-12-03 9:24 ` Petr Vorel
2024-12-03 9:24 ` Petr Vorel
2024-12-09 5:53 ` Zorro Lang
2024-12-09 5:53 ` Zorro Lang via ltp
2024-12-09 6:14 ` Petr Vorel
2024-12-09 6:14 ` Petr Vorel
2024-12-09 9:49 ` Zorro Lang via ltp
2024-12-09 10:42 ` Petr Vorel
2024-12-09 11:34 ` Petr Vorel
2024-12-11 12:08 ` Cyril Hrubis
2024-12-11 12:08 ` Cyril Hrubis
2024-12-11 19:40 ` Petr Vorel
2024-12-11 19:40 ` Petr Vorel
2024-12-01 9:36 ` [PATCH 2/3] stat04+lstat03: fix bad blocksize mkfs option for xfs Zorro Lang
2024-12-01 9:36 ` [LTP] " Zorro Lang via ltp
2024-12-02 13:56 ` Cyril Hrubis
2024-12-02 13:56 ` Cyril Hrubis
2024-12-01 9:36 ` [PATCH 3/3] stat04+lstat03: skip test on btrfs Zorro Lang
2024-12-01 9:36 ` [LTP] " Zorro Lang via ltp
2024-12-02 13:55 ` Cyril Hrubis
2024-12-02 13:55 ` Cyril Hrubis
2024-12-01 9:55 ` [PATCH 0/3] LTP random fixes for xfs and btrfs Qu Wenruo
2024-12-01 9:55 ` [LTP] " Qu Wenruo via ltp
2024-12-03 16:22 ` David Sterba
2024-12-03 16:22 ` [LTP] " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z02337yqxrfeZxIn@yuki.lan \
--to=chrubis@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.