From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Zorro Lang <zlang@kernel.org>,
ltp@lists.linux.it, linux-btrfs@vger.kernel.org
Subject: Re: [LTP] [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero
Date: Tue, 3 Dec 2024 05:53:10 +0100 [thread overview]
Message-ID: <20241203045310.GA414034@pevik> (raw)
In-Reply-To: <Z03RB9JDmBVORPlf@yuki.lan>
> Hi!
> > It's a nice feature to be able to force testing on filesystem even it's set to
> > be skipped without need to manually enable the filesystem and recompile.
> > (It helps testing with LTP compiled as a package without need to compile LTP.)
> > Therefore I would avoid this.
> I guess that this should be another env variable e.g.
> LTP_FORCE_SINGLE_FS_TYPE and it should print a big fat warning that it's
> only for development purposes.
Well, LTP_SINGLE_FS_TYPE already has "Testing only" and that was the reason it
just forced filesystem regardless "skip" setup. Sure, we can turn it into
"normal" variable and introduce LTP_FORCE_SINGLE_FS_TYPE if it's needed.
But that would be an use case if anybody uses LTP really to test particular
filesystem. And it would affect only .all_filesystem tests (e.g. user's
responsibility would be to point TMPDIR to that particular system on non-
.all_filesystem tests).
@Zorro was it meant like this?
Kind regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: linux-btrfs@vger.kernel.org, Zorro Lang <zlang@kernel.org>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero
Date: Tue, 3 Dec 2024 05:53:10 +0100 [thread overview]
Message-ID: <20241203045310.GA414034@pevik> (raw)
In-Reply-To: <Z03RB9JDmBVORPlf@yuki.lan>
> Hi!
> > It's a nice feature to be able to force testing on filesystem even it's set to
> > be skipped without need to manually enable the filesystem and recompile.
> > (It helps testing with LTP compiled as a package without need to compile LTP.)
> > Therefore I would avoid this.
> I guess that this should be another env variable e.g.
> LTP_FORCE_SINGLE_FS_TYPE and it should print a big fat warning that it's
> only for development purposes.
Well, LTP_SINGLE_FS_TYPE already has "Testing only" and that was the reason it
just forced filesystem regardless "skip" setup. Sure, we can turn it into
"normal" variable and introduce LTP_FORCE_SINGLE_FS_TYPE if it's needed.
But that would be an use case if anybody uses LTP really to test particular
filesystem. And it would affect only .all_filesystem tests (e.g. user's
responsibility would be to point TMPDIR to that particular system on non-
.all_filesystem tests).
@Zorro was it meant like this?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-12-03 4:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-01 9:36 [PATCH 0/3] LTP random fixes for xfs and btrfs Zorro Lang
2024-12-01 9:36 ` [LTP] " Zorro Lang via ltp
2024-12-01 9:36 ` [PATCH 1/3] ioctl_ficlone02.c: set all_filesystems to zero Zorro Lang
2024-12-01 9:36 ` [LTP] " Zorro Lang via ltp
2024-12-02 13:36 ` Cyril Hrubis
2024-12-02 13:36 ` Cyril Hrubis
2024-12-02 13:59 ` Cyril Hrubis
2024-12-02 13:59 ` Cyril Hrubis
2024-12-02 14:42 ` Petr Vorel
2024-12-02 14:42 ` Petr Vorel
2024-12-02 15:23 ` Cyril Hrubis
2024-12-02 15:23 ` Cyril Hrubis
2024-12-03 4:53 ` Petr Vorel [this message]
2024-12-03 4:53 ` Petr Vorel
2024-12-03 7:58 ` Cyril Hrubis
2024-12-03 7:58 ` Cyril Hrubis
2024-12-03 9:24 ` Petr Vorel
2024-12-03 9:24 ` Petr Vorel
2024-12-09 5:53 ` Zorro Lang
2024-12-09 5:53 ` Zorro Lang via ltp
2024-12-09 6:14 ` Petr Vorel
2024-12-09 6:14 ` Petr Vorel
2024-12-09 9:49 ` Zorro Lang via ltp
2024-12-09 10:42 ` Petr Vorel
2024-12-09 11:34 ` Petr Vorel
2024-12-11 12:08 ` Cyril Hrubis
2024-12-11 12:08 ` Cyril Hrubis
2024-12-11 19:40 ` Petr Vorel
2024-12-11 19:40 ` Petr Vorel
2024-12-01 9:36 ` [PATCH 2/3] stat04+lstat03: fix bad blocksize mkfs option for xfs Zorro Lang
2024-12-01 9:36 ` [LTP] " Zorro Lang via ltp
2024-12-02 13:56 ` Cyril Hrubis
2024-12-02 13:56 ` Cyril Hrubis
2024-12-01 9:36 ` [PATCH 3/3] stat04+lstat03: skip test on btrfs Zorro Lang
2024-12-01 9:36 ` [LTP] " Zorro Lang via ltp
2024-12-02 13:55 ` Cyril Hrubis
2024-12-02 13:55 ` Cyril Hrubis
2024-12-01 9:55 ` [PATCH 0/3] LTP random fixes for xfs and btrfs Qu Wenruo
2024-12-01 9:55 ` [LTP] " Qu Wenruo via ltp
2024-12-03 16:22 ` David Sterba
2024-12-03 16:22 ` [LTP] " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203045310.GA414034@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.