From: Simon Horman <horms@kernel.org>
To: Grzegorz Nitka <grzegorz.nitka@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
Karol Kolacinski <karol.kolacinski@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 2/3] ice: Refactor E825C PHY registers info struct
Date: Fri, 7 Feb 2025 10:05:43 +0000 [thread overview]
Message-ID: <20250207100543.GL554665@kernel.org> (raw)
In-Reply-To: <20250207100345.GK554665@kernel.org>
On Fri, Feb 07, 2025 at 10:03:45AM +0000, Simon Horman wrote:
> On Thu, Feb 06, 2025 at 09:36:54AM +0100, Grzegorz Nitka wrote:
> > From: Karol Kolacinski <karol.kolacinski@intel.com>
> >
> > Simplify ice_phy_reg_info_eth56g struct definition to include base
> > address for the very first quad. Use base address info and 'step'
> > value to determine address for specific PHY quad.
> >
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> > Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> > Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
>
> Reviewed-by: Simon Horman <horms@kernel.org>
Sorry, I failed to notice that the kdoc for ice_phy_reg_info_eth56g
needs to be updated to document base_addr instead of base.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Grzegorz Nitka <grzegorz.nitka@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
Karol Kolacinski <karol.kolacinski@intel.com>
Subject: Re: [PATCH iwl-next v1 2/3] ice: Refactor E825C PHY registers info struct
Date: Fri, 7 Feb 2025 10:05:43 +0000 [thread overview]
Message-ID: <20250207100543.GL554665@kernel.org> (raw)
In-Reply-To: <20250207100345.GK554665@kernel.org>
On Fri, Feb 07, 2025 at 10:03:45AM +0000, Simon Horman wrote:
> On Thu, Feb 06, 2025 at 09:36:54AM +0100, Grzegorz Nitka wrote:
> > From: Karol Kolacinski <karol.kolacinski@intel.com>
> >
> > Simplify ice_phy_reg_info_eth56g struct definition to include base
> > address for the very first quad. Use base address info and 'step'
> > value to determine address for specific PHY quad.
> >
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> > Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> > Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
>
> Reviewed-by: Simon Horman <horms@kernel.org>
Sorry, I failed to notice that the kdoc for ice_phy_reg_info_eth56g
needs to be updated to document base_addr instead of base.
next prev parent reply other threads:[~2025-02-07 10:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 8:36 [Intel-wired-lan] [PATCH iwl-next v1 0/3] E825C PTP cleanup Grzegorz Nitka
2025-02-06 8:36 ` Grzegorz Nitka
2025-02-06 8:36 ` [Intel-wired-lan] [PATCH iwl-next v1 1/3] ice: Add sync delay for E825C Grzegorz Nitka
2025-02-06 8:36 ` Grzegorz Nitka
2025-02-07 10:03 ` [Intel-wired-lan] " Simon Horman
2025-02-07 10:03 ` Simon Horman
2025-02-10 10:54 ` [Intel-wired-lan] " Nitka, Grzegorz
2025-02-10 10:54 ` Nitka, Grzegorz
2025-02-06 8:36 ` [Intel-wired-lan] [PATCH iwl-next v1 2/3] ice: Refactor E825C PHY registers info struct Grzegorz Nitka
2025-02-06 8:36 ` Grzegorz Nitka
2025-02-07 10:03 ` [Intel-wired-lan] " Simon Horman
2025-02-07 10:03 ` Simon Horman
2025-02-07 10:05 ` Simon Horman [this message]
2025-02-07 10:05 ` Simon Horman
2025-02-10 11:05 ` [Intel-wired-lan] " Nitka, Grzegorz
2025-02-10 11:05 ` Nitka, Grzegorz
2025-02-06 8:36 ` [Intel-wired-lan] [PATCH iwl-next v1 3/3] ice: E825C PHY register cleanup Grzegorz Nitka
2025-02-06 8:36 ` Grzegorz Nitka
2025-02-07 10:07 ` [Intel-wired-lan] " Simon Horman
2025-02-07 10:07 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250207100543.GL554665@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=grzegorz.nitka@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=karol.kolacinski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.