From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: intel-wired-lan@lists.osuosl.org,
Michal Kubiak <michal.kubiak@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Simon Horman <horms@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 11/16] idpf: prepare structures to support XDP
Date: Thu, 6 Mar 2025 17:12:08 -0800 [thread overview]
Message-ID: <20250306171208.3162eb97@kernel.org> (raw)
In-Reply-To: <20250305162132.1106080-12-aleksander.lobakin@intel.com>
On Wed, 5 Mar 2025 17:21:27 +0100 Alexander Lobakin wrote:
> +/**
> + * idpf_xdp_is_prog_ena - check if there is an XDP program on adapter
> + * @vport: vport to check
> + */
> +static inline bool idpf_xdp_is_prog_ena(const struct idpf_vport *vport)
> +{
> + return vport->adapter && vport->xdp_prog;
> +}
drivers/net/ethernet/intel/idpf/idpf.h:624: warning: No description found for return value of 'idpf_xdp_is_prog_ena'
The documentation doesn't add much info, just remove it ?
--
pw-bot: cr
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: intel-wired-lan@lists.osuosl.org,
Michal Kubiak <michal.kubiak@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Simon Horman <horms@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net-next 11/16] idpf: prepare structures to support XDP
Date: Thu, 6 Mar 2025 17:12:08 -0800 [thread overview]
Message-ID: <20250306171208.3162eb97@kernel.org> (raw)
In-Reply-To: <20250305162132.1106080-12-aleksander.lobakin@intel.com>
On Wed, 5 Mar 2025 17:21:27 +0100 Alexander Lobakin wrote:
> +/**
> + * idpf_xdp_is_prog_ena - check if there is an XDP program on adapter
> + * @vport: vport to check
> + */
> +static inline bool idpf_xdp_is_prog_ena(const struct idpf_vport *vport)
> +{
> + return vport->adapter && vport->xdp_prog;
> +}
drivers/net/ethernet/intel/idpf/idpf.h:624: warning: No description found for return value of 'idpf_xdp_is_prog_ena'
The documentation doesn't add much info, just remove it ?
--
pw-bot: cr
next prev parent reply other threads:[~2025-03-07 1:12 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 16:21 [PATCH net-next 00/16] idpf: add XDP support Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 01/16] libeth: convert to netmem Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-06 0:13 ` Mina Almasry
2025-03-06 0:13 ` [Intel-wired-lan] " Mina Almasry
2025-03-11 17:22 ` Alexander Lobakin
2025-03-11 17:22 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-11 17:43 ` Mina Almasry
2025-03-11 17:43 ` [Intel-wired-lan] " Mina Almasry
2025-03-05 16:21 ` [PATCH net-next 02/16] libeth: support native XDP and register memory model Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 03/16] libeth: add a couple of XDP helpers (libeth_xdp) Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-11 14:05 ` Maciej Fijalkowski
2025-03-11 14:05 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-17 15:26 ` Alexander Lobakin
2025-03-17 15:26 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-19 16:19 ` Maciej Fijalkowski
2025-03-19 16:19 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-04-01 13:11 ` Alexander Lobakin
2025-04-01 13:11 ` [Intel-wired-lan] " Alexander Lobakin
2025-04-08 13:38 ` Alexander Lobakin
2025-04-08 13:38 ` [Intel-wired-lan] " Alexander Lobakin
2025-04-08 13:22 ` Alexander Lobakin
2025-04-08 13:22 ` [Intel-wired-lan] " Alexander Lobakin
2025-04-08 13:51 ` Alexander Lobakin
2025-04-08 13:51 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 04/16] libeth: add XSk helpers Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-07 10:15 ` Maciej Fijalkowski
2025-03-07 10:15 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-12 17:03 ` Alexander Lobakin
2025-03-12 17:03 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 05/16] idpf: fix Rx descriptor ready check barrier in splitq Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-07 10:17 ` Maciej Fijalkowski
2025-03-07 10:17 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-12 17:10 ` Alexander Lobakin
2025-03-12 17:10 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 06/16] idpf: a use saner limit for default number of queues to allocate Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-07 10:32 ` Maciej Fijalkowski
2025-03-07 10:32 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-12 17:22 ` Alexander Lobakin
2025-03-12 17:22 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 07/16] idpf: link NAPIs to queues Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-07 10:28 ` Eric Dumazet
2025-03-07 10:28 ` [Intel-wired-lan] " Eric Dumazet
2025-03-12 17:16 ` Alexander Lobakin
2025-03-12 17:16 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-18 17:10 ` Alexander Lobakin
2025-03-18 17:10 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-07 10:51 ` Maciej Fijalkowski
2025-03-07 10:51 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-12 17:25 ` Alexander Lobakin
2025-03-12 17:25 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 08/16] idpf: make complq cleaning dependent on scheduling mode Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-07 11:11 ` Maciej Fijalkowski
2025-03-07 11:11 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-13 16:16 ` Alexander Lobakin
2025-03-13 16:16 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 09/16] idpf: remove SW marker handling from NAPI Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-07 11:42 ` Maciej Fijalkowski
2025-03-07 11:42 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-13 16:50 ` Alexander Lobakin
2025-03-13 16:50 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 10/16] idpf: add support for nointerrupt queues Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-07 12:10 ` Maciej Fijalkowski
2025-03-07 12:10 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-13 16:19 ` Alexander Lobakin
2025-03-13 16:19 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 11/16] idpf: prepare structures to support XDP Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-07 1:12 ` Jakub Kicinski [this message]
2025-03-07 1:12 ` Jakub Kicinski
2025-03-12 14:00 ` Alexander Lobakin
2025-03-07 13:27 ` Maciej Fijalkowski
2025-03-07 13:27 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-17 14:50 ` Alexander Lobakin
2025-03-17 14:50 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-19 16:29 ` Maciej Fijalkowski
2025-03-19 16:29 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-04-08 13:42 ` Alexander Lobakin
2025-04-08 13:42 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 12/16] idpf: implement XDP_SETUP_PROG in ndo_bpf for splitq Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-07 14:16 ` Maciej Fijalkowski
2025-03-07 14:16 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-17 14:58 ` Alexander Lobakin
2025-03-17 14:58 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-19 16:23 ` Maciej Fijalkowski
2025-03-19 16:23 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-05 16:21 ` [PATCH net-next 13/16] idpf: use generic functions to build xdp_buff and skb Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 14/16] idpf: add support for XDP on Rx Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-11 15:50 ` Maciej Fijalkowski
2025-03-11 15:50 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-04-08 13:28 ` Alexander Lobakin
2025-04-08 13:28 ` [Intel-wired-lan] " Alexander Lobakin
2025-04-08 15:53 ` Maciej Fijalkowski
2025-04-08 15:53 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-03-05 16:21 ` [PATCH net-next 15/16] idpf: add support for .ndo_xdp_xmit() Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-11 16:08 ` Maciej Fijalkowski
2025-03-11 16:08 ` [Intel-wired-lan] " Maciej Fijalkowski
2025-04-08 13:31 ` Alexander Lobakin
2025-04-08 13:31 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-05 16:21 ` [PATCH net-next 16/16] idpf: add XDP RSS hash hint Alexander Lobakin
2025-03-05 16:21 ` [Intel-wired-lan] " Alexander Lobakin
2025-03-11 15:28 ` [PATCH net-next 00/16] idpf: add XDP support Alexander Lobakin
2025-03-11 15:28 ` [Intel-wired-lan] " Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306171208.3162eb97@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.