All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 6/8] lib: sbi_hart: reset mstateen0
Date: Tue, 15 Apr 2025 15:19:07 +0200	[thread overview]
Message-ID: <20250415131908.2699782-8-rkrcmar@ventanamicro.com> (raw)
In-Reply-To: <20250415131908.2699782-2-rkrcmar@ventanamicro.com>

The current logic clears some bits based on SBI known extensions.
Be safe and do not leave enabled anything that SBI doesn't control.

This is not a breaking change, because the register must be initialized
to 0 by the ISA on reset, but it is better to not depend on it when we
don't need to.

Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
---
 lib/sbi/sbi_hart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c
index b209f1cab27d..569f8008b523 100644
--- a/lib/sbi/sbi_hart.c
+++ b/lib/sbi/sbi_hart.c
@@ -89,7 +89,7 @@ static void mstatus_init(struct sbi_scratch *scratch)
 		csr_write(CSR_HSTATUS, 0);
 
 	if (sbi_hart_has_extension(scratch, SBI_HART_EXT_SMSTATEEN)) {
-		mstateen_val = csr_read64(CSR_MSTATEEN0);
+		mstateen_val = 0;
 		mstateen_val |= SMSTATEEN_STATEN;
 		mstateen_val |= SMSTATEEN0_CONTEXT;
 		mstateen_val |= SMSTATEEN0_HSENVCFG;
-- 
2.48.1


-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi

  parent reply	other threads:[~2025-04-15 14:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 13:19 [PATCH 0/8] Reset more security-related CSRs Radim Krčmář
2025-04-15 13:19 ` [PATCH 1/8] lib: sbi: add 64 bit csr macros Radim Krčmář
2025-04-28 12:28   ` Anup Patel
2025-04-28 13:48     ` Radim Krčmář
2025-04-15 13:19 ` [PATCH 2/8] lib: sbi: use " Radim Krčmář
2025-04-28 12:29   ` Anup Patel
2025-04-15 13:19 ` [PATCH 3/8] lib: sbi_hart: reset hstatus Radim Krčmář
2025-04-28 12:27   ` Anup Patel
2025-04-15 13:19 ` [PATCH 4/8] lib: sbi_hart: reset sstateen and hstateen Radim Krčmář
2025-04-28 12:29   ` Anup Patel
2025-04-15 13:19 ` [PATCH 5/8] lib: sbi_hart: fix sstateen emulation Radim Krčmář
2025-04-28 12:34   ` Anup Patel
2025-04-15 13:19 ` Radim Krčmář [this message]
2025-04-28 12:35   ` [PATCH 6/8] lib: sbi_hart: reset mstateen0 Anup Patel
2025-04-15 13:19 ` [PATCH 7/8] lib: sbi_hart: add Ssstateen extension Radim Krčmář
2025-04-28 12:38   ` Anup Patel
2025-04-28 13:47     ` Radim Krčmář
2025-04-29  5:30       ` Anup Patel
2025-04-15 13:19 ` [PATCH 8/8] lib: sbi_hart: properly reset Ssstateen Radim Krčmář
2025-04-28 12:39   ` Anup Patel
2025-04-28 13:44     ` Radim Krčmář
2025-04-28 12:41 ` [PATCH 0/8] Reset more security-related CSRs Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250415131908.2699782-8-rkrcmar@ventanamicro.com \
    --to=rkrcmar@ventanamicro.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.