Re: [PATCH 8/8] lib: sbi_hart: properly reset Ssstateen

From: "Radim Krčmář" <rkrcmar@ventanamicro.com>
To: "Anup Patel" <anup@brainfault.org>
Cc: <opensbi@lists.infradead.org>
Subject: Re: [PATCH 8/8] lib: sbi_hart: properly reset Ssstateen
Date: Mon, 28 Apr 2025 15:44:53 +0200	[thread overview]
Message-ID: <D9IBFEASD5JP.1ISQR5MP8X452@ventanamicro.com> (raw)
In-Reply-To: <CAAhSdy1P3apLpKOzW4YSpHGN-PQGokaCMsotOb6LubZoavExNg@mail.gmail.com>

2025-04-28T18:09:47+05:30, Anup Patel <anup@brainfault.org>:
> On Tue, Apr 15, 2025 at 8:13 PM Radim Krčmář <rkrcmar@ventanamicro.com> wrote:
>>
>> sstateen* and hstateen* CSRs must be zeroed by M-mode if the mstateen*
>> registers are missing, to avoid security issues.
>>
>> Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
>> ---
>> diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c
>> @@ -114,12 +114,22 @@ static void mstatus_init(struct sbi_scratch *scratch)
>>                 csr_write64(CSR_MSTATEEN1, SMSTATEEN_STATEN);
>>                 csr_write64(CSR_MSTATEEN2, SMSTATEEN_STATEN);
>>                 csr_write64(CSR_MSTATEEN3, SMSTATEEN_STATEN);
>> +       }
>>
>> -               if (misa_extension('S'))
>> +       if (sbi_hart_has_extension(scratch, SBI_HART_EXT_SMSTATEEN) ||
>> +           sbi_hart_has_extension(scratch, SBI_HART_EXT_SSSTATEEN)) {
>
> This should only check SSSTATEEEN.

Right, Smstateen implies Ssstateen, thanks.

-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi