From: Ard Biesheuvel <ardb+git@google.com>
To: linux-kernel@vger.kernel.org
Cc: linux-efi@vger.kernel.org, x86@kernel.org,
Ard Biesheuvel <ardb@kernel.org>, Borislav Petkov <bp@alien8.de>,
Ingo Molnar <mingo@kernel.org>,
Dionna Amalie Glaze <dionnaglaze@google.com>,
Kevin Loughlin <kevinloughlin@google.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: [RFT PATCH v3 04/21] x86/sev: Run RMPADJUST on SVSM calling area page to test VMPL
Date: Mon, 12 May 2025 21:08:39 +0200 [thread overview]
Message-ID: <20250512190834.332684-27-ardb+git@google.com> (raw)
In-Reply-To: <20250512190834.332684-23-ardb+git@google.com>
From: Ard Biesheuvel <ardb@kernel.org>
Determining the VMPL at which the kernel runs involves performing a
RMPADJUST operation on an arbitary page of memory, and observing whether
it succeeds.
The use of boot_ghcb_page in the core kernel in this case is completely
arbitary, but results in the need to provide a PIC alias for it. So use
boot_svsm_ca_page instead, which already needs this alias for other
reasons.
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
arch/x86/boot/compressed/sev.c | 2 +-
arch/x86/boot/startup/sev-shared.c | 5 +++--
arch/x86/boot/startup/sev-startup.c | 2 +-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
index bc4ec45d9935..2141936daba7 100644
--- a/arch/x86/boot/compressed/sev.c
+++ b/arch/x86/boot/compressed/sev.c
@@ -327,7 +327,7 @@ static bool early_snp_init(struct boot_params *bp)
* running at VMPL0. The CA will be used to communicate with the
* SVSM and request its services.
*/
- svsm_setup_ca(cc_info);
+ svsm_setup_ca(cc_info, rip_rel_ptr(&boot_ghcb_page));
/*
* Pass run-time kernel a pointer to CC info via boot_params so EFI
diff --git a/arch/x86/boot/startup/sev-shared.c b/arch/x86/boot/startup/sev-shared.c
index 297d2abe8e3d..9c8dd6bfe833 100644
--- a/arch/x86/boot/startup/sev-shared.c
+++ b/arch/x86/boot/startup/sev-shared.c
@@ -782,7 +782,8 @@ static void __head pvalidate_4k_page(unsigned long vaddr, unsigned long paddr,
* Maintain the GPA of the SVSM Calling Area (CA) in order to utilize the SVSM
* services needed when not running in VMPL0.
*/
-static bool __head svsm_setup_ca(const struct cc_blob_sev_info *cc_info)
+static bool __head svsm_setup_ca(const struct cc_blob_sev_info *cc_info,
+ void *page)
{
struct snp_secrets_page *secrets_page;
struct snp_cpuid_table *cpuid_table;
@@ -805,7 +806,7 @@ static bool __head svsm_setup_ca(const struct cc_blob_sev_info *cc_info)
* routine is running identity mapped when called, both by the decompressor
* code and the early kernel code.
*/
- if (!rmpadjust((unsigned long)rip_rel_ptr(&boot_ghcb_page), RMP_PG_SIZE_4K, 1))
+ if (!rmpadjust((unsigned long)page, RMP_PG_SIZE_4K, 1))
return false;
/*
diff --git a/arch/x86/boot/startup/sev-startup.c b/arch/x86/boot/startup/sev-startup.c
index a1d5a5632d58..1f928e8264bb 100644
--- a/arch/x86/boot/startup/sev-startup.c
+++ b/arch/x86/boot/startup/sev-startup.c
@@ -303,7 +303,7 @@ static __head void svsm_setup(struct cc_blob_sev_info *cc_info)
* running at VMPL0. The CA will be used to communicate with the
* SVSM to perform the SVSM services.
*/
- if (!svsm_setup_ca(cc_info))
+ if (!svsm_setup_ca(cc_info, rip_rel_ptr(&boot_svsm_ca_page)))
return;
/*
--
2.49.0.1045.g170613ef41-goog
next prev parent reply other threads:[~2025-05-12 19:11 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 19:08 [RFT PATCH v3 00/21] x86: strict separation of startup code Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 01/21] x86/sev: Separate MSR and GHCB based snp_cpuid() via a callback Ard Biesheuvel
2025-05-15 7:22 ` Ingo Molnar
2025-05-15 10:24 ` Ard Biesheuvel
2025-05-15 15:18 ` Ingo Molnar
2025-05-15 11:10 ` Borislav Petkov
2025-05-15 14:22 ` Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 02/21] x86/sev: Use MSR protocol for remapping SVSM calling area Ard Biesheuvel
2025-05-15 16:43 ` Borislav Petkov
2025-05-12 19:08 ` [RFT PATCH v3 03/21] x86/sev: Use MSR protocol only for early SVSM PVALIDATE call Ard Biesheuvel
2025-05-12 19:08 ` Ard Biesheuvel [this message]
2025-05-20 9:44 ` [RFT PATCH v3 04/21] x86/sev: Run RMPADJUST on SVSM calling area page to test VMPL Borislav Petkov
2025-05-12 19:08 ` [RFT PATCH v3 05/21] x86/sev: Move GHCB page based HV communication out of startup code Ard Biesheuvel
2025-05-20 11:38 ` Borislav Petkov
2025-05-20 11:49 ` Ard Biesheuvel
2025-05-20 13:58 ` Borislav Petkov
2025-05-12 19:08 ` [RFT PATCH v3 06/21] x86/sev: Avoid global variable to store virtual address of SVSM area Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 07/21] x86/sev: Move MSR save/restore out of early page state change helper Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 08/21] x86/sev: Share implementation of MSR-based page state change Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 09/21] x86/sev: Pass SVSM calling area down to early page state change API Ard Biesheuvel
2025-05-13 13:55 ` Ard Biesheuvel
2025-05-13 13:58 ` Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 10/21] x86/sev: Use boot SVSM CA for all startup and init code Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 11/21] x86/boot: Drop redundant RMPADJUST in SEV SVSM presence check Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 12/21] x86/sev: Unify SEV-SNP hypervisor feature check Ard Biesheuvel
2025-05-30 11:16 ` Borislav Petkov
2025-05-30 14:28 ` Ard Biesheuvel
2025-05-30 16:08 ` Borislav Petkov
2025-05-30 16:12 ` Ard Biesheuvel
2025-05-30 16:55 ` Borislav Petkov
2025-05-12 19:08 ` [RFT PATCH v3 13/21] x86/sev: Provide PIC aliases for SEV related data objects Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 14/21] x86/boot: Provide PIC aliases for 5-level paging related constants Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 15/21] x86/sev: Move __sev_[get|put]_ghcb() into separate noinstr object Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 16/21] x86/sev: Export startup routines for later use Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 17/21] x86/boot: Create a confined code area for startup code Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 18/21] x86/boot: Move startup code out of __head section Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 19/21] x86/boot: Disallow absolute symbol references in startup code Ard Biesheuvel
2025-05-12 19:08 ` [RFT PATCH v3 20/21] x86/boot: Revert "Reject absolute references in .head.text" Ard Biesheuvel
2025-06-01 9:39 ` Borislav Petkov
2025-05-12 19:08 ` [RFT PATCH v3 21/21] x86/boot: Get rid of the .head.text section Ard Biesheuvel
2025-05-12 19:17 ` [RFT PATCH v3 00/21] x86: strict separation of startup code Borislav Petkov
2025-05-13 10:02 ` Ingo Molnar
2025-05-13 10:12 ` Borislav Petkov
2025-05-13 11:22 ` Ingo Molnar
2025-05-13 14:16 ` Borislav Petkov
2025-05-13 15:01 ` Ard Biesheuvel
2025-05-13 16:44 ` Borislav Petkov
2025-05-13 21:31 ` Ard Biesheuvel
2025-05-14 6:32 ` Ingo Molnar
2025-05-14 7:41 ` Ard Biesheuvel
2025-05-15 7:17 ` Ingo Molnar
2025-05-14 6:20 ` Ingo Molnar
2025-05-14 8:17 ` Borislav Petkov
2025-05-14 8:21 ` Borislav Petkov
2025-05-14 9:54 ` Thomas Gleixner
2025-05-14 17:21 ` Borislav Petkov
2025-05-14 17:37 ` Ard Biesheuvel
2025-05-14 18:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512190834.332684-27-ardb+git@google.com \
--to=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dionnaglaze@google.com \
--cc=kevinloughlin@google.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.