All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@gentoo.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Alex Elder <elder@riscstar.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	mturquette@baylibre.com, sboyd@kernel.org,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr, heylenay@4d2.org,
	inochiama@outlook.com, guodong@riscstar.com,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 5/6] reset: spacemit: define three more CCUs
Date: Tue, 13 May 2025 20:12:08 +0000	[thread overview]
Message-ID: <20250513201208-GYA518096@gentoo> (raw)
In-Reply-To: <ecf46fa3116690b85f51539edf7f6a47c612fca5.camel@pengutronix.de>

Hi Philipp,

On 11:21 Tue 13 May     , Philipp Zabel wrote:
> On Mo, 2025-05-12 at 13:32 -0500, Alex Elder wrote:
> > Three more CCUs on the SpacemiT K1 SoC implement only resets, not clocks.
> > Define these resets so they can be used.
> > 
> > Signed-off-by: Alex Elder <elder@riscstar.com>
> > ---
> >  drivers/clk/spacemit/ccu-k1.c    | 24 +++++++++++++++
> >  drivers/reset/reset-spacemit.c   | 51 ++++++++++++++++++++++++++++++++
> >  include/soc/spacemit/k1-syscon.h | 30 +++++++++++++++++++
> 
> Could you split this into clk: and reset: parts? The reset changes are
> 
Do you have suggestion how we should merge the patch series in future?
What I can think of 
1) take patch 1, 2, 3 via clock tree, and provide an immutable tag
2) pull the tag, and take all driver/reset via reset tree, and provide an immutable tag back?
3) take the split part of drivers/clock/ in this one via clock tree

> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> 
> regards
> Philipp
> 

-- 
Yixun Lan (dlan)

WARNING: multiple messages have this Message-ID (diff)
From: Yixun Lan <dlan@gentoo.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Alex Elder <elder@riscstar.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	mturquette@baylibre.com, sboyd@kernel.org,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr, heylenay@4d2.org,
	inochiama@outlook.com, guodong@riscstar.com,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 5/6] reset: spacemit: define three more CCUs
Date: Tue, 13 May 2025 20:12:08 +0000	[thread overview]
Message-ID: <20250513201208-GYA518096@gentoo> (raw)
In-Reply-To: <ecf46fa3116690b85f51539edf7f6a47c612fca5.camel@pengutronix.de>

Hi Philipp,

On 11:21 Tue 13 May     , Philipp Zabel wrote:
> On Mo, 2025-05-12 at 13:32 -0500, Alex Elder wrote:
> > Three more CCUs on the SpacemiT K1 SoC implement only resets, not clocks.
> > Define these resets so they can be used.
> > 
> > Signed-off-by: Alex Elder <elder@riscstar.com>
> > ---
> >  drivers/clk/spacemit/ccu-k1.c    | 24 +++++++++++++++
> >  drivers/reset/reset-spacemit.c   | 51 ++++++++++++++++++++++++++++++++
> >  include/soc/spacemit/k1-syscon.h | 30 +++++++++++++++++++
> 
> Could you split this into clk: and reset: parts? The reset changes are
> 
Do you have suggestion how we should merge the patch series in future?
What I can think of 
1) take patch 1, 2, 3 via clock tree, and provide an immutable tag
2) pull the tag, and take all driver/reset via reset tree, and provide an immutable tag back?
3) take the split part of drivers/clock/ in this one via clock tree

> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> 
> regards
> Philipp
> 

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-05-13 20:12 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12 18:32 [PATCH v9 0/6] reset: spacemit: add K1 reset support Alex Elder
2025-05-12 18:32 ` Alex Elder
2025-05-12 18:32 ` [PATCH v9 1/6] dt-bindings: soc: spacemit: define spacemit,k1-ccu resets Alex Elder
2025-05-12 18:32   ` Alex Elder
2025-05-12 18:32 ` [PATCH v9 2/6] soc: spacemit: create a header for clock/reset registers Alex Elder
2025-05-12 18:32   ` Alex Elder
2025-05-13  5:02   ` Haylen Chu
2025-05-13  5:02     ` Haylen Chu
2025-05-12 18:32 ` [PATCH v9 3/6] clk: spacemit: set up reset auxiliary devices Alex Elder
2025-05-12 18:32   ` Alex Elder
2025-05-13  5:01   ` Haylen Chu
2025-05-13  5:01     ` Haylen Chu
2025-05-12 18:32 ` [PATCH v9 4/6] reset: spacemit: add support for SpacemiT CCU resets Alex Elder
2025-05-12 18:32   ` Alex Elder
2025-05-13  9:21   ` Philipp Zabel
2025-05-13  9:21     ` Philipp Zabel
2025-05-13 12:24     ` Alex Elder
2025-05-13 12:24       ` Alex Elder
2025-05-12 18:32 ` [PATCH v9 5/6] reset: spacemit: define three more CCUs Alex Elder
2025-05-12 18:32   ` Alex Elder
2025-05-13  9:21   ` Philipp Zabel
2025-05-13  9:21     ` Philipp Zabel
2025-05-13 20:12     ` Yixun Lan [this message]
2025-05-13 20:12       ` Yixun Lan
2025-05-13 20:36       ` Alex Elder
2025-05-13 20:36         ` Alex Elder
2025-05-12 18:32 ` [PATCH v9 6/6] riscv: dts: spacemit: add reset support for the K1 SoC Alex Elder
2025-05-12 18:32   ` Alex Elder
2025-05-13 20:28 ` [PATCH v9 0/6] reset: spacemit: add K1 reset support Yixun Lan
2025-05-13 20:28   ` Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250513201208-GYA518096@gentoo \
    --to=dlan@gentoo.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=elder@riscstar.com \
    --cc=guodong@riscstar.com \
    --cc=heylenay@4d2.org \
    --cc=inochiama@outlook.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.