Re: [PATCH v9 3/6] clk: spacemit: set up reset auxiliary devices

From: Haylen Chu <heylenay@4d2.org>
To: Alex Elder <elder@riscstar.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	mturquette@baylibre.com, sboyd@kernel.org,
	p.zabel@pengutronix.de, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr,
	dlan@gentoo.org
Cc: inochiama@outlook.com, guodong@riscstar.com,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 3/6] clk: spacemit: set up reset auxiliary devices
Date: Tue, 13 May 2025 05:01:10 +0000	[thread overview]
Message-ID: <aCLSFmSXLUQYi6on@ketchup> (raw)
In-Reply-To: <20250512183212.3465963-4-elder@riscstar.com>

On Mon, May 12, 2025 at 01:32:08PM -0500, Alex Elder wrote:
> Add a new reset_name field to the spacemit_ccu_data structure.  If it is
> non-null, the CCU implements a reset controller, and the name will be
> used in the name for the auxiliary device that implements it.
> 
> Define a new type to hold an auxiliary device as well as the regmap
> pointer that will be needed by CCU reset controllers.  Set up code to
> initialize and add an auxiliary device for any CCU that implements reset
> functionality.
> 
> Make it optional for a CCU to implement a clock controller.  This
> doesn't apply to any of the existing CCUs but will for some new ones
> that will be added soon.
> 
> Signed-off-by: Alex Elder <elder@riscstar.com>
> ---
> v9: Use ida_alloc() to assign the unique auxiliary device ID
> 
>  drivers/clk/spacemit/Kconfig     |   1 +
>  drivers/clk/spacemit/ccu-k1.c    | 104 ++++++++++++++++++++++++++++---
>  include/soc/spacemit/k1-syscon.h |  12 ++++
>  3 files changed, 107 insertions(+), 10 deletions(-)

Reviewed-by: Haylen Chu <heylenay@4d2.org>