From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Subject: Re: [PATCH v3 01/15] media: rcar-csi2: Use the pad version of v4l2_get_link_freq()
Date: Fri, 6 Jun 2025 13:57:12 +0200 [thread overview]
Message-ID: <20250606115712.GA2756718@ragnatech.se> (raw)
In-Reply-To: <20250530-rcar-streams-v3-1-026655df7138@ideasonboard.com>
Hi Tomi,
Thanks for your work.
On 2025-05-30 16:50:30 +0300, Tomi Valkeinen wrote:
> Use the new version of v4l2_get_link_freq() which supports media_pad as
> a parameter.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/media/platform/renesas/rcar-csi2.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/renesas/rcar-csi2.c b/drivers/media/platform/renesas/rcar-csi2.c
> index 9979de4f6ef1..ddbdde23c122 100644
> --- a/drivers/media/platform/renesas/rcar-csi2.c
> +++ b/drivers/media/platform/renesas/rcar-csi2.c
> @@ -954,6 +954,7 @@ static int rcsi2_set_phypll(struct rcar_csi2 *priv, unsigned int mbps)
> static int rcsi2_calc_mbps(struct rcar_csi2 *priv, unsigned int bpp,
> unsigned int lanes)
> {
> + struct media_pad *remote_pad;
> struct v4l2_subdev *source;
> s64 freq;
> u64 mbps;
> @@ -962,8 +963,9 @@ static int rcsi2_calc_mbps(struct rcar_csi2 *priv, unsigned int bpp,
> return -ENODEV;
>
> source = priv->remote;
> + remote_pad = &source->entity.pads[priv->remote_pad];
>
> - freq = v4l2_get_link_freq(source->ctrl_handler, bpp, 2 * lanes);
> + freq = v4l2_get_link_freq(remote_pad, bpp, 2 * lanes);
> if (freq < 0) {
> int ret = (int)freq;
>
>
> --
> 2.43.0
>
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2025-06-06 11:57 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 13:50 [PATCH v3 00/15] media: rcar: Streams support Tomi Valkeinen
2025-05-30 13:50 ` [PATCH v3 01/15] media: rcar-csi2: Use the pad version of v4l2_get_link_freq() Tomi Valkeinen
2025-06-02 9:43 ` Laurent Pinchart
2025-07-02 15:07 ` Niklas Söderlund
2025-07-02 20:51 ` Laurent Pinchart
2025-06-06 11:57 ` Niklas Söderlund [this message]
2025-05-30 13:50 ` [PATCH v3 02/15] media: rcar-isp: Improve ISPPROCMODE_DT_PROC_MODE_VC Tomi Valkeinen
2025-06-02 9:43 ` Laurent Pinchart
2025-06-06 11:58 ` Niklas Söderlund
2025-05-30 13:50 ` [PATCH v3 03/15] media: rcar-isp: Move {enable|disable}_streams() calls Tomi Valkeinen
2025-06-02 9:43 ` Laurent Pinchart
2025-09-26 11:22 ` Tomi Valkeinen
2025-09-27 6:17 ` Niklas Söderlund
2025-12-16 12:48 ` Tomi Valkeinen
2025-05-30 13:50 ` [PATCH v3 04/15] media: rcar-csi2: " Tomi Valkeinen
2025-06-02 9:43 ` Laurent Pinchart
2025-05-30 13:50 ` [PATCH v3 05/15] media: rcar-csi2: Move rcar2_calc_mbps() Tomi Valkeinen
2025-06-02 14:03 ` Laurent Pinchart
2025-06-06 12:03 ` Niklas Söderlund
2025-05-30 13:50 ` [PATCH v3 06/15] media: rcar-csi2: Simplify rcsi2_calc_mbps() Tomi Valkeinen
2025-06-02 9:43 ` Laurent Pinchart
2025-06-06 12:02 ` Niklas Söderlund
2025-05-30 13:50 ` [PATCH v3 07/15] media: rcar-csi2: Optimize rcsi2_calc_mbps() Tomi Valkeinen
2025-06-02 9:43 ` Laurent Pinchart
2025-06-06 12:07 ` Niklas Söderlund
2025-12-08 14:03 ` Tomi Valkeinen
2025-05-30 13:50 ` [PATCH v3 08/15] media: rcar-csi2: Switch to Streams API Tomi Valkeinen
2025-06-02 14:06 ` Laurent Pinchart
2025-12-16 13:15 ` Tomi Valkeinen
2025-06-06 12:09 ` Niklas Söderlund
2025-05-30 13:50 ` [PATCH v3 09/15] media: rcar-isp: " Tomi Valkeinen
2025-06-02 14:17 ` Laurent Pinchart
2025-06-06 12:10 ` Niklas Söderlund
2025-05-30 13:50 ` [PATCH v3 10/15] media: rcar-csi2: Add .get_frame_desc op Tomi Valkeinen
2025-06-02 9:44 ` Laurent Pinchart
2025-06-06 12:14 ` Niklas Söderlund
2025-12-16 13:18 ` Tomi Valkeinen
2025-12-16 13:22 ` Tomi Valkeinen
2025-05-30 13:50 ` [PATCH v3 11/15] media: rcar-isp: Call get_frame_desc to find out VC & DT Tomi Valkeinen
2025-06-02 13:22 ` Laurent Pinchart
2025-12-16 11:57 ` Tomi Valkeinen
2025-06-06 12:20 ` Niklas Söderlund
2025-12-16 13:35 ` Tomi Valkeinen
2025-05-30 13:50 ` [PATCH v3 12/15] media: rcar-csi2: Add more stream support to rcsi2_calc_mbps() Tomi Valkeinen
2025-06-02 13:28 ` Laurent Pinchart
2025-12-16 12:45 ` Tomi Valkeinen
2025-06-06 12:25 ` Niklas Söderlund
2025-05-30 13:50 ` [PATCH v3 13/15] media: rcar-csi2: Call get_frame_desc to find out VC & DT (Gen3) Tomi Valkeinen
2025-06-02 13:49 ` Laurent Pinchart
2025-12-16 12:58 ` Tomi Valkeinen
2025-05-30 13:50 ` [PATCH v3 14/15] media: rcar-csi2: Add full streams support Tomi Valkeinen
2025-06-02 13:54 ` Laurent Pinchart
2025-12-16 13:03 ` Tomi Valkeinen
2025-05-30 13:50 ` [PATCH v3 15/15] media: rcar-isp: " Tomi Valkeinen
2025-06-02 13:57 ` Laurent Pinchart
2025-12-16 13:11 ` Tomi Valkeinen
2025-06-06 12:32 ` [PATCH v3 00/15] media: rcar: Streams support Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606115712.GA2756718@ragnatech.se \
--to=niklas.soderlund@ragnatech.se \
--cc=jacopo.mondi@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.