All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: gustavo.sousa@intel.com, "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v2 0/4] PHY LFPS sending configuration fixes
Date: Tue, 22 Jul 2025 13:13:13 +0300	[thread overview]
Message-ID: <20250722101317.1728499-1-jouni.hogander@intel.com> (raw)

We are seeing "dmesg-warn/abort - *ERROR* PHY * failed after 3 retries"
since we started configuring LFPS sending. According to Bspec Configuring
LFPS sending is needed only when using AUXLess ALPM. This patch avoids
these failures by configuring LFPS sending only when using AUXLess ALPM.

Addition to PHY failure fix this patch set contains some additions
that were seen missing during review:

1. Ensure phy is accessible on lfps configuration
2. Set C10_VDR_CTRL_MSGBUS_ACCESS before phy reg read

Also one optimization is added to avoid unnecessarily calling
intel_cx0_get_owned_lane_mask.

v2:
  - split as a patch set
  - add ensuring phy is accessible on lfps configuration
  - set C10_VDR_CTRL_MSGBUS_ACCESS before phy reg read

Jouni Högander (4):
  drm/i915/display: Write PHY_CMN1_CONTROL only when using AUXLess ALPM
  drm/i915/display: Avoid unnecessarily calling
    intel_cx0_get_owned_lane_mask
  drm/i915/display: Ensure phy is accessible on lfps configuration
  drm/i915/display: Set C10_VDR_CTRL_MSGBUS_ACCESS before phy reg read

 drivers/gpu/drm/i915/display/intel_cx0_phy.c | 22 ++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

-- 
2.43.0


             reply	other threads:[~2025-07-22 10:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 10:13 Jouni Högander [this message]
2025-07-22 10:13 ` [PATCH v2 1/4] drm/i915/display: Write PHY_CMN1_CONTROL only when using AUXLess ALPM Jouni Högander
2025-07-22 11:57   ` Gustavo Sousa
2025-07-22 10:13 ` [PATCH v2 2/4] drm/i915/display: Avoid unnecessarily calling intel_cx0_get_owned_lane_mask Jouni Högander
2025-07-22 11:58   ` Gustavo Sousa
2025-07-22 10:13 ` [PATCH v2 3/4] drm/i915/display: Ensure phy is accessible on lfps configuration Jouni Högander
2025-07-22 12:02   ` Gustavo Sousa
2025-07-22 10:13 ` [PATCH v2 4/4] drm/i915/display: Set C10_VDR_CTRL_MSGBUS_ACCESS before phy reg read Jouni Högander
2025-07-22 12:07   ` Gustavo Sousa
2025-07-22 12:14     ` Hogander, Jouni
2025-07-22 10:31 ` ✓ CI.KUnit: success for PHY LFPS sending configuration fixes Patchwork
2025-07-22 11:07 ` ✓ i915.CI.BAT: " Patchwork
2025-07-22 11:53 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-22 13:32 ` ✗ Xe.CI.Full: failure " Patchwork
2025-07-22 14:09 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722101317.1728499-1-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.